Skip to content
Snippets Groups Projects
  • Matt Harbison's avatar
    31a4ea773369
    lfs: infer the blob store URL from an explicit push dest or default-push · 31a4ea773369
    Matt Harbison authored
    Unlike pull, the blobs are uploaded within the exchange.push() window, so simply
    wrap it and swap in a properly configured remote store.  The '_subtoppath' field
    shouldn't be available during this window, but give the passed path priority for
    clarity.
    
    At one point I hit an AttributeError in one of the convert tests when trying to
    save the original remote blobstore when the swap was run unconditionally.  I
    wrapped it in a util.safehasattr(), but then today I wasn't able to reproduce
    it.  But now the whole thing is tucked under the requirement guard because
    without the requirement, there are no blobs in the repo, even if the extension
    is loaded.
    31a4ea773369
    History
    lfs: infer the blob store URL from an explicit push dest or default-push
    Matt Harbison authored
    Unlike pull, the blobs are uploaded within the exchange.push() window, so simply
    wrap it and swap in a properly configured remote store.  The '_subtoppath' field
    shouldn't be available during this window, but give the passed path priority for
    clarity.
    
    At one point I hit an AttributeError in one of the convert tests when trying to
    save the original remote blobstore when the swap was run unconditionally.  I
    wrapped it in a util.safehasattr(), but then today I wasn't able to reproduce
    it.  But now the whole thing is tucked under the requirement guard because
    without the requirement, there are no blobs in the repo, even if the extension
    is loaded.