Skip to content
Snippets Groups Projects
  • Raphaël Gomès's avatar
    326fdce22fb2
    rust: switch hg-core and hg-cpython to rust 2018 edition · 326fdce22fb2
    Raphaël Gomès authored
    Many interesting changes have happened in Rust since the Oxidation Plan was
    introduced, like the 2018 edition and procedural macros:
    
        - Opting in to the 2018 edition is a clear benefit in terms of future
          proofing, new (nice to have) syntactical sugar notwithstanding. It
          also has a new non-lexical, non-AST based borrow checker that has
          fewer bugs(!) and allows us to write correct code that in some cases
          would have been rejected by the old one.
        - Procedural macros allow us to use the PyO3 crate which maintainers have
          expressed the clear goal of compiling on stable, which would help in
          code maintainability compared to rust-cpython.
    
    In this patch are the following changes:
        - Removing most `extern crate` uses
        - Updating `use` clauses (`crate` keyword, nested `use`)
        - Removing `mod.rs` in favor of an aptly named module file
    
    Like discussed in the mailing list (
    https://www.mercurial-scm.org/pipermail/mercurial-devel/2019-July/132316.html
    ), until Rust integration in Mercurial is considered to be out of the
    experimental phase, the maximum version of Rust allowed is whatever the latest
    version Debian packages.
    
    Differential Revision: https://phab.mercurial-scm.org/D6597
    326fdce22fb2
    History
    rust: switch hg-core and hg-cpython to rust 2018 edition
    Raphaël Gomès authored
    Many interesting changes have happened in Rust since the Oxidation Plan was
    introduced, like the 2018 edition and procedural macros:
    
        - Opting in to the 2018 edition is a clear benefit in terms of future
          proofing, new (nice to have) syntactical sugar notwithstanding. It
          also has a new non-lexical, non-AST based borrow checker that has
          fewer bugs(!) and allows us to write correct code that in some cases
          would have been rejected by the old one.
        - Procedural macros allow us to use the PyO3 crate which maintainers have
          expressed the clear goal of compiling on stable, which would help in
          code maintainability compared to rust-cpython.
    
    In this patch are the following changes:
        - Removing most `extern crate` uses
        - Updating `use` clauses (`crate` keyword, nested `use`)
        - Removing `mod.rs` in favor of an aptly named module file
    
    Like discussed in the mailing list (
    https://www.mercurial-scm.org/pipermail/mercurial-devel/2019-July/132316.html
    ), until Rust integration in Mercurial is considered to be out of the
    experimental phase, the maximum version of Rust allowed is whatever the latest
    version Debian packages.
    
    Differential Revision: https://phab.mercurial-scm.org/D6597
This project manages its dependencies using Cargo. Learn more
Cargo.toml 646 B