Skip to content
Snippets Groups Projects
  • Gregory Szorc's avatar
    8dab7c8a93eb
    upgrade: report size of backing files, not internal storage size · 8dab7c8a93eb
    Gregory Szorc authored
    upgrade.py is the only consumer of filelog.index, which I'd like
    to eliminate from the file storage interface.
    
    This commit changes the upgrade code to report the storage size
    of files by looking at the size of the files backing its storage
    instead of looking at the index.
    
    I'm not convinced the approach in this patch will live very long
    because it is relying on low-level attributes like "opener" and
    "files," which may behave very differently on non-revlog storage.
    But the data is only used for reporting purposes and it does get
    us one step closer to eliminating "index."
    
    A side-effect of this change is we now report the size of the revlog
    index data - not just the revision data. I think this is more
    accurate.
    
    Differential Revision: https://phab.mercurial-scm.org/D4717
    8dab7c8a93eb
    History
    upgrade: report size of backing files, not internal storage size
    Gregory Szorc authored
    upgrade.py is the only consumer of filelog.index, which I'd like
    to eliminate from the file storage interface.
    
    This commit changes the upgrade code to report the storage size
    of files by looking at the size of the files backing its storage
    instead of looking at the index.
    
    I'm not convinced the approach in this patch will live very long
    because it is relying on low-level attributes like "opener" and
    "files," which may behave very differently on non-revlog storage.
    But the data is only used for reporting purposes and it does get
    us one step closer to eliminating "index."
    
    A side-effect of this change is we now report the size of the revlog
    index data - not just the revision data. I think this is more
    accurate.
    
    Differential Revision: https://phab.mercurial-scm.org/D4717