Skip to content
Snippets Groups Projects
  • Augie Fackler's avatar
    78f1899e4202
    dummysmtpd: accept additional kwargs from stdlib smtpd · 78f1899e4202
    Augie Fackler authored
    This was causing extremely mysterious failures because smtpd is
    implemented using asynchat, which in turn doesn't appear to do
    anything *remotely* helpful if an exception occurs.
    
    # no-check-commit because I'm editing a foo_bar function signature
    
    test-patchbomb-tls.t now passes in Python 3, but only because it
    doesn't check message bodies like test-patchbomb.t. test-patchbomb.t
    is *full* of doubled headers in the output (eg [0]) which seems like
    an odd failure mode.
    
    
    0:
    @@ -141,12 +154,17 @@
       MIME-Version: 1.0
       Content-Type: text/plain; charset="us-ascii"
       Content-Transfer-Encoding: 7bit
    +  MIME-Version: 1.0
    +  Content-Type: text/plain; charset="us-ascii"
    +  Content-Transfer-Encoding: 7bit
       Subject: [PATCH] bookmark
       X-Mercurial-Node: 8dab2639fd35f1e337ad866c372a5c44f1064e3c
       X-Mercurial-Series-Index: 1
       X-Mercurial-Series-Total: 1
    
    Differential Revision: https://phab.mercurial-scm.org/D4219
    78f1899e4202
    History
    dummysmtpd: accept additional kwargs from stdlib smtpd
    Augie Fackler authored
    This was causing extremely mysterious failures because smtpd is
    implemented using asynchat, which in turn doesn't appear to do
    anything *remotely* helpful if an exception occurs.
    
    # no-check-commit because I'm editing a foo_bar function signature
    
    test-patchbomb-tls.t now passes in Python 3, but only because it
    doesn't check message bodies like test-patchbomb.t. test-patchbomb.t
    is *full* of doubled headers in the output (eg [0]) which seems like
    an odd failure mode.
    
    
    0:
    @@ -141,12 +154,17 @@
       MIME-Version: 1.0
       Content-Type: text/plain; charset="us-ascii"
       Content-Transfer-Encoding: 7bit
    +  MIME-Version: 1.0
    +  Content-Type: text/plain; charset="us-ascii"
    +  Content-Transfer-Encoding: 7bit
       Subject: [PATCH] bookmark
       X-Mercurial-Node: 8dab2639fd35f1e337ad866c372a5c44f1064e3c
       X-Mercurial-Series-Index: 1
       X-Mercurial-Series-Total: 1
    
    Differential Revision: https://phab.mercurial-scm.org/D4219