Skip to content
Snippets Groups Projects
  • Pierre-Yves David's avatar
    d410336fdb3c
    push: make pushkey part advisory · d410336fdb3c
    Pierre-Yves David authored
    The current behavior (with bundle1) is to let the rest of the push succeed if
    the pushkey call (phases, bookmarks) failed (this comes from the fact that each
    item is sent in its own command).
    
    We kept this behavior with bundle2, which is highly debatable, but let us keep
    thing as they are now as a start. We are about to enforce 'mandatory' pushkey
    part as 'mandatory' successful, so we need to marks parts as advisory to
    preserve the current (debatable) behavior.
    d410336fdb3c
    History
    push: make pushkey part advisory
    Pierre-Yves David authored
    The current behavior (with bundle1) is to let the rest of the push succeed if
    the pushkey call (phases, bookmarks) failed (this comes from the fact that each
    item is sent in its own command).
    
    We kept this behavior with bundle2, which is highly debatable, but let us keep
    thing as they are now as a start. We are about to enforce 'mandatory' pushkey
    part as 'mandatory' successful, so we need to marks parts as advisory to
    preserve the current (debatable) behavior.