Skip to content
Snippets Groups Projects
Commit 05086b56 authored by Sean Farley's avatar Sean Farley
Browse files

color: extract method for determining a valid effect

This patch is just setup work so that we can reduce code duplication and have
one place to define a valid effect.
parent a05d6945
No related branches found
No related tags found
No related merge requests found
......@@ -311,6 +311,15 @@
for name, ext in extensions.extensions():
_styles.update(getattr(ext, 'colortable', {}))
def valideffect(effect):
'Determine if the effect is valid or not.'
good = False
if not _terminfo_params and effect in _effects:
good = True
elif effect in _terminfo_params or effect[:-11] in _terminfo_params:
good = True
return good
def configstyles(ui):
for status, cfgeffects in ui.configitems('color'):
if '.' not in status or status.startswith('color.'):
......@@ -319,9 +328,7 @@
if cfgeffects:
good = []
for e in cfgeffects:
if not _terminfo_params and e in _effects:
good.append(e)
elif e in _terminfo_params or e[:-11] in _terminfo_params:
if valideffect(e):
good.append(e)
else:
ui.warn(_("ignoring unknown color/effect %r "
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment