Skip to content
Snippets Groups Projects
Commit 06a33a50 authored by Ian Moody's avatar Ian Moody
Browse files

phabricator: treat non-utf-8 text files as binary as phabricator requires

Phabricator can't cope with text files that are not UTF-8, so requires them to
be submitted as binary files instead.  This has the unfortunate effect of
making them practically unreviewable in Phabricator since it will only display
the separate versions of the file in other views, not a diff.  `phabread`ing
such submissions are similar, since it will just output the binary patch, but
`hg import` copes with it fine and `hg diff` afterwards will show the actual
changes.  It is still a marked improvement over trying to submit them as text,
which just leads to corruption (Phabricator will either output ? or HTML
entities for non-UTF-8 characters, depending on context).

Running decode on the whole file like this seems slightly unfortunate, but I'm
not aware of a better way.
Needs to be done to p1() version as well to detect conversions to UTF-8.

Differential Revision: https://phab.mercurial-scm.org/D7054
parent af067d29
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment