Skip to content
Snippets Groups Projects
Commit 1d937e49 authored by Pierre-Yves David's avatar Pierre-Yves David :octopus:
Browse files

safehasattr: pass attribute name as string instead of bytes

This is a step toward replacing `util.safehasattr` usage with plain `hasattr`.
The builtin function behave poorly in Python2 but this was fixed in Python3.

These change are done one by one as they tend to have a small odd to trigger
puzzling breackage.
parent 921a7273
No related branches found
No related tags found
2 merge requests!618Draft: 6.5rc0,!555simple preliminary changes toward getting ride of "util.safehasattr"
......@@ -1127,7 +1127,7 @@
This boldly assumes the other contains valid revs only.
"""
# other not a smartset, make is so
if not util.safehasattr(other, b'isascending'):
if not util.safehasattr(other, 'isascending'):
# filter out hidden revision
# (this boldly assumes all smartset are pure)
#
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment