Skip to content
Snippets Groups Projects
Commit 2b6a795f19f7 authored by Katsunori FUJIWARA's avatar Katsunori FUJIWARA
Browse files

bookmarks: rename arguments/variables for source code readability

Before this patch, the argument bound to the source repository of
incoming bookmarks for "bookmarks.diff()" is named as "remote".

But in "hg outgoing" case, this argument is bound to local repository
object.

In addition to it, "local"/"remote" seem to mean not the direction of
propagation of bookmarks, but just the location of cooperative
repositories.

To indicate the direction of propagation of bookmarks clearly on the
source code, this patch uses "d(st)" and "s(rc)" combination instead
of "l(ocal)" and "r(emote)" one.

  - "repo" and "remote" arguments are renamed to "dst" and "src"
  - "lmarks" and "rmarks" variables are renamed to "dmarsk" and "smarks"
parent 5b6c8f2fbda5
No related branches found
No related tags found
No related merge requests found
......@@ -237,6 +237,6 @@
if changed:
write(repo)
def diff(ui, repo, remote):
def diff(ui, dst, src):
ui.status(_("searching for changed bookmarks\n"))
......@@ -241,5 +241,5 @@
ui.status(_("searching for changed bookmarks\n"))
lmarks = repo.listkeys('bookmarks')
rmarks = remote.listkeys('bookmarks')
smarks = src.listkeys('bookmarks')
dmarks = dst.listkeys('bookmarks')
......@@ -245,3 +245,3 @@
diff = sorted(set(rmarks) - set(lmarks))
diff = sorted(set(smarks) - set(dmarks))
for k in diff:
......@@ -247,5 +247,5 @@
for k in diff:
mark = ui.debugflag and rmarks[k] or rmarks[k][:12]
mark = ui.debugflag and smarks[k] or smarks[k][:12]
ui.write(" %-25s %s\n" % (k, mark))
if len(diff) <= 0:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment