Skip to content
Snippets Groups Projects
Commit 30357611 authored by Martin von Zweigbergk's avatar Martin von Zweigbergk
Browse files

import-checker: allow all absolute imports of stdlib modules

Before this patch, we didn't allow imports like

  from importlib import resources

(That's the reason I used `import importlib.resources` in D7629.)

I think that form is still an absolute import, so I don't think we
forbade on purpose.

Differential Revision: https://phab.mercurial-scm.org/D7700
parent d825e7e0
No related branches found
No related tags found
No related merge requests found
......@@ -536,7 +536,7 @@
if not fullname or (
fullname in stdlib_modules
# allow standard 'from typing import ...' style
and fullname != 'typing'
and fullname.startswith('.')
and fullname not in localmods
and fullname + '.__init__' not in localmods
):
......
......@@ -47,6 +47,11 @@
> from .. import os
> EOF
$ cat > testpackage/stdlibfrom.py << EOF
> from __future__ import absolute_import
> from collections import abc
> EOF
$ cat > testpackage/symbolimport.py << EOF
> from __future__ import absolute_import
> from .unsorted import foo
......@@ -150,6 +155,7 @@
testpackage/requirerelative.py:2: import should be relative: testpackage.unsorted
testpackage/sortedentries.py:2: imports from testpackage not lexically sorted: bar < foo
testpackage/stdafterlocal.py:3: stdlib import "os" follows local import: testpackage
testpackage/stdlibfrom.py:2: direct symbol import abc from collections
testpackage/subpackage/levelpriority.py:3: higher-level import should come first: testpackage
testpackage/subpackage/localimport.py:7: multiple "from .. import" statements
testpackage/subpackage/localimport.py:8: import should be relative: testpackage.subpackage.levelpriority
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment