Skip to content
Snippets Groups Projects
Commit 4257c33e24b7 authored by Martin von Zweigbergk's avatar Martin von Zweigbergk
Browse files

check-code: allow command substitution with $(command)

Both `command` and $(command) are specified by POSIX. The latter nests
better. I don't see why we shouldn't allow both (or only the latter).

Differential Revision: https://phab.mercurial-scm.org/D6789
parent 5ca351ba2478
No related branches found
No related tags found
No related merge requests found
......@@ -116,7 +116,6 @@
(r'\bls\b.*-\w*R', "don't use 'ls -R', use 'find'"),
(r'printf.*[^\\]\\([1-9]|0\d)', r"don't use 'printf \NNN', use Python"),
(r'printf.*[^\\]\\x', "don't use printf \\x, use Python"),
(r'\$\(.*\)', "don't use $(expr), use `expr`"),
(r'rm -rf \*', "don't use naked rm -rf, target a directory"),
(r'\[[^\]]+==', '[ foo == bar ] is a bashism, use [ foo = bar ] instead'),
(r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w',
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment