Skip to content
Snippets Groups Projects
Commit 5f22c92d authored by Matt Harbison's avatar Matt Harbison
Browse files

demandimport: convert ignored modules from bytes -> str in extensions

The default list of ignored modules are str, and test for bypassing the lazy
import is `module.__name__ in ignores`, so these were effectively NOT ignored.
Most of these date back to the grand byteification in 687b865b95ad, with some
subsequent additions that followed the existing example.

I have no idea if these modules in fact need to bypass lazy importing, but at
least it follows the intent of the code.
parent fc719967
No related branches found
No related tags found
2 merge requests!300branching: merge stable into default,!276demandimport: convert ignored modules from bytes -> str in extensions
......@@ -23,9 +23,9 @@
# these do not work with demandimport, blacklist
demandimport.IGNORES.update(
[
b'breezy.transactions',
b'breezy.urlutils',
b'ElementPath',
'breezy.transactions',
'breezy.urlutils',
'ElementPath',
]
)
......
......@@ -11,7 +11,7 @@
from mercurial import demandimport
demandimport.IGNORES.update([b'pkgutil', b'pkg_resources', b'__main__'])
demandimport.IGNORES.update(['pkgutil', 'pkg_resources', '__main__'])
from mercurial import (
encoding,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment