Skip to content
Snippets Groups Projects
Commit 7a430116 authored by Martin von Zweigbergk's avatar Martin von Zweigbergk
Browse files

ui: add a context manager for silencing the ui (pushbuffer+popbuffer)

We often silence the ui by calling `ui.pushbuffer()` followed (a later
in the code) by `ui.popbuffer()`. These places can be identified by
the fact that they ignore the output returned from
`ui.popbuffer()`. Let's create a context manager for these cases, to
avoid repetition, and to avoid accidentally leaving the ui silent on
exceptions. I deliberately called the new function `silent()` instead
of `buffered()`, because it's just an implementation detail that it
uses `pushbuffer()` and `popbuffer()`. We could later optimize it to
not buffer the output.

Differential Revision: https://phab.mercurial-scm.org/D10884
parent 6ecd0980
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment