Skip to content
Snippets Groups Projects
Commit 89793289c891 authored by Gregory Szorc's avatar Gregory Szorc
Browse files

tests: remove pid file by default

Previously, killdaemons.py would kill PIDs listed in a file then
leave the file lingering around.

If the PIDs are killed, then there's no point leaving the PID file
around. In the worst case, a later invocation of killdaemons.py
(run-tests.py invokes killdaemons.py after running a test) could kill
a separate process whose PID conflicted with a previously-killed
process. By removing the PID file, we eliminate this possibility.

Some tests were manually removing the PID file after calling
killdaemons.py. So we update these tests to not do this.

Differential Revision: https://phab.mercurial-scm.org/D3443
parent b4b7427b5786
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment