Skip to content
Snippets Groups Projects
Commit 8ebb05f7 authored by Yuya Nishihara's avatar Yuya Nishihara
Browse files

fix: disable use of thread-based worker

getfixes() accesses to repo, changectx, filectx, etc., so I believe there
are code paths triggering data race. Mercurial API isn't thread safe in
general.
parent 14b6afc6
No related branches found
No related tags found
No related merge requests found
...@@ -157,7 +157,8 @@ ...@@ -157,7 +157,8 @@
# Don't waste memory/time passing unchanged content back, but # Don't waste memory/time passing unchanged content back, but
# produce one result per item either way. # produce one result per item either way.
yield (rev, path, newdata if newdata != olddata else None) yield (rev, path, newdata if newdata != olddata else None)
results = worker.worker(ui, 1.0, getfixes, tuple(), workqueue) results = worker.worker(ui, 1.0, getfixes, tuple(), workqueue,
threadsafe=False)
# We have to hold on to the data for each successor revision in memory # We have to hold on to the data for each successor revision in memory
# until all its parents are committed. We ensure this by committing and # until all its parents are committed. We ensure this by committing and
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment