rust-update: handle SIGINT from long-running update threads
The current code does not respond to ^C until after the Rust bit is finished doing its work. This is expected, since Rust holds the GIL for the duration of the call and does not call `PyErr_CheckSignals`. Freeing the GIL to do our work does not really improve anything since the Rust threads are still going, and the only way of cancelling a thread is by making it cooperate. So we do the following: - remember the SIGINT handler in hg-cpython and reset it after the call into core (see inline comment in `update.rs` about this) - make all update threads watch for a global `AtomicBool` being `true`, and if so stop their work - reset the global bool and exit early (i.e. before writing the dirstate) - raise SIGINT from `hg-cpython` if update returns `InterruptReceived`
parent
fa58f4f9
No related branches found
No related tags found
Pipeline #92256 passed
Stage: build
Stage: checks
Stage: tests
Stage: platform-compat
Stage: py-version-compat
Showing
- rust/Cargo.lock 29 additions, 0 deletionsrust/Cargo.lock
- rust/hg-core/Cargo.toml 1 addition, 0 deletionsrust/hg-core/Cargo.toml
- rust/hg-core/src/errors.rs 3 additions, 0 deletionsrust/hg-core/src/errors.rs
- rust/hg-core/src/lib.rs 5 additions, 1 deletionrust/hg-core/src/lib.rs
- rust/hg-core/src/update.rs 29 additions, 4 deletionsrust/hg-core/src/update.rs
- rust/hg-cpython/src/update.rs 7 additions, 5 deletionsrust/hg-cpython/src/update.rs
- rust/hg-cpython/src/utils.rs 41 additions, 3 deletionsrust/hg-cpython/src/utils.rs
Loading
Please register or sign in to comment