Skip to content
Snippets Groups Projects
Commit 98d996a1 authored by Raphaël Gomès's avatar Raphaël Gomès
Browse files

rust-cross-platform: remove `unimplemented!` to get compile-time errors

We should get a compile-time error that there is missing functionality for the
targeted platform instead of the program breaking at runtime.

Differential Revision: https://phab.mercurial-scm.org/D7107
parent 63d440be
No related branches found
No related tags found
No related merge requests found
......@@ -21,12 +21,9 @@
use std::os::unix::ffi::OsStrExt;
os_str = std::ffi::OsStr::from_bytes(bytes);
}
#[cfg(windows)]
{
// TODO: convert from Windows MBCS (ANSI encoding) to WTF8.
// Perhaps, the return type would have to be Result<PathBuf>.
unimplemented!()
}
// TODO Handle other platforms
// TODO: convert from WTF8 to Windows MBCS (ANSI encoding).
// Perhaps, the return type would have to be Result<PathBuf>.
Path::new(os_str)
}
......
......@@ -258,11 +258,8 @@
use std::os::unix::ffi::OsStrExt;
os_str = std::ffi::OsStr::from_bytes(&hg_path.as_ref().as_bytes());
}
#[cfg(windows)]
{
// TODO: convert from Windows MBCS (ANSI encoding) to WTF8.
unimplemented!();
}
// TODO Handle other platforms
// TODO: convert from WTF8 to Windows MBCS (ANSI encoding).
Ok(os_str.to_os_string())
}
......@@ -281,11 +278,9 @@
use std::os::unix::ffi::OsStrExt;
buf = HgPathBuf::from_bytes(&os_string.as_ref().as_bytes());
}
#[cfg(windows)]
{
// TODO: convert from WTF8 to Windows MBCS (ANSI encoding).
unimplemented!();
}
// TODO Handle other platforms
// TODO: convert from WTF8 to Windows MBCS (ANSI encoding).
buf.check_state()?;
Ok(buf)
}
......@@ -300,11 +295,9 @@
use std::os::unix::ffi::OsStrExt;
buf = HgPathBuf::from_bytes(&os_str.as_bytes());
}
#[cfg(windows)]
{
// TODO: convert from WTF8 to Windows MBCS (ANSI encoding).
unimplemented!();
}
// TODO Handle other platforms
// TODO: convert from WTF8 to Windows MBCS (ANSI encoding).
buf.check_state()?;
Ok(buf)
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment