commit: improve the files field of changelog for merges
Currently, the files list of merge commits repeats all the deletions (either actual deletions, or files that got renamed) that happened between base and p2 of the merge. If p2 is the main branch, the list can easily be much bigger than the change being merged. This results in various problems worth improving: - changelog is bigger than necessary - `hg log directory` lists many unrelated merge commits, and `hg log -v -r commit` frequently fills multiple screens worth of files - it possibly slows down adjustlinkrev, by forcing it to read more manifests, and that function can certainly be a bottleneck - the server side of pulls can waste a lot of time simply opening the filelogs for pointless files (the constant factors for opening even a tiny filelog is apparently pretty bad) So stop listing such files as described in the code. Impacted merge commits and their descendants get a different hash than they would have without this. This doesn't seem problematic, except for convert. The previous commit helped with that in the hg->hg case (but if you do svn->hg twice from scratch, hashes can still change). The rest of the description is numbers. I don't have much to report, because recreating the files list of existing repositories is not easy: - debugupgradeformat and bundle/unbundle don't recreate the list - export/import tends to choke quickly applying patches or on description that contain diffs, - merge commits from the convert extension don't have the right files list for reasons orthogonal to the current commit - replaying the merge with hg update/hg merge/hg revert --all/hg commit can end up failing in hg revert - I wasn't sure that using debugsetparents + debugrebuilddirstate would really build the right thing I measured commit time before and after this change, in a case with no files filtered out, several files filtered out (no difference) and 5k files filtered out (+1% time). Recreating the 100 more recent merges in a private repo, the concatenated uncompressed files lists goes from 1.12MB to 0.52MB. Excluding 3 merges that are not representative, then the size goes from 570k to 15k. I converted part of mozilla-central, and observed file list shrinking quite a bit too, starting at the very first merge, 733641d9feaf, going from 550 files to 10 files (although they have relatively few merges, so they probably wouldn't care). Differential Revision: https://phab.mercurial-scm.org/D6613
Showing
- mercurial/localrepo.py 41 additions, 0 deletionsmercurial/localrepo.py
- tests/test-backout.t 2 additions, 2 deletionstests/test-backout.t
- tests/test-commit-amend.t 25 additions, 25 deletionstests/test-commit-amend.t
- tests/test-convert-filemap.t 1 addition, 2 deletionstests/test-convert-filemap.t
- tests/test-convert-hg-startrev.t 3 additions, 3 deletionstests/test-convert-hg-startrev.t
- tests/test-copies.t 3 additions, 3 deletionstests/test-copies.t
- tests/test-glog-beautifygraph.t 17 additions, 17 deletionstests/test-glog-beautifygraph.t
- tests/test-glog.t 17 additions, 17 deletionstests/test-glog.t
- tests/test-issue672.t 4 additions, 4 deletionstests/test-issue672.t
- tests/test-lfconvert.t 4 additions, 4 deletionstests/test-lfconvert.t
- tests/test-merge-combination.t 2 additions, 2 deletionstests/test-merge-combination.t
- tests/test-rebase-inmemory.t 3 additions, 3 deletionstests/test-rebase-inmemory.t
- tests/test-rebase-newancestor.t 7 additions, 7 deletionstests/test-rebase-newancestor.t
- tests/test-revset.t 6 additions, 11 deletionstests/test-revset.t
- tests/test-revset2.t 27 additions, 28 deletionstests/test-revset2.t
- tests/test-template-keywords.t 2 additions, 2 deletionstests/test-template-keywords.t
Loading
-
mentioned in commit 691363267af4
-
mentioned in commit 4dd62d520f4f
-
mentioned in commit e82428dec2da
-
mentioned in commit 0af07a36fa71
-
mentioned in commit 652e18ab2341
-
mentioned in commit 7da1bf75e368
-
mentioned in commit 09b262194bfd
-
mentioned in commit 82d22e111689
-
mentioned in commit 6a71c8f2c6b3
-
mentioned in commit 1a2a4c4860ea
-
mentioned in commit 0542f600c7ab
-
mentioned in commit 07539f50b9bb
-
mentioned in commit 36bf44d47666
-
mentioned in commit 0e2581734f35
-
mentioned in commit e0313b0a6f7e
Please register or sign in to comment