Skip to content
Snippets Groups Projects
Commit ca4fabca authored by Matt Harbison's avatar Matt Harbison
Browse files

hghave: update the check for virtualenv

This started as `hghave --test-features` failing on Windows in `test-hghave.t`.
IDK how this ever worked, as neither my Linux nor Windows machines have this
with virtualenv 20.2.2, even on py2.  I think this was noticed recently because
357d8415aa27 mentioned an AttributeError, and mitigated by making this py2 only.
But as mentioned, this is also a problem on py2 (where the failure was
observed).

When I got this working by removing the attribute reference, the command in the
test failed because the `--no-site-package` argument was removed some time ago.
Therefore, this backs out 357d8415aa27 and references a known good attribute
(which was done to suppress the warning about an unused import) that also
ensures the command does not need the argument.  Since there appears to be
(minor) broken stuff on py3, manually apply the `no-py3` guard that was backed
out of the check itself.
parent c581b9ee
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment