Skip to content
Snippets Groups Projects
Commit ccf86aa5 authored by Anton Shestakov's avatar Anton Shestakov
Browse files

hgweb: use strict equals in mercurial.js

This patch changes "==" (equals operator) to "===" (strict equals operator).
The difference between them is that the latter doesn't do any type coercions.
It's handy to compare string '1' to number 1 sometimes, but most of the time
using "==" is inadvertent and can be replaced by an explicit type conversion.
(This corresponds to "eqeqeq" option of jshint).

Some of the changes in this patch are straightforward, e.g. when comparing
results of typeof (they could only be strings). The same goes for 'none' and
similar strings that can't be sensibly coerced to some other type. Two changes
that compare values to "1" and "0" can be clarified: getAttribute() returns
either a string or null, but comparing null to a string is always false, so no
logic is lost.
parent 9f44d446
No related branches found
No related tags found
No related merge requests found
......@@ -60,5 +60,5 @@
// provides the multiplier that should be applied to
// the foreground colours.
var s;
if(typeof color == "string") {
if(typeof color === "string") {
s = "#" + color;
......@@ -64,5 +64,5 @@
s = "#" + color;
} else { //typeof color == "number"
} else { //typeof color === "number"
color %= colors.length;
var red = (colors[color][0] * fg) || bg;
var green = (colors[color][1] * fg) || bg;
......@@ -124,7 +124,7 @@
this.columns += 1;
}
if (start == this.columns && start > end) {
if (start === this.columns && start > end) {
fold = true;
}
......@@ -229,7 +229,7 @@
for (var unit in scales){
var s = scales[unit];
var n = Math.floor(delta / s);
if ((n >= 2) || (s == 1)){
if ((n >= 2) || (s === 1)){
if (future){
return format(n, unit) + ' from now';
} else {
......@@ -257,7 +257,7 @@
function toggleDiffstat() {
var curdetails = document.getElementById('diffstatdetails').style.display;
var curexpand = curdetails == 'none' ? 'inline' : 'none';
var curexpand = curdetails === 'none' ? 'inline' : 'none';
document.getElementById('diffstatdetails').style.display = curexpand;
document.getElementById('diffstatexpand').style.display = curdetails;
}
......@@ -380,7 +380,7 @@
appendFormatHTML(container, messageFormat, message);
},
function onsuccess(htmlText) {
if (mode == 'graph') {
if (mode === 'graph') {
var sizes = htmlText.match(/^\s*<canvas id="graph" width="(\d+)" height="(\d+)"><\/canvas>$/m);
var addWidth = sizes[1];
var addHeight = sizes[2];
......@@ -457,7 +457,7 @@
window.location.search = urlParams.toString();
}
var allChecked = form.getAttribute("data-ignorews") == "1";
var allChecked = form.getAttribute("data-ignorews") === "1";
for (var i = 0; i < KEYS.length; i++) {
var key = KEYS[i];
......@@ -468,6 +468,6 @@
}
currentValue = form.getAttribute("data-" + key);
checkbox.checked = currentValue != "0";
checkbox.checked = currentValue !== "0";
// ignorews implies ignorewsamount and ignorewseol.
......@@ -472,6 +472,6 @@
// ignorews implies ignorewsamount and ignorewseol.
if (allChecked && (key == "ignorewsamount" || key == "ignorewseol")) {
if (allChecked && (key === "ignorewsamount" || key === "ignorewseol")) {
checkbox.checked = true;
checkbox.disabled = true;
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment