Skip to content
Snippets Groups Projects
Commit e8348f1cc228 authored by Matt Mackall's avatar Matt Mackall
Browse files

factotum: use try/except/finally

parent 68633ff2b608
No related branches found
No related tags found
No related merge requests found
......@@ -67,21 +67,20 @@
while True:
fd = os.open('%s/rpc' % _mountpoint, os.O_RDWR)
try:
try:
os.write(fd, 'start %s' % params)
l = os.read(fd, ERRMAX).split()
if l[0] == 'ok':
os.write(fd, 'read')
status, user, passwd = os.read(fd, ERRMAX).split(None, 2)
if status == 'ok':
if passwd.startswith("'"):
if passwd.endswith("'"):
passwd = passwd[1:-1].replace("''", "'")
else:
raise util.Abort(_('malformed password string'))
return (user, passwd)
except (OSError, IOError):
raise util.Abort(_('factotum not responding'))
os.write(fd, 'start %s' % params)
l = os.read(fd, ERRMAX).split()
if l[0] == 'ok':
os.write(fd, 'read')
status, user, passwd = os.read(fd, ERRMAX).split(None, 2)
if status == 'ok':
if passwd.startswith("'"):
if passwd.endswith("'"):
passwd = passwd[1:-1].replace("''", "'")
else:
raise util.Abort(_('malformed password string'))
return (user, passwd)
except (OSError, IOError):
raise util.Abort(_('factotum not responding'))
finally:
os.close(fd)
getkey(self, params)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment