Skip to content
Snippets Groups Projects
Commit ee826f43 authored by Martin von Zweigbergk's avatar Martin von Zweigbergk
Browse files

hgweb: don't call sys.exit() in httpservice.run()

If I'm reading the code correctly, `mercurial.server.createservice()`
can return an hgweb service or one of three types of command server
services. The caller then calls `mercurial.server.runservice()`,
passing it the returned service's run method. Only the hgweb service
was calling `sys.exit()`. It has been that way since 8d44649df03b
(refactor ssh server., 2006-06-04). That commit message doesn't
provide any explanation. Let's clean up and have the code follow the
usual return path into the `dispatch` module.

After this patch, there should be no remaining places left where we
call `sys.exit()` except for valid uses in the `dispatch` and `worker`
modules.

Differential Revision: https://phab.mercurial-scm.org/D9272
parent d6279c43
No related branches found
No related tags found
No related merge requests found
...@@ -9,7 +9,6 @@ ...@@ -9,7 +9,6 @@
from __future__ import absolute_import from __future__ import absolute_import
import os import os
import sys
from ..i18n import _ from ..i18n import _
...@@ -112,7 +111,6 @@ ...@@ -112,7 +111,6 @@
def run(self): def run(self):
self.httpd.serve_forever() self.httpd.serve_forever()
sys.exit(0)
def createapp(baseui, repo, webconf): def createapp(baseui, repo, webconf):
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment