Skip to content
Snippets Groups Projects
Commit fe5f044b authored by Mads Kiilerich's avatar Mads Kiilerich
Browse files

changelog: use headrevsfiltered

2b5940f64750 introduced use of the new filtering headrevs C implementation. It
caught TypeError to detect when to fall back to the implementation that was
compatible with old extensions. That method was however not reliable.

Instead, use the new headrevsfiltered function when passing a filter. It will
reliably fail with AttributeError when an old extension that predates
headrevsfiltered is used.
parent 42342f9a
No related branches found
No related tags found
No related merge requests found
......@@ -172,10 +172,10 @@
def headrevs(self):
if self.filteredrevs:
try:
return self.index.headrevs(self.filteredrevs)
# AttributeError covers non-c-extension environments.
# TypeError allows us work with old c extensions.
except (AttributeError, TypeError):
return self.index.headrevsfiltered(self.filteredrevs)
# AttributeError covers non-c-extension environments and
# old c extensions without filter handling.
except AttributeError:
return self._headrevs()
return super(changelog, self).headrevs()
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment