Skip to content
Snippets Groups Projects
  1. May 08, 2014
  2. May 07, 2014
  3. May 05, 2014
    • Gregory Szorc's avatar
      tests: declare commands using decorator · 51e5c793a9f4
      Gregory Szorc authored
      51e5c793a9f4
    • Gregory Szorc's avatar
      share: declare commands using decorator · d2ce7a20fe86
      Gregory Szorc authored
      d2ce7a20fe86
    • Gregory Szorc's avatar
      relink: declare command using decorator · da0eb4970913
      Gregory Szorc authored
      da0eb4970913
    • Gregory Szorc's avatar
      record: declare commands using decorator · a836fa58b512
      Gregory Szorc authored
      a836fa58b512
    • Gregory Szorc's avatar
      hgk: declare commands using decorator · 8d354d58147c
      Gregory Szorc authored
      8d354d58147c
    • Gregory Szorc's avatar
      color: declare command using decorator · 2b8697e20978
      Gregory Szorc authored
      2b8697e20978
    • Gregory Szorc's avatar
      children: declare command using decorator · 48e859e30cbf
      Gregory Szorc authored
      48e859e30cbf
    • Gregory Szorc's avatar
      fetch: declare command using decorator · b1e64c6720d8
      Gregory Szorc authored
      b1e64c6720d8
    • Gregory Szorc's avatar
      extdiff: declare command using decorator · 29eeaa6d662f
      Gregory Szorc authored
      29eeaa6d662f
    • Gregory Szorc's avatar
      churn: declare command using decorator · 75c8720092ba
      Gregory Szorc authored
      75c8720092ba
    • Gregory Szorc's avatar
      convert: declare commands using decorator · f0dbafceeb9a
      Gregory Szorc authored
      f0dbafceeb9a
    • Gregory Szorc's avatar
      debugshell: declare command using decorator · 8b5c039f2b4f
      Gregory Szorc authored
      8b5c039f2b4f
    • Gregory Szorc's avatar
      largefiles: declare commands using decorator · 4c94229c51fb
      Gregory Szorc authored
      4c94229c51fb
    • Katsunori FUJIWARA's avatar
      cmdutil: omit redundant "savecommitmessage()" in "tryimportone()" · 244b177a152e
      Katsunori FUJIWARA authored
      The preceding patch causes that "makememctx()" with "editor" argument
      saves (manually edited) commit message into ".hg/last-message.txt":
      saving itself is executed indirectly in "memctx.__init__()".
      
      This makes it redundant to invoke "savecommitmessage()" on caller side
      of "makememctx()".
      
      This patch omits such redundant "savecommitmessage()" invocation in
      "tryimportone()".
      
      "tryimportone()" uses one of "commiteditor" or "commitforceeditor" as
      "editor" argument, and this causes saving commit message always.
      244b177a152e
    • Katsunori FUJIWARA's avatar
      amend: use "editor" argument for "memctx.__init__" to save commit message · 1a833fcf5a14
      Katsunori FUJIWARA authored
      This patch uses "editor" argument of "memctx.__init__" to save commit
      message, instead of explicit editor invocation and saving commit
      message by "localrepository.savecommitmessage()".
      
      By passing one of "commiteditor" or "commitforceeditor" as "editor",
      "memctx.__init__" saves commit message, even when editor invocation is
      not needed.
      1a833fcf5a14
    • Katsunori FUJIWARA's avatar
      histedit: pass "editor" argument to "memctx.__init__()" for "collapse" command · 19d98da5c018
      Katsunori FUJIWARA authored
      The preceding patch causes that "memctx.__init__()" with "editor"
      argument invokes editor and saves edited commit message into
      ".hg/last-message.txt".
      
      This patch passes "editor" argument to "memctx.__init__()" instead of
      explicit invocations of "commitforceeditor()" and
      "savecommitmessage()" for "collapse" command.
      19d98da5c018
    • Katsunori FUJIWARA's avatar
      context: move editor invocation from "makememctx()" to "memctx.__init__()" · 25d6fdc0294a
      Katsunori FUJIWARA authored
      This patch introduces "editor" argument to "memctx.__init__()", and
      moves editor invocation from "makememctx()" to "memctx.__init__()", to
      centralize editor invocation into "memctx" object creation.
      
      This relocation is needed, because "makememctx()" requires the "store"
      object providing "getfile()" to create "memfilectx" object, and this
      prevents some code paths from using "makememctx()" instead of
      "memctx.__init__()".
      
      This patch also invokes "localrepository.savecommitmessage()", when
      "editor" is specified explicitly, to centralize saving commit message
      into "memctx" object creation: passing "cmdutil.commiteditor" as
      "editor" can achieve both suppressing editor invocation and saving
      into ".hg/last-message.txt" for non empty commit messages.
      25d6fdc0294a
    • Katsunori FUJIWARA's avatar
      localrepo: add "editor" argument to "tag()" · 0054a77f49df
      Katsunori FUJIWARA authored
      Before this patch, "localrepository.tag()" doesn't take "editor"
      argument, and this prevents callers from passing "editor" argument to
      "localrepository.commit()" invoked internally.
      
      This patch adds "editor" argument to "localrepository.tag()" (and
      "_tag()", too), and makes "commands.tag()" invoke it with "editor"
      argument.
      
      This patch also omits explicit "localrepository.savecommitmesssage()"
      invocation, because "localrepository.commit()" will invoke specified
      "editor" and save edited commit message into ".hg/last-message.txt"
      automatically.
      0054a77f49df
    • Katsunori FUJIWARA's avatar
      qrefresh: use "editor" argument of "commit()" instead of explicit "ui.edit()" · 49148d7868df
      Katsunori FUJIWARA authored
      Before this patch, "hg qrefresh" and "hg qfold" invoke "ui.edit()"
      explicitly to get commit message edited manually.
      
      This requires explicit "localrepository.savecommitmessage()"
      invocation to save edited commit message into ".hg/last-message.txt",
      because unexpected exception raising may abort command execution
      before saving it in "localrepository.commit()".
      
      This patch uses "editor" argument of "localrepository.commit()"
      instead of explicit "ui.edit()" invocation for "hg qnew" and "hg qfold"
      
      "localrepository.commit()" will invoke "desceditor()" function newly
      added by this patch, and save edited commit message into
      ".hg/last-message.txt" automatically.
      
      This patch passes not "editor" but "desceditor" to "commit()", because
      "hg qnew" and "hg qfold" require editor function to return edited
      message (and invoke "patchheader.setmessage()" with it) if not empty,
      or default message otherwise.
      
      This patch also avoids "not q.applied" check at "hg qrefresh --edit",
      because it is also checked in "queue.refresh()", and it is not needed
      to get commit message from patch header before "queue.refresh()".
      49148d7868df
    • Katsunori FUJIWARA's avatar
      qrefresh: relocate message/patch-header handling to delay message determination · 51069bf6366b
      Katsunori FUJIWARA authored
      Before this patch, commit message for refreshed MQ changeset is
      determined, and written into refreshed patch file before
      "localrepository.commit()" invocation.
      
      This makes refactoring to use "editor" argument of "commit()" instead
      of explicit "ui.edit()" invocation in succeeding patch difficult.
      
      This patch relocates message/patch-header handling to delay message
      determination.
      51069bf6366b
    • Katsunori FUJIWARA's avatar
      qnew: use "editor" argument of "commit()" instead of explicit "ui.edit()" · b9a16ed5acec
      Katsunori FUJIWARA authored
      Before this patch, "hg qnew" invokes "ui.edit()" explicitly to get
      commit message edited manually.
      
      This requires explicit "localrepository.savecommitmessage()"
      invocation to save edited commit message into ".hg/last-message.txt",
      because unexpected exception raising may abort command execution
      before saving it in "localrepository.commit()".
      
      This patch uses "editor" argument of "localrepository.commit()"
      instead of explicit "ui.edit()" invocation for "hg qnew".
      
      "localrepository.commit()" will invoke "desceditor()" function newly
      added by this patch, and save edited commit message into
      ".hg/last-message.txt" automatically.
      
      This patch passes not "editor" but "desceditor" to "commit()", because
      "hg qnew" requires editor function to return edited message if not
      empty, or default message otherwise.
      
      This patch applies "rstrip()" on "defaultmsg" at comparison between
      "nctx.description()" and "defaultmsg", because the former should be
      stripped by "changelog.stripdesc()" and the latter may have tail white
      spaces inherited from "patchfn".
      b9a16ed5acec
    • Katsunori FUJIWARA's avatar
      histedit: use "editor" argument of "commit()" instead of explicit "ui.edit()" · 213fd1a99cd9
      Katsunori FUJIWARA authored
      Before this patch, "message" action of "hg histedit" uses "ui.edit()"
      explicitly to get commit message edited manually.
      
      This requires explicit "localrepository.savecommitmessage()"
      invocation to save edited commit message into ".hg/last-message.txt",
      because unexpected exception raising may abort command execution
      before saving it in "localrepository.commit()".
      
      This patch uses "editor" argument of "localrepository.commit()"
      instead of explicit "ui.edit()" invocation for "message" action of "hg
      histedit"
      
      "localrepository.commit()" will invoke "editor()" function newly added
      in this patch, and save edited commit message into ".hg/last-message.txt"
      automatically.
      213fd1a99cd9
  4. Apr 29, 2014
    • Yuya Nishihara's avatar
      test-pyflakes: detect undefined name error · 0768cda8b579
      Yuya Nishihara authored
      It should be able to catch the following mistakes at 2606e7f227f6:
      
          mercurial/exchange.py:590: undefined name 'UnknownPartError'
          mercurial/match.py:346: undefined name 'pat'
          mercurial/win32.py:365: undefined name '_ERROR_NO_MORE_FILES'
          tests/killdaemons.py:46: undefined name 'check'
      0768cda8b579
  5. May 02, 2014
  6. May 06, 2014
  7. May 05, 2014
    • Thomas Arendsen Hein's avatar
      setup.py, make: avoid problems with outdated, existing hgext/__index__.py* · 54d7657d7d1e
      Thomas Arendsen Hein authored
      "make clean" already removed __index__.py[cdo], but not the __index__.py
      (automatically generated by "python setup.py build_hgextindex").
      
      "setup.py build_hgextindex" did not generate a new index if file
      __index__.py[cdo] already existed, because if __index__.py was removed,
      the compiled file containing the old information was imported and used.
      Generate an empty file (with a new timestamp to generate a new .py[cdo])
      instead and make mercurial.extensions ignore the unset docs attribute.
      
      One of the problems was a failed test-help.t, to reproduce:
      
      $ rm hgext/__index__.py*
      $ echo 'docs = {"mq": "dummy"}' > hgext/__index__.py
      $ make test-help.t
      
      With this a "make clean" or "python setup.py build_hgextindex" helps.
      54d7657d7d1e
  8. May 02, 2014
  9. May 03, 2014
    • Mads Kiilerich's avatar
      color: don't fail on error messages when no curses (issue4237) · 75aaae8ad660
      Mads Kiilerich authored
      The error only occured when Python didn't have curses - such as on Windows and
      when Python was built without curses support.
      
      No curses can also be emulated by (re)moving .../lib/python2.7/curses/ from the
      Python installation.
      
      It is left as an exercise to figure out exactly what changed in Mercurial that
      triggered this error.
      75aaae8ad660
    • Steve Borho's avatar
      win32: backout 1a9ebc83a74c · 4898c37e03c0
      Steve Borho authored
      This change conflicted with TortoiseHg's use of QFileSystemWatcher. Files which
      were being monitored (for file-system events) were unable to be reliably updated
      using util.atomictempfile.  Often the update would error out in the middle of
      the process leaving neither the old or the new file in place.
      
      My guess is that _kernel32.CreateFileA() is triggering an exception that is
      not handled correctly within unlink()
      4898c37e03c0
  10. May 05, 2014
  11. May 02, 2014
  12. May 01, 2014
Loading