Skip to content
Snippets Groups Projects
  1. Feb 23, 2023
    • Pierre-Yves David's avatar
      transaction: use the standard transaction mechanism to backup branch · 11e6eee4b063
      Pierre-Yves David authored
      Branch is a bit special :
      - It currently does not collaborate with the transaction (or any scoping) for
        writing (this is bad)
      - It can change without the lock being taken (it is protected by `wlock`)
      
      So we rely on the same mechanism as for the backup of the other dirstate file:
      - we only do a backup if we hold the wlock
      - we force a backup though the transaction
      
      
      Since "branch" write does not collaborate with the transaction, we cannot back
      it up "at the last minute" as we do for the dirstate. We have to back it up
      "upfront". Since we have a backup, the transaction is no longer doing its
      "quick_abort" and get noisy. Which is quite annoying. To work around this, and
      to avoid jumping in yet-another-rabbit-hole of "getting branch written
      properly", I am doing horrible things to the transaction in the meantime.
      We should be able to get this code go away during the next cycle.
      
      In the meantime, I prefer to take this small stop so that we stop abusing the
      "journal" and "undo" mechanism instead of the proper backup mechanism of the
      transaction.
      
      
      Also note that this change regress the warning message for the legacy fallback
      introduced in 2008 when issue902 got fixed in dd5a501cb97f (Mercurial 1.0).
      
      I feel like this is fine as issue 902 remains fixed, and this would only affect
      people deploying a mix of 15 year old Mercurial and modern mercurial, and using
      branch and rollback extensively.
      11e6eee4b063
    • Pierre-Yves David's avatar
      transaction: no longer explicitly cache bookmarks · 8fb391363aad
      Pierre-Yves David authored
      The transaction file generation is already dealing with the backup for this.
      So, no need to duplicate such backup.
      8fb391363aad
  2. Feb 22, 2023
  3. Feb 23, 2023
  4. Feb 22, 2023
  5. Feb 23, 2023
  6. Feb 24, 2023
  7. Feb 23, 2023
    • Arseniy Alekseyev's avatar
      convert: use a priority queue for sorting commits, to make sorting faster · 02fe65f74be5
      Arseniy Alekseyev authored
      To achieve this, we turn commit sorters into classes so they can
      encapsulate state.
      
      This reduces the sorting time from ~30s to ~10s on a 500k-commit
      prefix of a repo I tried to convert. (and probably reduces the time
      to sort the whole repo from many tens of minutes to minutes, but I
      didn't try that again)
      
      The date caching gets removed because priority queue already
      caches the key.
      02fe65f74be5
  8. Feb 21, 2023
    • Matt Harbison's avatar
      typing: add the return type hint to pycompat.rangelist() · 829aa604d71a
      Matt Harbison authored
      Not bothering with the args, because there are a few overloads and only 2
      callers in the codebase, one of which is a test.
      829aa604d71a
    • Matt Harbison's avatar
      typing: add type hints to pycompat.maplist() · 0ab92dabea6e
      Matt Harbison authored
      The typeshed hints define 5 overloads with an increasing number of parameters on
      the passed function, and then a catchall that ignores the argument list on the
      passed function and allows an `*iterators` arg.  All of our uses are fulfilled
      by the 1 function + 1 iterable overload, but add the second overload as a hint
      in case it's needed in the future.
      0ab92dabea6e
  9. Feb 22, 2023
  10. Feb 17, 2023
  11. Feb 16, 2023
  12. Feb 20, 2023
  13. Feb 21, 2023
  14. Feb 19, 2023
  15. Feb 22, 2023
Loading