Skip to content
Snippets Groups Projects
  1. Dec 03, 2017
  2. Dec 04, 2017
  3. Nov 25, 2017
  4. Nov 23, 2017
  5. Nov 25, 2017
    • Yuya Nishihara's avatar
      dispatch: alias --repo to --repository while parsing early options · 4edd2202f7d7
      Yuya Nishihara authored
      This prepares for replacing old _early*opt() functions. My initial attempt
      was to extend options table to support 'repository|repo' syntax. It worked,
      but seemed too invasive. So I decided to add an optional argument to
      fancyopts() instead.
      
      This also changes the nevernegate dict to be keyed by a canonical_name,
      not by an option-name for clarity.
      4edd2202f7d7
  6. Dec 04, 2017
  7. Dec 01, 2017
    • Anton Shestakov's avatar
      hgweb: only include graph-related data in jsdata variable on /graph pages (BC) · d61f2a3d5e53
      Anton Shestakov authored
      Historically, client-side graph code was not only rendering the graph itself,
      but it was also adding all of the changeset information to the page as well.
      It meant that JavaScript code needed to construct valid HTML as a string
      (although proper escaping was done server-side). It wasn't too clunky, even
      though it meant that a lot of server-side things were duplicated client-side
      for no good reason, but the worst thing about it was the data format it used.
      It was somewhat future-proof, but not human-friendly, because it was just a
      tuple: it was possible to append things to it (as was done in e.g.
      270f57d35525), but you'd then have to remember the indices and reading the
      resulting JS code wasn't easy, because cur[8] is not descriptive at all.
      
      So what would need to happen for graph to have more features, such as more
      changeset information or a different vertex style (branch-closing, obsolete)?
      First you'd need to take some property, process it (e.g. escape and pass
      through templatefilters function, and mind the encoding too), append it to
      jsdata and remember its index, then go add nearly identical JavaScript code to
      4 different hgweb themes that use jsdata to render HTML, and finally try and
      forget how brittle it all felt. Oh yeah, and the indices go to double digits if
      we add 2 more items, say phase and obsolescence, and there are more to come.
      Rendering vertex in a different style would need another property (say,
      character "o", "_", or "x"), except if you want to be backwards-compatible, it
      would need to go after tags and bookmarks, and that just doesn't feel right.
      
      So here I'm trying to fix both the duplication of code and the data format:
      
      - changesets will be rendered by hgweb templates the same way as changelog and
        other such pages, so jsdata won't need any information that's not needed for
        rendering the graph itself
      
      - jsdata will be a dict, or an Object in JS, which is a lot nicer to humans and
        is a lot more future-proof in the long run, because it doesn't use numeric
        indices
      
      What about hgweb themes? Obviously, this will break all hgweb themes that
      render graph in JavaScript, including 3rd-party custom ones. But this will also
      reduce the size of client-side code and make it more uniform, so that it can be
      shared across hgweb themes, further reducing its size. The next few patches
      demonstrate that it's not hard to adapt a theme to these changes. And in a
      later series, I'm planning to move duplicate JS code from */graph.tmpl to
      mercurial.js and leave only 4 lines of code embedded in those <script>
      elements, and even that would be just to allow redefining graph.vertex
      function. So adapting a custom 3rd-party theme to these changes would mean:
      
      - creating or copying graphnode.tmpl and adding it to the map file (if a theme
        doesn't already use __base__)
      
      - modifying one line in graph.tmpl and simply removing the bigger part of
        JavaScript code from there
      
      Making these changes in this patch and not updating every hgweb theme that uses
      jsdata at the same time is a bit of a cheat to make this series more
      manageable: /graph pages that use jsdata are broken by this patch, but since
      there are no tests that would detect this, bisect works fine; and themes are
      updated separately, in the next 4 patches of this series to ease reviewing.
      d61f2a3d5e53
    • Anton Shestakov's avatar
      hgweb: adopt child nodes in ajaxScrollInit on /graph pages too · fcc96cf0983d
      Anton Shestakov authored
      ajaxScrollInit is a function that loads more elements (e.g. changelog entries)
      when browser window is scrolled down to the bottom of the page. It basically
      fetches the next page from the server as HTML, finds container element in that
      document and "adopts" (essentially, moves) all its child nodes to the container
      in the current document.
      
      Currently, hgweb doesn't render any changesets on /graph page (everything is
      done in JavaScript), so there are no children to adopt. But there will be soon,
      so let's create a reusable function that does it.
      
      Hardcoding #graphnodes selector is suboptimal, but graph code already does this
      in two other places.
      fcc96cf0983d
  8. Nov 27, 2017
  9. Nov 17, 2017
  10. Dec 02, 2017
  11. Dec 04, 2017
  12. Nov 30, 2017
  13. Dec 04, 2017
  14. Dec 02, 2017
  15. Nov 29, 2017
  16. Dec 01, 2017
    • James May's avatar
      archive: pass thru mtime for directory archives, like other archive types do · 760fef6aca74
      James May authored
      Without this files in the output archive directory have their mtimes set to
      whatever time they were written their.  This is in this inconsistent with
      the other archivers, eg. zip, which use exactly the same time for all files.
      
      Works on my machine (Windows), but I don't have a *nix box available to run
      anything more thorough, unfortunately.
      760fef6aca74
    • Anton Shestakov's avatar
      hgweb: remove negative top from .info line in graph · ec71518acd4a
      Anton Shestakov authored
      "top: -Xpx" shifts a block up by X pixels, which can be used to visually
      compress two lines of text to have less space between them, in this case it's
      used for the changesets on /graph page. But not only it's not needed there
      (both lines fit fine into their allowed vertical space), but it would also look
      better (not as crammed, more vertically centered) without these negative
      values.
      
      "position: relative" is needed solely for the "top" property to have effect on
      the element, no children of the .info element rely on it, so let's remove it as
      well.
      ec71518acd4a
  17. Dec 02, 2017
  18. Dec 01, 2017
  19. Dec 02, 2017
  20. Dec 01, 2017
Loading