Skip to content
Snippets Groups Projects
  1. Apr 21, 2020
    • Pierre-Yves David's avatar
      copies-rust: leverage the immutability for efficient update · 214b9bddd46b
      Pierre-Yves David authored
      The immutable OrdMap has a diff function. That function yield items for each
      difference (missing in minor, missing in major or present in both, but
      different). We reorganise the manifest merging code to use this new function.
      We gather the data we would need to inject into the `minor` or `major` dict and
      eventually update one of them. The semantic of the merge itself is kept as is.
      
      Why are we doing this? Last year we contributed a patch that makes a common
      ancestors, that diff function quickly detect some of the identical subsection
      when comparing two OrdMap cloned from the ancestors (because they point to the
      very same node in memory).
      
      As a result:
      
      - That diff function is very fast in most of our cases,
      - It is important to minimise the amount of unnecessary changes we do in theses
        Map, to maximize the "common" part. This is why we gather update for both and
        update the one with the smaller update.
      
      In practice, this yield a massive speed up on all our slow cases. Some example
      below.
      
      
      Repo            Cases                                 Source-Rev   Dest-Rev         Old-Time      New-Time     Difference   Factor
      ------------------------------------------------------------------------------------------------------------------------------------
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :  33.527067 s,   2.780174 s, -30.746893 s, × 0.0829
      netbeans        x0000_revs_xx000_added_x000_copies    588c2d1ced70 1aad62e59ddd : killed(>120),   1.231869 s
      mozilla-central x00000_revs_x0000_added_x0000_copies  6832ae71433c 4c222a1d9a00 : killed(>120),   3.478747 s
      mozilla-try     x0000_revs_xx000_added_x000_copies    89294cd501d9 7ccb2fc7ccb5 :  83.508590 s,   9.843481 s, -73.665109 s, × 0.1179
      mozilla-try     x0000_revs_x0000_added_x0000_copies   e928c65095ed e951f4ad123a :  55.079813 s,   1.465128 s, -53.614685 s, × 0.0266
      
      The performance compared to the Python code are now comparable (worst case are a
      score percent slower)" You an check the full table below for details.
      
      The big new is that, with this change, we are now faster filelog in most case, .
      Below is an highlight of some pretty nice win:
      
      Repo            Case                                  Source-Rev   Dest-Rev         filelog     sidedata      Difference       Factor
      ---------------------------------------------------------------------------------------------------------------------------------------
      pypy            x0000_revs_xx000_added_x000_copies    08ea3258278e d9fa043f30c0 :  1.354211 s, 0.252125 s, -1.102086 s, × 0.186179
      netbeans        x000_revs_x000_added_x000_copies      ff453e9fee32 411350406ec2 :  0.939593 s, 0.112534 s, -0.827059 s, × 0.119769
      netbeans        x0000_revs_xx000_added_x000_copies    588c2d1ced70 1aad62e59ddd :  3.824967 s, 1.231869 s, -2.593098 s, × 0.322060
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :  1.142414 s, 0.102184 s, -1.040230 s, × 0.089446
      mozilla-central x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :  6.667504 s, 0.046220 s, -6.621284 s, × 0.006932
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :  3.267274 s, 0.315271 s, -2.952003 s, × 0.096494
      mozilla-central x00000_revs_x0000_added_x0000_copies  6832ae71433c 4c222a1d9a00 : 16.038104 s, 3.478747 s, -12.559357 s, × 0.216905
      mozilla-central x00000_revs_x00000_added_x000_copies  76caed42cf7c 1daa622bbe42 : 20.639928 s, 4.766435 s, -15.873493 s, × 0.230933
      
      They they are a handful of slower case where we perform less well. A good Share
      of them are really pathological "service" merge in mozilla-try, but not all of
      them.
      
      Repo            Case                                  Source-Rev   Dest-Rev         filelog     sidedata      Difference       Factor
      ---------------------------------------------------------------------------------------------------------------------------------------
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :  0.001055 s, 2.780174 s, +2.779119 s, × 2635.236019
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 : 0.088715 s, 0.435381 s, +0.346666 s, × 4.907637
      mozilla-try     x0000_revs_x_added_x_copies           9fe69ff0762d bcabf2a78927 : 0.080765 s, 0.415461 s, +0.334696 s, × 5.144072
      mozilla-try     x0000_revs_xx000_added_x000_copies    89294cd501d9 7ccb2fc7ccb5 : 7.598509 s, 9.843481 s, +2.244972 s, × 1.295449
      mozilla-try     x00000_revs_x_added_0_copies          6a320851d377 1ebb79acd503 : 0.092232 s, killed
      mozilla-try     x00000_revs_x_added_x_copies          5173c4b6f97c 95d83ee7242d : 0.093892 s, killed
      mozilla-try     x00000_revs_x000_added_x_copies       9126823d0e9c ca82787bb23c : 0.227503 s, killed
      mozilla-try     x00000_revs_x00000_added_x0000_copies 1b661134e2ca 1ae03d022d6d : 21.145391 s, killed
      mozilla-try     x00000_revs_x00000_added_x000_copies  9b2a99adc05e 8e29777b48e6 : 25.304164 s, killed
      
      
      Below are two different tables for full performance comparison
      - this changeset against the previous one (spoiler: it is much better)
      - this changeset against the python code  (spoiler: still slower, but it gets more comparable)
      - this changeset against the filelog code (spoiler: better in many case, but not all)
      
      Repo            Cases                                 Source-Rev   Dest-Rev         Old-Time      New-Time     Difference   Factor
      ------------------------------------------------------------------------------------------------------------------------------------
      mercurial       x_revs_x_added_0_copies               ad6b123de1c7 39cfcef4f463 :   0.000049 s,   0.000049 s,  +0.000000 s, × 1.0000
      mercurial       x_revs_x_added_x_copies               2b1c78674230 0c1d10351869 :   0.000179 s,   0.000182 s,  +0.000003 s, × 1.0168
      mercurial       x000_revs_x000_added_x_copies         81f8ff2a9bf2 dd3267698d84 :   0.006494 s,   0.005872 s,  -0.000622 s, × 0.9042
      pypy            x_revs_x_added_0_copies               aed021ee8ae8 099ed31b181b :   0.000339 s,   0.000229 s,  -0.000110 s, × 0.6755
      pypy            x_revs_x000_added_0_copies            4aa4e1f8e19a 359343b9ac0e :   0.000057 s,   0.000058 s,  +0.000001 s, × 1.0175
      pypy            x_revs_x_added_x_copies               ac52eb7bbbb0 72e022663155 :   0.000299 s,   0.000148 s,  -0.000151 s, × 0.4950
      pypy            x_revs_x00_added_x_copies             c3b14617fbd7 ace7255d9a26 :   0.001200 s,   0.001205 s,  +0.000005 s, × 1.0042
      pypy            x_revs_x000_added_x000_copies         df6f7a526b60 a83dc6a2d56f :   0.025120 s,   0.025662 s,  +0.000542 s, × 1.0216
      pypy            x000_revs_xx00_added_0_copies         89a76aede314 2f22446ff07e :   0.506921 s,   0.080113 s,  -0.426808 s, × 0.1580
      pypy            x000_revs_x000_added_x_copies         8a3b5bfd266e 2c68e87c3efe :   1.272060 s,   0.153030 s,  -1.119030 s, × 0.1203
      pypy            x000_revs_x000_added_x000_copies      89a76aede314 7b3dda341c84 :   0.690941 s,   0.098774 s,  -0.592167 s, × 0.1430
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :  33.527067 s,   2.780174 s, -30.746893 s, × 0.0829
      pypy            x0000_revs_xx000_added_0_copies       bf2c629d0071 4ffed77c095c :   0.021970 s,   0.022218 s,  +0.000248 s, × 1.0113
      pypy            x0000_revs_xx000_added_x000_copies    08ea3258278e d9fa043f30c0 :   1.772094 s,   0.252125 s,  -1.519969 s, × 0.1423
      netbeans        x_revs_x_added_0_copies               fb0955ffcbcd a01e9239f9e7 :   0.000185 s,   0.000186 s,  +0.000001 s, × 1.0054
      netbeans        x_revs_x000_added_0_copies            6f360122949f 20eb231cc7d0 :   0.000135 s,   0.000133 s,  -0.000002 s, × 0.9852
      netbeans        x_revs_x_added_x_copies               1ada3faf6fb6 5a39d12eecf4 :   0.000329 s,   0.000320 s,  -0.000009 s, × 0.9726
      netbeans        x_revs_x00_added_x_copies             35be93ba1e2c 9eec5e90c05f :   0.001343 s,   0.001336 s,  -0.000007 s, × 0.9948
      netbeans        x000_revs_xx00_added_0_copies         eac3045b4fdd 51d4ae7f1290 :   0.029396 s,   0.015573 s,  -0.013823 s, × 0.5298
      netbeans        x000_revs_x000_added_x_copies         e2063d266acd 6081d72689dc :   0.040210 s,   0.018667 s,  -0.021543 s, × 0.4642
      netbeans        x000_revs_x000_added_x000_copies      ff453e9fee32 411350406ec2 :   4.556794 s,   0.112534 s,  -4.444260 s, × 0.0247
      netbeans        x0000_revs_xx000_added_x000_copies    588c2d1ced70 1aad62e59ddd : killed      ,   1.231869 s
      mozilla-central x_revs_x_added_0_copies               3697f962bb7b 7015fcdd43a2 :   0.000199 s,   0.000197 s,  -0.000002 s, × 0.9899
      mozilla-central x_revs_x000_added_0_copies            dd390860c6c9 40d0c5bed75d :   0.000639 s,   0.000637 s,  -0.000002 s, × 0.9969
      mozilla-central x_revs_x_added_x_copies               8d198483ae3b 14207ffc2b2f :   0.000542 s,   0.000303 s,  -0.000239 s, × 0.5590
      mozilla-central x_revs_x00_added_x_copies             98cbc58cc6bc 446a150332c3 :   0.001685 s,   0.001663 s,  -0.000022 s, × 0.9869
      mozilla-central x_revs_x000_added_x000_copies         3c684b4b8f68 0a5e72d1b479 :   0.006954 s,   0.007008 s,  +0.000054 s, × 1.0078
      mozilla-central x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.132938 s,   0.127385 s,  -0.005553 s, × 0.9582
      mozilla-central x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.008683 s,   0.008740 s,  +0.000057 s, × 1.0066
      mozilla-central x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.005956 s,   0.005783 s,  -0.000173 s, × 0.9710
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :   0.963905 s,   0.102184 s,  -0.861721 s, × 0.1060
      mozilla-central x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.049239 s,   0.046220 s,  -0.003019 s, × 0.9387
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :   4.217003 s,   0.315271 s,  -3.901732 s, × 0.0748
      mozilla-central x00000_revs_x0000_added_x0000_copies  6832ae71433c 4c222a1d9a00 : killed      ,   3.478747 s
      mozilla-central x00000_revs_x00000_added_x000_copies  76caed42cf7c 1daa622bbe42 : killed      ,   4.766435 s
      mozilla-try     x_revs_x_added_0_copies               aaf6dde0deb8 9790f499805a :   0.001197 s,   0.001214 s,  +0.000017 s, × 1.0142
      mozilla-try     x_revs_x000_added_0_copies            d8d0222927b4 5bb8ce8c7450 :   0.001213 s,   0.001221 s,  +0.000008 s, × 1.0066
      mozilla-try     x_revs_x_added_x_copies               092fcca11bdb 936255a0384a :   0.000762 s,   0.000613 s,  -0.000149 s, × 0.8045
      mozilla-try     x_revs_x00_added_x_copies             b53d2fadbdb5 017afae788ec :   0.001909 s,   0.001904 s,  -0.000005 s, × 0.9974
      mozilla-try     x_revs_x000_added_x000_copies         20408ad61ce5 6f0ee96e21ad :   0.093021 s,   0.093000 s,  -0.000021 s, × 0.9998
      mozilla-try     x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.134536 s,   0.132194 s,  -0.002342 s, × 0.9826
      mozilla-try     x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.009071 s,   0.009069 s,  -0.000002 s, × 0.9998
      mozilla-try     x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.006206 s,   0.006169 s,  -0.000037 s, × 0.9940
      mozilla-try     x000_revs_x000_added_x000_copies      1346fd0130e4 4c65cbdabc1f :   1.150502 s,   0.115540 s,  -1.034962 s, × 0.1004
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 :   1.114864 s,   0.435381 s,  -0.679483 s, × 0.3905
      mozilla-try     x0000_revs_x_added_x_copies           9fe69ff0762d bcabf2a78927 :   1.042658 s,   0.415461 s,  -0.627197 s, × 0.3985
      mozilla-try     x0000_revs_xx000_added_x_copies       156f6e2674f2 4d0f2c178e66 :   0.447402 s,   0.155946 s,  -0.291456 s, × 0.3486
      mozilla-try     x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.051132 s,   0.048521 s,  -0.002611 s, × 0.9489
      mozilla-try     x0000_revs_xx000_added_x000_copies    89294cd501d9 7ccb2fc7ccb5 :  83.508590 s,   9.843481 s, -73.665109 s, × 0.1179
      mozilla-try     x0000_revs_x0000_added_x0000_copies   e928c65095ed e951f4ad123a :  55.079813 s,   1.465128 s, -53.614685 s, × 0.0266
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c :   1.442793 s,   1.374283 s,  -0.068510 s, × 0.9525
      mozilla-try     x00000_revs_x0000_added_x0000_copies  8d3fafa80d4b eb884023b810 : killed      ,   5.255158 s
      
      Repo            Cases                                 Source-Rev   Dest-Rev         Py-time       Rust-time    Difference   Factor
      ------------------------------------------------------------------------------------------------------------------------------------
      mercurial       x_revs_x_added_0_copies               ad6b123de1c7 39cfcef4f463 :   0.000044 s,   0.000049 s,  +0.000005 s, × 1.1136
      mercurial       x_revs_x_added_x_copies               2b1c78674230 0c1d10351869 :   0.000138 s,   0.000182 s,  +0.000044 s, × 1.3188
      mercurial       x000_revs_x000_added_x_copies         81f8ff2a9bf2 dd3267698d84 :   0.005052 s,   0.005872 s,  +0.000820 s, × 1.1623
      pypy            x_revs_x_added_0_copies               aed021ee8ae8 099ed31b181b :   0.000219 s,   0.000229 s,  +0.000010 s, × 1.0457
      pypy            x_revs_x000_added_0_copies            4aa4e1f8e19a 359343b9ac0e :   0.000055 s,   0.000058 s,  +0.000003 s, × 1.0545
      pypy            x_revs_x_added_x_copies               ac52eb7bbbb0 72e022663155 :   0.000128 s,   0.000148 s,  +0.000020 s, × 1.1562
      pypy            x_revs_x00_added_x_copies             c3b14617fbd7 ace7255d9a26 :   0.001089 s,   0.001205 s,  +0.000116 s, × 1.1065
      pypy            x_revs_x000_added_x000_copies         df6f7a526b60 a83dc6a2d56f :   0.017407 s,   0.025662 s,  +0.008255 s, × 1.4742
      pypy            x000_revs_xx00_added_0_copies         89a76aede314 2f22446ff07e :   0.094175 s,   0.080113 s,  -0.014062 s, × 0.8507
      pypy            x000_revs_x000_added_x_copies         8a3b5bfd266e 2c68e87c3efe :   0.238009 s,   0.153030 s,  -0.084979 s, × 0.6430
      pypy            x000_revs_x000_added_x000_copies      89a76aede314 7b3dda341c84 :   0.125876 s,   0.098774 s,  -0.027102 s, × 0.7847
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :   3.581556 s,   2.780174 s,  -0.801382 s, × 0.7762
      pypy            x0000_revs_xx000_added_0_copies       bf2c629d0071 4ffed77c095c :   0.016721 s,   0.022218 s,  +0.005497 s, × 1.3287
      pypy            x0000_revs_xx000_added_x000_copies    08ea3258278e d9fa043f30c0 :   0.242367 s,   0.252125 s,  +0.009758 s, × 1.0403
      netbeans        x_revs_x_added_0_copies               fb0955ffcbcd a01e9239f9e7 :   0.000165 s,   0.000186 s,  +0.000021 s, × 1.1273
      netbeans        x_revs_x000_added_0_copies            6f360122949f 20eb231cc7d0 :   0.000114 s,   0.000133 s,  +0.000019 s, × 1.1667
      netbeans        x_revs_x_added_x_copies               1ada3faf6fb6 5a39d12eecf4 :   0.000296 s,   0.000320 s,  +0.000024 s, × 1.0811
      netbeans        x_revs_x00_added_x_copies             35be93ba1e2c 9eec5e90c05f :   0.001124 s,   0.001336 s,  +0.000212 s, × 1.1886
      netbeans        x000_revs_xx00_added_0_copies         eac3045b4fdd 51d4ae7f1290 :   0.013060 s,   0.015573 s,  +0.002513 s, × 1.1924
      netbeans        x000_revs_x000_added_x_copies         e2063d266acd 6081d72689dc :   0.017112 s,   0.018667 s,  +0.001555 s, × 1.0909
      netbeans        x000_revs_x000_added_x000_copies      ff453e9fee32 411350406ec2 :   0.660350 s,   0.112534 s,  -0.547816 s, × 0.1704
      netbeans        x0000_revs_xx000_added_x000_copies    588c2d1ced70 1aad62e59ddd :  10.032499 s,   1.231869 s,  -8.800630 s, × 0.1228
      mozilla-central x_revs_x_added_0_copies               3697f962bb7b 7015fcdd43a2 :   0.000189 s,   0.000197 s,  +0.000008 s, × 1.0423
      mozilla-central x_revs_x000_added_0_copies            dd390860c6c9 40d0c5bed75d :   0.000462 s,   0.000637 s,  +0.000175 s, × 1.3788
      mozilla-central x_revs_x_added_x_copies               8d198483ae3b 14207ffc2b2f :   0.000270 s,   0.000303 s,  +0.000033 s, × 1.1222
      mozilla-central x_revs_x00_added_x_copies             98cbc58cc6bc 446a150332c3 :   0.001474 s,   0.001663 s,  +0.000189 s, × 1.1282
      mozilla-central x_revs_x000_added_x000_copies         3c684b4b8f68 0a5e72d1b479 :   0.004806 s,   0.007008 s,  +0.002202 s, × 1.4582
      mozilla-central x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.085150 s,   0.127385 s,  +0.042235 s, × 1.4960
      mozilla-central x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.007064 s,   0.008740 s,  +0.001676 s, × 1.2373
      mozilla-central x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.004741 s,   0.005783 s,  +0.001042 s, × 1.2198
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :   0.190133 s,   0.102184 s,  -0.087949 s, × 0.5374
      mozilla-central x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.035651 s,   0.046220 s,  +0.010569 s, × 1.2965
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :   0.440694 s,   0.315271 s,  -0.125423 s, × 0.7154
      mozilla-central x00000_revs_x0000_added_x0000_copies  6832ae71433c 4c222a1d9a00 :  18.454163 s,   3.478747 s, -14.975416 s, × 0.1885
      mozilla-central x00000_revs_x00000_added_x000_copies  76caed42cf7c 1daa622bbe42 :  31.562719 s,   4.766435 s, -26.796284 s, × 0.1510
      mozilla-try     x_revs_x_added_0_copies               aaf6dde0deb8 9790f499805a :   0.001189 s,   0.001214 s,  +0.000025 s, × 1.0210
      mozilla-try     x_revs_x000_added_0_copies            d8d0222927b4 5bb8ce8c7450 :   0.001204 s,   0.001221 s,  +0.000017 s, × 1.0141
      mozilla-try     x_revs_x_added_x_copies               092fcca11bdb 936255a0384a :   0.000586 s,   0.000613 s,  +0.000027 s, × 1.0461
      mozilla-try     x_revs_x00_added_x_copies             b53d2fadbdb5 017afae788ec :   0.001845 s,   0.001904 s,  +0.000059 s, × 1.0320
      mozilla-try     x_revs_x000_added_x000_copies         20408ad61ce5 6f0ee96e21ad :   0.063822 s,   0.093000 s,  +0.029178 s, × 1.4572
      mozilla-try     x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.088038 s,   0.132194 s,  +0.044156 s, × 1.5016
      mozilla-try     x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.007389 s,   0.009069 s,  +0.001680 s, × 1.2274
      mozilla-try     x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.004868 s,   0.006169 s,  +0.001301 s, × 1.2673
      mozilla-try     x000_revs_x000_added_x000_copies      1346fd0130e4 4c65cbdabc1f :   0.222450 s,   0.115540 s,  -0.106910 s, × 0.5194
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 :   0.370675 s,   0.435381 s,  +0.064706 s, × 1.1746
      mozilla-try     x0000_revs_x_added_x_copies           9fe69ff0762d bcabf2a78927 :   0.358020 s,   0.415461 s,  +0.057441 s, × 1.1604
      mozilla-try     x0000_revs_xx000_added_x_copies       156f6e2674f2 4d0f2c178e66 :   0.145235 s,   0.155946 s,  +0.010711 s, × 1.0737
      mozilla-try     x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.037606 s,   0.048521 s,  +0.010915 s, × 1.2902
      mozilla-try     x0000_revs_xx000_added_x000_copies    89294cd501d9 7ccb2fc7ccb5 :   7.382439 s,   9.843481 s,  +2.461042 s, × 1.3334
      mozilla-try     x0000_revs_x0000_added_x0000_copies   e928c65095ed e951f4ad123a :   7.273506 s,   1.465128 s,  -5.808378 s, × 0.2014
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c :   1.074593 s,   1.374283 s,  +0.299690 s, × 1.2789
      mozilla-try     x00000_revs_x0000_added_x0000_copies  8d3fafa80d4b eb884023b810 :  27.746195 s,   5.255158 s, -22.491037 s, × 0.1894
      
      Repo            Case                                  Source-Rev   Dest-Rev         filelog     sidedata      Difference       Factor
      ---------------------------------------------------------------------------------------------------------------------------------------
      mercurial       x_revs_x_added_0_copies               ad6b123de1c7 39cfcef4f463 :  0.000906 s, 0.000049 s, -0.000857 s, × 0.054084
      mercurial       x_revs_x_added_x_copies               2b1c78674230 0c1d10351869 :  0.001832 s, 0.000182 s, -0.001650 s, × 0.099345
      mercurial       x000_revs_x000_added_x_copies         81f8ff2a9bf2 dd3267698d84 :  0.018101 s, 0.005872 s, -0.012229 s, × 0.324402
      pypy            x_revs_x_added_0_copies               aed021ee8ae8 099ed31b181b :  0.001508 s, 0.000229 s, -0.001279 s, × 0.151857
      pypy            x_revs_x000_added_0_copies            4aa4e1f8e19a 359343b9ac0e :  0.207438 s, 0.000058 s, -0.207380 s, × 0.000280
      pypy            x_revs_x_added_x_copies               ac52eb7bbbb0 72e022663155 :  0.016956 s, 0.000148 s, -0.016808 s, × 0.008728
      pypy            x_revs_x00_added_x_copies             c3b14617fbd7 ace7255d9a26 :  0.019129 s, 0.001205 s, -0.017924 s, × 0.062993
      pypy            x_revs_x000_added_x000_copies         df6f7a526b60 a83dc6a2d56f :  0.772050 s, 0.025662 s, -0.746388 s, × 0.033239
      pypy            x000_revs_xx00_added_0_copies         89a76aede314 2f22446ff07e :  1.181775 s, 0.080113 s, -1.101662 s, × 0.067790
      pypy            x000_revs_x000_added_x_copies         8a3b5bfd266e 2c68e87c3efe :  1.255717 s, 0.153030 s, -1.102687 s, × 0.121867
      pypy            x000_revs_x000_added_x000_copies      89a76aede314 7b3dda341c84 :  1.628132 s, 0.098774 s, -1.529358 s, × 0.060667
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :  0.001055 s, 2.780174 s, +2.779119 s, × 2635.236019
      pypy            x0000_revs_xx000_added_0_copies       bf2c629d0071 4ffed77c095c :  1.056756 s, 0.022218 s, -1.034538 s, × 0.021025
      pypy            x0000_revs_xx000_added_x000_copies    08ea3258278e d9fa043f30c0 :  1.354211 s, 0.252125 s, -1.102086 s, × 0.186179
      netbeans        x_revs_x_added_0_copies               fb0955ffcbcd a01e9239f9e7 :  0.027759 s, 0.000186 s, -0.027573 s, × 0.006701
      netbeans        x_revs_x000_added_0_copies            6f360122949f 20eb231cc7d0 :  0.133382 s, 0.000133 s, -0.133249 s, × 0.000997
      netbeans        x_revs_x_added_x_copies               1ada3faf6fb6 5a39d12eecf4 :  0.025353 s, 0.000320 s, -0.025033 s, × 0.012622
      netbeans        x_revs_x00_added_x_copies             35be93ba1e2c 9eec5e90c05f :  0.052939 s, 0.001336 s, -0.051603 s, × 0.025237
      netbeans        x000_revs_xx00_added_0_copies         eac3045b4fdd 51d4ae7f1290 :  0.037532 s, 0.015573 s, -0.021959 s, × 0.414926
      netbeans        x000_revs_x000_added_x_copies         e2063d266acd 6081d72689dc :  0.195401 s, 0.018667 s, -0.176734 s, × 0.095532
      netbeans        x000_revs_x000_added_x000_copies      ff453e9fee32 411350406ec2 :  0.939593 s, 0.112534 s, -0.827059 s, × 0.119769
      netbeans        x0000_revs_xx000_added_x000_copies    588c2d1ced70 1aad62e59ddd :  3.824967 s, 1.231869 s, -2.593098 s, × 0.322060
      mozilla-central x_revs_x_added_0_copies               3697f962bb7b 7015fcdd43a2 :  0.024626 s, 0.000197 s, -0.024429 s, × 0.008000
      mozilla-central x_revs_x000_added_0_copies            dd390860c6c9 40d0c5bed75d :  0.141098 s, 0.000637 s, -0.140461 s, × 0.004515
      mozilla-central x_revs_x_added_x_copies               8d198483ae3b 14207ffc2b2f :  0.025973 s, 0.000303 s, -0.025670 s, × 0.011666
      mozilla-central x_revs_x00_added_x_copies             98cbc58cc6bc 446a150332c3 :  0.085098 s, 0.001663 s, -0.083435 s, × 0.019542
      mozilla-central x_revs_x000_added_x000_copies         3c684b4b8f68 0a5e72d1b479 :  0.196623 s, 0.007008 s, -0.189615 s, × 0.035642
      mozilla-central x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :  2.182911 s, 0.127385 s, -2.055526 s, × 0.058356
      mozilla-central x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :  0.088865 s, 0.008740 s, -0.080125 s, × 0.098351
      mozilla-central x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :  0.731211 s, 0.005783 s, -0.725428 s, × 0.007909
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :  1.142414 s, 0.102184 s, -1.040230 s, × 0.089446
      mozilla-central x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :  6.667504 s, 0.046220 s, -6.621284 s, × 0.006932
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :  3.267274 s, 0.315271 s, -2.952003 s, × 0.096494
      mozilla-central x00000_revs_x0000_added_x0000_copies  6832ae71433c 4c222a1d9a00 : 16.038104 s, 3.478747 s, -12.559357 s, × 0.216905
      mozilla-central x00000_revs_x00000_added_x000_copies  76caed42cf7c 1daa622bbe42 : 20.639928 s, 4.766435 s, -15.873493 s, × 0.230933
      mozilla-try     x_revs_x_added_0_copies               aaf6dde0deb8 9790f499805a : 0.080513 s, 0.001214 s, -0.079299 s, × 0.015078
      mozilla-try     x_revs_x000_added_0_copies            d8d0222927b4 5bb8ce8c7450 : 0.502965 s, 0.001221 s, -0.501744 s, × 0.002428
      mozilla-try     x_revs_x_added_x_copies               092fcca11bdb 936255a0384a : 0.021408 s, 0.000613 s, -0.020795 s, × 0.028634
      mozilla-try     x_revs_x00_added_x_copies             b53d2fadbdb5 017afae788ec : 0.228498 s, 0.001904 s, -0.226594 s, × 0.008333
      mozilla-try     x_revs_x000_added_x000_copies         20408ad61ce5 6f0ee96e21ad : 1.118490 s, 0.093000 s, -1.025490 s, × 0.083148
      mozilla-try     x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 : 2.188390 s, 0.132194 s, -2.056196 s, × 0.060407
      mozilla-try     x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e : 0.089755 s, 0.009069 s, -0.080686 s, × 0.101042
      mozilla-try     x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed : 0.750223 s, 0.006169 s, -0.744054 s, × 0.008223
      mozilla-try     x000_revs_x000_added_x000_copies      1346fd0130e4 4c65cbdabc1f : 1.189708 s, 0.115540 s, -1.074168 s, × 0.097116
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 : 0.088715 s, 0.435381 s, +0.346666 s, × 4.907637
      mozilla-try     x0000_revs_x_added_x_copies           9fe69ff0762d bcabf2a78927 : 0.080765 s, 0.415461 s, +0.334696 s, × 5.144072
      mozilla-try     x0000_revs_xx000_added_x_copies       156f6e2674f2 4d0f2c178e66 : 7.487310 s, 0.155946 s, -7.331364 s, × 0.020828
      mozilla-try     x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad : 6.676682 s, 0.048521 s, -6.628161 s, × 0.007267
      mozilla-try     x0000_revs_xx000_added_x000_copies    89294cd501d9 7ccb2fc7ccb5 : 7.598509 s, 9.843481 s, +2.244972 s, × 1.295449
      mozilla-try     x0000_revs_x0000_added_x0000_copies   e928c65095ed e951f4ad123a : 9.871850 s, 1.465128 s, -8.406722 s, × 0.148415
      mozilla-try     x00000_revs_x_added_0_copies          6a320851d377 1ebb79acd503 : 0.092232 s, killed
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c : 26.471560 s, 1.374283 s, -25.097277 s, × 0.051915
      mozilla-try     x00000_revs_x_added_x_copies          5173c4b6f97c 95d83ee7242d : 0.093892 s, killed
      mozilla-try     x00000_revs_x000_added_x_copies       9126823d0e9c ca82787bb23c : 0.227503 s, killed
      mozilla-try     x00000_revs_x0000_added_x0000_copies  8d3fafa80d4b eb884023b810 : 19.064699 s, 5.255158 s, -13.809541 s, × 0.275649
      mozilla-try     x00000_revs_x00000_added_x0000_copies 1b661134e2ca 1ae03d022d6d : 21.145391 s, killed
      mozilla-try     x00000_revs_x00000_added_x000_copies  9b2a99adc05e 8e29777b48e6 : 25.304164 s, killed
      214b9bddd46b
  2. Nov 02, 2020
  3. Apr 21, 2020
    • Pierre-Yves David's avatar
      copies-rust: use immutable "OrdMap" to store copies information · d6c501e28ff4
      Pierre-Yves David authored
      The large majority of time is currently spent coping and merging directories.
      the `IM` crate offer "immutable" Map, that use "copy on write" internally.  The
      new object use the same API as the standard HashMap.  So switching to it is
      trivial and it reduce copying cost significantly. More importantly, using
      immutable structure will unlock new possibility for a massive speed up of the
      "merging" part. This will came in a later changesets.
      
      Performance wise, we get very significant boost in the worst case. Below is some
      highlight of how we fare compared to the previous changeset.
      
      Repo            Cases                                 Source-Rev   Dest-Rev         Old-Time      New-Time     Difference   Factor
      ------------------------------------------------------------------------------------------------------------------------------------
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :  62.468362 s,  33.527067 s, -28.941295 s, × 0.5367
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :   3.619850 s,   0.963905 s,  -2.655945 s, × 0.2663
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :  11.926587 s,   4.217003 s,  -7.709584 s, × 0.3536
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 :  10.674920 s,   1.114864 s,  -9.560056 s, × 0.1044
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c :  19.647038 s,   1.442793 s, -18.204245 s, × 0.0734
      
      
      And we sometimes catch up with the performance of the python code as highlighted
      bellow
      
      Repo            Cases                                 Source-Rev   Dest-Rev         Py-time       Rust-time    Difference   Factor
      ------------------------------------------------------------------------------------------------------------------------------------
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c :   1.074593 s,   1.442793 s,  +0.368200 s, × 1.3426
      
      However, multiple case remains significantly slower, as highlighted below
      
      Repo            Cases                                 Source-Rev   Dest-Rev         Py-time       Rust-time    Difference   Factor
      ------------------------------------------------------------------------------------------------------------------------------------
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :   0.190133 s,   0.963905 s,  +0.773772 s, × 5.0696
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :   0.440694 s,   4.217003 s,  +3.776309 s, × 9.5690
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 :   0.370675 s,   1.114864 s,  +0.744189 s, × 3.0077
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :   3.581556 s,  33.527067 s, +29.945511 s, × 9.3610
      
      Below are two different tables for full performance comparison
      - this changeset against the previous one (spoiler: it is much better)
      - this changeset against the python code  (spoiler: still slower, but it gets more comparable)
      
      Repo            Cases                                 Source-Rev   Dest-Rev         Old-Time      New-Time     Difference   Factor
      ------------------------------------------------------------------------------------------------------------------------------------
      mercurial       x_revs_x_added_0_copies               ad6b123de1c7 39cfcef4f463 :   0.000046 s,   0.000049 s,  +0.000003 s, × 1.0652
      mercurial       x_revs_x_added_x_copies               2b1c78674230 0c1d10351869 :   0.000173 s,   0.000179 s,  +0.000006 s, × 1.0347
      mercurial       x000_revs_x000_added_x_copies         81f8ff2a9bf2 dd3267698d84 :   0.006303 s,   0.006494 s,  +0.000191 s, × 1.0303
      pypy            x_revs_x_added_0_copies               aed021ee8ae8 099ed31b181b :   0.000229 s,   0.000339 s,  +0.000110 s, × 1.4803
      pypy            x_revs_x000_added_0_copies            4aa4e1f8e19a 359343b9ac0e :   0.000056 s,   0.000057 s,  +0.000001 s, × 1.0179
      pypy            x_revs_x_added_x_copies               ac52eb7bbbb0 72e022663155 :   0.000143 s,   0.000299 s,  +0.000156 s, × 2.0909
      pypy            x_revs_x00_added_x_copies             c3b14617fbd7 ace7255d9a26 :   0.001166 s,   0.001200 s,  +0.000034 s, × 1.0292
      pypy            x_revs_x000_added_x000_copies         df6f7a526b60 a83dc6a2d56f :   0.022931 s,   0.025120 s,  +0.002189 s, × 1.0955
      pypy            x000_revs_xx00_added_0_copies         89a76aede314 2f22446ff07e :   0.852446 s,   0.506921 s,  -0.345525 s, × 0.5947
      pypy            x000_revs_x000_added_x_copies         8a3b5bfd266e 2c68e87c3efe :   2.221824 s,   1.272060 s,  -0.949764 s, × 0.5725
      pypy            x000_revs_x000_added_x000_copies      89a76aede314 7b3dda341c84 :   1.194162 s,   0.690941 s,  -0.503221 s, × 0.5786
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :  62.468362 s,  33.527067 s, -28.941295 s, × 0.5367
      pypy            x0000_revs_xx000_added_0_copies       bf2c629d0071 4ffed77c095c :   0.022116 s,   0.021970 s,  -0.000146 s, × 0.9934
      pypy            x0000_revs_xx000_added_x000_copies    08ea3258278e d9fa043f30c0 :   2.972788 s,   1.772094 s,  -1.200694 s, × 0.5961
      netbeans        x_revs_x_added_0_copies               fb0955ffcbcd a01e9239f9e7 :   0.000180 s,   0.000185 s,  +0.000005 s, × 1.0278
      netbeans        x_revs_x000_added_0_copies            6f360122949f 20eb231cc7d0 :   0.000123 s,   0.000135 s,  +0.000012 s, × 1.0976
      netbeans        x_revs_x_added_x_copies               1ada3faf6fb6 5a39d12eecf4 :   0.000315 s,   0.000329 s,  +0.000014 s, × 1.0444
      netbeans        x_revs_x00_added_x_copies             35be93ba1e2c 9eec5e90c05f :   0.001297 s,   0.001343 s,  +0.000046 s, × 1.0355
      netbeans        x000_revs_xx00_added_0_copies         eac3045b4fdd 51d4ae7f1290 :   0.024884 s,   0.029396 s,  +0.004512 s, × 1.1813
      netbeans        x000_revs_x000_added_x_copies         e2063d266acd 6081d72689dc :   0.032653 s,   0.040210 s,  +0.007557 s, × 1.2314
      netbeans        x000_revs_x000_added_x000_copies      ff453e9fee32 411350406ec2 :   4.230118 s,   4.556794 s,  +0.326676 s, × 1.0772
      mozilla-central x_revs_x_added_0_copies               3697f962bb7b 7015fcdd43a2 :   0.000197 s,   0.000199 s,  +0.000002 s, × 1.0102
      mozilla-central x_revs_x000_added_0_copies            dd390860c6c9 40d0c5bed75d :   0.000622 s,   0.000639 s,  +0.000017 s, × 1.0273
      mozilla-central x_revs_x_added_x_copies               8d198483ae3b 14207ffc2b2f :   0.000296 s,   0.000542 s,  +0.000246 s, × 1.8311
      mozilla-central x_revs_x00_added_x_copies             98cbc58cc6bc 446a150332c3 :   0.001626 s,   0.001685 s,  +0.000059 s, × 1.0363
      mozilla-central x_revs_x000_added_x000_copies         3c684b4b8f68 0a5e72d1b479 :   0.006218 s,   0.006954 s,  +0.000736 s, × 1.1184
      mozilla-central x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.132760 s,   0.132938 s,  +0.000178 s, × 1.0013
      mozilla-central x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.029001 s,   0.008683 s,  -0.020318 s, × 0.2994
      mozilla-central x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.005886 s,   0.005956 s,  +0.000070 s, × 1.0119
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :   3.619850 s,   0.963905 s,  -2.655945 s, × 0.2663
      mozilla-central x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.058678 s,   0.049239 s,  -0.009439 s, × 0.8391
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :  11.926587 s,   4.217003 s,  -7.709584 s, × 0.3536
      mozilla-try     x_revs_x_added_0_copies               aaf6dde0deb8 9790f499805a :   0.001204 s,   0.001197 s,  -0.000007 s, × 0.9942
      mozilla-try     x_revs_x000_added_0_copies            d8d0222927b4 5bb8ce8c7450 :   0.001217 s,   0.001213 s,  -0.000004 s, × 0.9967
      mozilla-try     x_revs_x_added_x_copies               092fcca11bdb 936255a0384a :   0.000605 s,   0.000762 s,  +0.000157 s, × 1.2595
      mozilla-try     x_revs_x00_added_x_copies             b53d2fadbdb5 017afae788ec :   0.001876 s,   0.001909 s,  +0.000033 s, × 1.0176
      mozilla-try     x_revs_x000_added_x000_copies         20408ad61ce5 6f0ee96e21ad :   0.078190 s,   0.093021 s,  +0.014831 s, × 1.1897
      mozilla-try     x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.135428 s,   0.134536 s,  -0.000892 s, × 0.9934
      mozilla-try     x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.029123 s,   0.009071 s,  -0.020052 s, × 0.3115
      mozilla-try     x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.006141 s,   0.006206 s,  +0.000065 s, × 1.0106
      mozilla-try     x000_revs_x000_added_x000_copies      1346fd0130e4 4c65cbdabc1f :   4.857827 s,   1.150502 s,  -3.707325 s, × 0.2368
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 :  10.674920 s,   1.114864 s,  -9.560056 s, × 0.1044
      mozilla-try     x0000_revs_x_added_x_copies           9fe69ff0762d bcabf2a78927 :   9.789462 s,   1.042658 s,  -8.746804 s, × 0.1065
      mozilla-try     x0000_revs_xx000_added_x_copies       156f6e2674f2 4d0f2c178e66 :   1.087890 s,   0.447402 s,  -0.640488 s, × 0.4113
      mozilla-try     x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.060556 s,   0.051132 s,  -0.009424 s, × 0.8444
      mozilla-try     x0000_revs_xx000_added_x000_copies    89294cd501d9 7ccb2fc7ccb5 : killed         ,  83.508590 s
      mozilla-try     x0000_revs_x0000_added_x0000_copies   e928c65095ed e951f4ad123a : killed         ,  55.079813 s
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c :  19.647038 s,   1.442793 s, -18.204245 s, × 0.0734
      
      
      
      
      Repo            Cases                                 Source-Rev   Dest-Rev         Py-time       Rust-time    Difference   Factor
      ------------------------------------------------------------------------------------------------------------------------------------
      mercurial       x_revs_x_added_0_copies               ad6b123de1c7 39cfcef4f463 :   0.000044 s,   0.000049 s,  +0.000005 s, × 1.1136
      mercurial       x_revs_x_added_x_copies               2b1c78674230 0c1d10351869 :   0.000138 s,   0.000179 s,  +0.000041 s, × 1.2971
      mercurial       x000_revs_x000_added_x_copies         81f8ff2a9bf2 dd3267698d84 :   0.005052 s,   0.006494 s,  +0.001442 s, × 1.2854
      pypy            x_revs_x_added_0_copies               aed021ee8ae8 099ed31b181b :   0.000219 s,   0.000339 s,  +0.000120 s, × 1.5479
      pypy            x_revs_x000_added_0_copies            4aa4e1f8e19a 359343b9ac0e :   0.000055 s,   0.000057 s,  +0.000002 s, × 1.0364
      pypy            x_revs_x_added_x_copies               ac52eb7bbbb0 72e022663155 :   0.000128 s,   0.000299 s,  +0.000171 s, × 2.3359
      pypy            x_revs_x00_added_x_copies             c3b14617fbd7 ace7255d9a26 :   0.001089 s,   0.001200 s,  +0.000111 s, × 1.1019
      pypy            x_revs_x000_added_x000_copies         df6f7a526b60 a83dc6a2d56f :   0.017407 s,   0.025120 s,  +0.007713 s, × 1.4431
      pypy            x000_revs_xx00_added_0_copies         89a76aede314 2f22446ff07e :   0.094175 s,   0.506921 s,  +0.412746 s, × 5.3828
      pypy            x000_revs_x000_added_x_copies         8a3b5bfd266e 2c68e87c3efe :   0.238009 s,   1.272060 s,  +1.034051 s, × 5.3446
      pypy            x000_revs_x000_added_x000_copies      89a76aede314 7b3dda341c84 :   0.125876 s,   0.690941 s,  +0.565065 s, × 5.4891
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :   3.581556 s,  33.527067 s, +29.945511 s, × 9.3610
      pypy            x0000_revs_xx000_added_0_copies       bf2c629d0071 4ffed77c095c :   0.016721 s,   0.021970 s,  +0.005249 s, × 1.3139
      pypy            x0000_revs_xx000_added_x000_copies    08ea3258278e d9fa043f30c0 :   0.242367 s,   1.772094 s,  +1.529727 s, × 7.3116
      netbeans        x_revs_x_added_0_copies               fb0955ffcbcd a01e9239f9e7 :   0.000165 s,   0.000185 s,  +0.000020 s, × 1.1212
      netbeans        x_revs_x000_added_0_copies            6f360122949f 20eb231cc7d0 :   0.000114 s,   0.000135 s,  +0.000021 s, × 1.1842
      netbeans        x_revs_x_added_x_copies               1ada3faf6fb6 5a39d12eecf4 :   0.000296 s,   0.000329 s,  +0.000033 s, × 1.1115
      netbeans        x_revs_x00_added_x_copies             35be93ba1e2c 9eec5e90c05f :   0.001124 s,   0.001343 s,  +0.000219 s, × 1.1948
      netbeans        x000_revs_xx00_added_0_copies         eac3045b4fdd 51d4ae7f1290 :   0.013060 s,   0.029396 s,  +0.016336 s, × 2.2508
      netbeans        x000_revs_x000_added_x_copies         e2063d266acd 6081d72689dc :   0.017112 s,   0.040210 s,  +0.023098 s, × 2.3498
      netbeans        x000_revs_x000_added_x000_copies      ff453e9fee32 411350406ec2 :   0.660350 s,   4.556794 s,  +3.896444 s, × 6.9006
      netbeans        x0000_revs_xx000_added_x000_copies    588c2d1ced70 1aad62e59ddd :  10.032499 s, killed
      mozilla-central x_revs_x_added_0_copies               3697f962bb7b 7015fcdd43a2 :   0.000189 s,   0.000199 s,  +0.000010 s, × 1.0529
      mozilla-central x_revs_x000_added_0_copies            dd390860c6c9 40d0c5bed75d :   0.000462 s,   0.000639 s,  +0.000177 s, × 1.3831
      mozilla-central x_revs_x_added_x_copies               8d198483ae3b 14207ffc2b2f :   0.000270 s,   0.000542 s,  +0.000272 s, × 2.0074
      mozilla-central x_revs_x00_added_x_copies             98cbc58cc6bc 446a150332c3 :   0.001474 s,   0.001685 s,  +0.000211 s, × 1.1431
      mozilla-central x_revs_x000_added_x000_copies         3c684b4b8f68 0a5e72d1b479 :   0.004806 s,   0.006954 s,  +0.002148 s, × 1.4469
      mozilla-central x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.085150 s,   0.132938 s,  +0.047788 s, × 1.5612
      mozilla-central x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.007064 s,   0.008683 s,  +0.001619 s, × 1.2292
      mozilla-central x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.004741 s,   0.005956 s,  +0.001215 s, × 1.2563
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :   0.190133 s,   0.963905 s,  +0.773772 s, × 5.0696
      mozilla-central x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.035651 s,   0.049239 s,  +0.013588 s, × 1.3811
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :   0.440694 s,   4.217003 s,  +3.776309 s, × 9.5690
      mozilla-central x00000_revs_x0000_added_x0000_copies  6832ae71433c 4c222a1d9a00 :  18.454163 s, killed
      mozilla-central x00000_revs_x00000_added_x000_copies  76caed42cf7c 1daa622bbe42 :  31.562719 s, killed
      mozilla-try     x_revs_x_added_0_copies               aaf6dde0deb8 9790f499805a :   0.001189 s,   0.001197 s,  +0.000008 s, × 1.0067
      mozilla-try     x_revs_x000_added_0_copies            d8d0222927b4 5bb8ce8c7450 :   0.001204 s,   0.001213 s,  +0.000009 s, × 1.0075
      mozilla-try     x_revs_x_added_x_copies               092fcca11bdb 936255a0384a :   0.000586 s,   0.000762 s,  +0.000176 s, × 1.3003
      mozilla-try     x_revs_x00_added_x_copies             b53d2fadbdb5 017afae788ec :   0.001845 s,   0.001909 s,  +0.000064 s, × 1.0347
      mozilla-try     x_revs_x000_added_x000_copies         20408ad61ce5 6f0ee96e21ad :   0.063822 s,   0.093021 s,  +0.029199 s, × 1.4575
      mozilla-try     x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.088038 s,   0.134536 s,  +0.046498 s, × 1.5282
      mozilla-try     x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.007389 s,   0.009071 s,  +0.001682 s, × 1.2276
      mozilla-try     x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.004868 s,   0.006206 s,  +0.001338 s, × 1.2749
      mozilla-try     x000_revs_x000_added_x000_copies      1346fd0130e4 4c65cbdabc1f :   0.222450 s,   1.150502 s,  +0.928052 s, × 5.1720
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 :   0.370675 s,   1.114864 s,  +0.744189 s, × 3.0077
      mozilla-try     x0000_revs_x_added_x_copies           9fe69ff0762d bcabf2a78927 :   0.358020 s,   1.042658 s,  +0.684638 s, × 2.9123
      mozilla-try     x0000_revs_xx000_added_x_copies       156f6e2674f2 4d0f2c178e66 :   0.145235 s,   0.447402 s,  +0.302167 s, × 3.0805
      mozilla-try     x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.037606 s,   0.051132 s,  +0.013526 s, × 1.3597
      mozilla-try     x0000_revs_xx000_added_x000_copies    89294cd501d9 7ccb2fc7ccb5 :   7.382439 s,  83.508590 s, +76.126151 s, × 11.3118
      mozilla-try     x0000_revs_x0000_added_x0000_copies   e928c65095ed e951f4ad123a :   7.273506 s,  55.079813 s, +47.806307 s, × 7.5727
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c :   1.074593 s,   1.442793 s,  +0.368200 s, × 1.3426
      mozilla-try     x00000_revs_x0000_added_x0000_copies  8d3fafa80d4b eb884023b810 :  27.746195 s, killed
      d6c501e28ff4
  4. Oct 01, 2020
    • Pierre-Yves David's avatar
      copies: use the rust code for `combine_changeset_copies` · d19a0099607a
      Pierre-Yves David authored
      Changeset centric copy tracing now use the rust code. The rust code focussed on
      simplicity and will be optimised later. So the performance is not great yet. Now
      that all the pieces are in place we can start working on performance in the
      coming changesets.
      
      below is a table that summarize how slower we got:
      
      Repo            Cases                                 Source-Rev   Dest-Rev         Py-time       Rust-time    Difference   Factor
      ------------------------------------------------------------------------------------------------------------------------------------
      mercurial       x_revs_x_added_0_copies               ad6b123de1c7 39cfcef4f463 :   0.000049 s,   0.000046 s,  -0.000003 s, × 0.9388
      mercurial       x_revs_x_added_x_copies               2b1c78674230 0c1d10351869 :   0.000112 s,   0.000173 s,  +0.000061 s, × 1.5446
      mercurial       x000_revs_x000_added_x_copies         81f8ff2a9bf2 dd3267698d84 :   0.004216 s,   0.006303 s,  +0.002087 s, × 1.4950
      pypy            x_revs_x_added_0_copies               aed021ee8ae8 099ed31b181b :   0.000204 s,   0.000229 s,  +0.000025 s, × 1.1225
      pypy            x_revs_x000_added_0_copies            4aa4e1f8e19a 359343b9ac0e :   0.000058 s,   0.000056 s,  -0.000002 s, × 0.9655
      pypy            x_revs_x_added_x_copies               ac52eb7bbbb0 72e022663155 :   0.000112 s,   0.000143 s,  +0.000031 s, × 1.2768
      pypy            x_revs_x00_added_x_copies             c3b14617fbd7 ace7255d9a26 :   0.000339 s,   0.001166 s,  +0.000827 s, × 3.4395
      pypy            x_revs_x000_added_x000_copies         df6f7a526b60 a83dc6a2d56f :   0.010214 s,   0.022931 s,  +0.012717 s, × 2.2451
      pypy            x000_revs_xx00_added_0_copies         89a76aede314 2f22446ff07e :   0.047497 s,   0.852446 s,  +0.804949 s, × 17.9474
      pypy            x000_revs_x000_added_x_copies         8a3b5bfd266e 2c68e87c3efe :   0.075297 s,   2.221824 s,  +2.146527 s, × 29.5075
      pypy            x000_revs_x000_added_x000_copies      89a76aede314 7b3dda341c84 :   0.057322 s,   1.194162 s,  +1.136840 s, × 20.8325
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :   0.796264 s,  62.468362 s, +61.672098 s, × 78.4518
      pypy            x0000_revs_xx000_added_0_copies       bf2c629d0071 4ffed77c095c :   0.020491 s,   0.022116 s,  +0.001625 s, × 1.0793
      pypy            x0000_revs_xx000_added_x000_copies    08ea3258278e d9fa043f30c0 :   0.121612 s,   2.972788 s,  +2.851176 s, × 24.4449
      netbeans        x_revs_x_added_0_copies               fb0955ffcbcd a01e9239f9e7 :   0.000143 s,   0.000180 s,  +0.000037 s, × 1.2587
      netbeans        x_revs_x000_added_0_copies            6f360122949f 20eb231cc7d0 :   0.000112 s,   0.000123 s,  +0.000011 s, × 1.0982
      netbeans        x_revs_x_added_x_copies               1ada3faf6fb6 5a39d12eecf4 :   0.000232 s,   0.000315 s,  +0.000083 s, × 1.3578
      netbeans        x_revs_x00_added_x_copies             35be93ba1e2c 9eec5e90c05f :   0.000721 s,   0.001297 s,  +0.000576 s, × 1.7989
      netbeans        x000_revs_xx00_added_0_copies         eac3045b4fdd 51d4ae7f1290 :   0.010115 s,   0.024884 s,  +0.014769 s, × 2.4601
      netbeans        x000_revs_x000_added_x_copies         e2063d266acd 6081d72689dc :   0.015461 s,   0.032653 s,  +0.017192 s, × 2.1120
      netbeans        x000_revs_x000_added_x000_copies      ff453e9fee32 411350406ec2 :   0.060756 s,   4.230118 s,  +4.169362 s, × 69.6247
      netbeans        x0000_revs_xx000_added_x000_copies    588c2d1ced70 1aad62e59ddd :   0.605842 s, killed
      mozilla-central x_revs_x_added_0_copies               3697f962bb7b 7015fcdd43a2 :   0.000164 s,   0.000197 s,  +0.000033 s, × 1.2012
      mozilla-central x_revs_x000_added_0_copies            dd390860c6c9 40d0c5bed75d :   0.000331 s,   0.000622 s,  +0.000291 s, × 1.8792
      mozilla-central x_revs_x_added_x_copies               8d198483ae3b 14207ffc2b2f :   0.000249 s,   0.000296 s,  +0.000047 s, × 1.1888
      mozilla-central x_revs_x00_added_x_copies             98cbc58cc6bc 446a150332c3 :   0.000711 s,   0.001626 s,  +0.000915 s, × 2.2869
      mozilla-central x_revs_x000_added_x000_copies         3c684b4b8f68 0a5e72d1b479 :   0.003438 s,   0.006218 s,  +0.002780 s, × 1.8086
      mozilla-central x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.069869 s,   0.132760 s,  +0.062891 s, × 1.9001
      mozilla-central x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.005701 s,   0.029001 s,  +0.023300 s, × 5.0870
      mozilla-central x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.005757 s,   0.005886 s,  +0.000129 s, × 1.0224
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :   0.061826 s,   3.619850 s,  +3.558024 s, × 58.5490
      mozilla-central x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.043354 s,   0.058678 s,  +0.015324 s, × 1.3535
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :   0.198979 s,  11.926587 s, +11.727608 s, × 59.9389
      mozilla-central x00000_revs_x0000_added_x0000_copies  6832ae71433c 4c222a1d9a00 :   2.067096 s, killed
      mozilla-central x00000_revs_x00000_added_x000_copies  76caed42cf7c 1daa622bbe42 :   3.102616 s, killed
      mozilla-try     x_revs_x_added_0_copies               aaf6dde0deb8 9790f499805a :   0.001212 s,   0.001204 s,  -0.000008 s, × 0.9934
      mozilla-try     x_revs_x000_added_0_copies            d8d0222927b4 5bb8ce8c7450 :   0.001237 s,   0.001217 s,  -0.000020 s, × 0.9838
      mozilla-try     x_revs_x_added_x_copies               092fcca11bdb 936255a0384a :   0.000557 s,   0.000605 s,  +0.000048 s, × 1.0862
      mozilla-try     x_revs_x00_added_x_copies             b53d2fadbdb5 017afae788ec :   0.001532 s,   0.001876 s,  +0.000344 s, × 1.2245
      mozilla-try     x_revs_x000_added_x000_copies         20408ad61ce5 6f0ee96e21ad :   0.035166 s,   0.078190 s,  +0.043024 s, × 2.2235
      mozilla-try     x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.070336 s,   0.135428 s,  +0.065092 s, × 1.9254
      mozilla-try     x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.006080 s,   0.029123 s,  +0.023043 s, × 4.7900
      mozilla-try     x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.006099 s,   0.006141 s,  +0.000042 s, × 1.0069
      mozilla-try     x000_revs_x000_added_x000_copies      1346fd0130e4 4c65cbdabc1f :   0.064317 s,   4.857827 s,  +4.793510 s, × 75.5294
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 :   0.303263 s,  10.674920 s, +10.371657 s, × 35.2002
      mozilla-try     x0000_revs_x_added_x_copies           9fe69ff0762d bcabf2a78927 :   0.292804 s,   9.789462 s,  +9.496658 s, × 33.4335
      mozilla-try     x0000_revs_xx000_added_x_copies       156f6e2674f2 4d0f2c178e66 :   0.107594 s,   1.087890 s,  +0.980296 s, × 10.1111
      mozilla-try     x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.045202 s,   0.060556 s,  +0.015354 s, × 1.3397
      mozilla-try     x0000_revs_xx000_added_x000_copies    89294cd501d9 7ccb2fc7ccb5 :   1.926277 s, killed
      mozilla-try     x0000_revs_x0000_added_x0000_copies   e928c65095ed e951f4ad123a :   0.794492 s, killed
      mozilla-try     x00000_revs_x_added_0_copies          6a320851d377 1ebb79acd503 :  84.521497 s, killed
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c :   0.965937 s,  19.647038 s, +18.681101 s, × 20.3399
      mozilla-try     x00000_revs_x_added_x_copies          5173c4b6f97c 95d83ee7242d :  83.367146 s, killed
      mozilla-try     x00000_revs_x000_added_x_copies       9126823d0e9c ca82787bb23c :  84.260895 s, killed
      mozilla-try     x00000_revs_x0000_added_x0000_copies  8d3fafa80d4b eb884023b810 :   3.274537 s, killed
      mozilla-try     x00000_revs_x00000_added_x0000_copies 1b661134e2ca 1ae03d022d6d :  42.235843 s, killed
      mozilla-try     x00000_revs_x00000_added_x000_copies  9b2a99adc05e 8e29777b48e6 :  49.872829 s, killed
      d19a0099607a
    • Pierre-Yves David's avatar
      copies: introduce the hg-cpython wrapper for `combine_changeset_copies` · 66fa902c4e59
      Pierre-Yves David authored
      This patch focus on the `hg-cpython` part of this work. Bridging the python code
      with the new rust code in `hg-core`. The next patch will actually plug this in
      the python code.
      
      The rust code use multiple Python callback, python related error within this
      callback are not expected unless they are a programming error or a data
      corruption. In addition, these callback will slowly be replaced by native Rust
      code. For these reasons, we use will deal with unexpected error within this
      callback using rust Panic and let the `rust-cpython` layer deal with raising a
      Python exception.
      66fa902c4e59
    • Pierre-Yves David's avatar
      copies: introduce a basic Rust function for `combine_changeset_copies` · 7b876075388d
      Pierre-Yves David authored
      This new function mirror the python code.  This first implementation does a lot
      of data copies and is therefore quite slow. However my goal here is to create a
      simple "frame" from where to start more aggressive optimization.
      
      This patch focus on the `hg-core` part of this work. Coming patches will do the
      necessary `hg-cpython` work  to be able to use this from Python.
      
      For this first patch, the structure of the Rust patch is close to the python
      code. In later patch we will change that structure to prepare performance
      improvement. Such patch could have been folded in that one, however I find it
      clearer to use explicit patch to slowly change the code structure.
      7b876075388d
  5. Nov 02, 2020
    • Pierre-Yves David's avatar
      copies: cache the ancestor checking call when tracing copy · d7167308ccb8
      Pierre-Yves David authored
      A good share of the time spent in this function is spent doing ancestors
      checking. To avoid spending time in duplicated call, we cache the result of
      calls.
      
      In the slower case, this provide a quite significant performance boost. Below
      are the result for a set of selected pairs (many of them pathological):
      
      (And further down is another table that summarize the current state of filelog
      based vs changeset base copy tracing)
      
      
      The benchmark have been configured to be killed after 6 minutes of runtime,
      which mean that any detect slower than 2 minutes will be marked as "killed".
      This drop some useful information about how much slower these case are… but also
      prevent 99% of the benchmark time to be spent on case that can be labelled "very
      slow" anyway.
      
      
      Repo            Case                                  Source-Rev   Dest-Rev         Old-Time      New-Time     Difference   Factor
      ------------------------------------------------------------------------------------------------------------------------------------
      mercurial       x_revs_x_added_0_copies               ad6b123de1c7 39cfcef4f463 :   0.000044 s,   0.000044 s,  +0.000000 s, × 1.0000
      mercurial       x_revs_x_added_x_copies               2b1c78674230 0c1d10351869 :   0.000138 s,   0.000138 s,  +0.000000 s, × 1.0000
      mercurial       x000_revs_x000_added_x_copies         81f8ff2a9bf2 dd3267698d84 :   0.005067 s,   0.005052 s,  -0.000015 s, × 0.9970
      pypy            x_revs_x_added_0_copies               aed021ee8ae8 099ed31b181b :   0.000218 s,   0.000219 s,  +0.000001 s, × 1.0046
      pypy            x_revs_x000_added_0_copies            4aa4e1f8e19a 359343b9ac0e :   0.000053 s,   0.000055 s,  +0.000002 s, × 1.0377
      pypy            x_revs_x_added_x_copies               ac52eb7bbbb0 72e022663155 :   0.000125 s,   0.000128 s,  +0.000003 s, × 1.0240
      pypy            x_revs_x00_added_x_copies             c3b14617fbd7 ace7255d9a26 :   0.001098 s,   0.001089 s,  -0.000009 s, × 0.9918
      pypy            x_revs_x000_added_x000_copies         df6f7a526b60 a83dc6a2d56f :   0.017546 s,   0.017407 s,  -0.000139 s, × 0.9921
      pypy            x000_revs_xx00_added_0_copies         89a76aede314 2f22446ff07e :   0.096723 s,   0.094175 s,  -0.002548 s, × 0.9737
      pypy            x000_revs_x000_added_x_copies         8a3b5bfd266e 2c68e87c3efe :   0.271796 s,   0.238009 s,  -0.033787 s, × 0.8757
      pypy            x000_revs_x000_added_x000_copies      89a76aede314 7b3dda341c84 :   0.128602 s,   0.125876 s,  -0.002726 s, × 0.9788
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :   7.086742 s,   3.581556 s,  -3.505186 s, × 0.5054
      pypy            x0000_revs_xx000_added_0_copies       bf2c629d0071 4ffed77c095c :   0.016634 s,   0.016721 s,  +0.000087 s, × 1.0052
      pypy            x0000_revs_xx000_added_x000_copies    08ea3258278e d9fa043f30c0 :   0.254225 s,   0.242367 s,  -0.011858 s, × 0.9534
      netbeans        x_revs_x_added_0_copies               fb0955ffcbcd a01e9239f9e7 :   0.000166 s,   0.000165 s,  -0.000001 s, × 0.9940
      netbeans        x_revs_x000_added_0_copies            6f360122949f 20eb231cc7d0 :   0.000118 s,   0.000114 s,  -0.000004 s, × 0.9661
      netbeans        x_revs_x_added_x_copies               1ada3faf6fb6 5a39d12eecf4 :   0.000296 s,   0.000296 s,  +0.000000 s, × 1.0000
      netbeans        x_revs_x00_added_x_copies             35be93ba1e2c 9eec5e90c05f :   0.001137 s,   0.001124 s,  -0.000013 s, × 0.9886
      netbeans        x000_revs_xx00_added_0_copies         eac3045b4fdd 51d4ae7f1290 :   0.014133 s,   0.013060 s,  -0.001073 s, × 0.9241
      netbeans        x000_revs_x000_added_x_copies         e2063d266acd 6081d72689dc :   0.016988 s,   0.017112 s,  +0.000124 s, × 1.0073
      netbeans        x000_revs_x000_added_x000_copies      ff453e9fee32 411350406ec2 :   0.676361 s,   0.660350 s,  -0.016011 s, × 0.9763
      netbeans        x0000_revs_xx000_added_x000_copies    588c2d1ced70 1aad62e59ddd :  12.515149 s,  10.032499 s,  -2.482650 s, × 0.8016
      mozilla-central x_revs_x_added_0_copies               3697f962bb7b 7015fcdd43a2 :   0.000186 s,   0.000189 s,  +0.000003 s, × 1.0161
      mozilla-central x_revs_x000_added_0_copies            dd390860c6c9 40d0c5bed75d :   0.000459 s,   0.000462 s,  +0.000003 s, × 1.0065
      mozilla-central x_revs_x_added_x_copies               8d198483ae3b 14207ffc2b2f :   0.000273 s,   0.000270 s,  -0.000003 s, × 0.9890
      mozilla-central x_revs_x00_added_x_copies             98cbc58cc6bc 446a150332c3 :   0.001503 s,   0.001474 s,  -0.000029 s, × 0.9807
      mozilla-central x_revs_x000_added_x000_copies         3c684b4b8f68 0a5e72d1b479 :   0.004862 s,   0.004806 s,  -0.000056 s, × 0.9885
      mozilla-central x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.088291 s,   0.085150 s,  -0.003141 s, × 0.9644
      mozilla-central x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.007113 s,   0.007064 s,  -0.000049 s, × 0.9931
      mozilla-central x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.004687 s,   0.004741 s,  +0.000054 s, × 1.0115
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :   0.198710 s,   0.190133 s,  -0.008577 s, × 0.9568
      mozilla-central x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.036068 s,   0.035651 s,  -0.000417 s, × 0.9884
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :   0.465362 s,   0.440694 s,  -0.024668 s, × 0.9470
      mozilla-central x00000_revs_x0000_added_x0000_copies  6832ae71433c 4c222a1d9a00 :  24.519684 s,  18.454163 s,  -6.065521 s, × 0.7526
      mozilla-central x00000_revs_x00000_added_x000_copies  76caed42cf7c 1daa622bbe42 :  42.711897 s,  31.562719 s, -11.149178 s, × 0.7390
      mozilla-try     x_revs_x_added_0_copies               aaf6dde0deb8 9790f499805a :   0.001201 s,   0.001189 s,  -0.000012 s, × 0.9900
      mozilla-try     x_revs_x000_added_0_copies            d8d0222927b4 5bb8ce8c7450 :   0.001216 s,   0.001204 s,  -0.000012 s, × 0.9901
      mozilla-try     x_revs_x_added_x_copies               092fcca11bdb 936255a0384a :   0.000595 s,   0.000586 s,  -0.000009 s, × 0.9849
      mozilla-try     x_revs_x00_added_x_copies             b53d2fadbdb5 017afae788ec :   0.001856 s,   0.001845 s,  -0.000011 s, × 0.9941
      mozilla-try     x_revs_x000_added_x000_copies         20408ad61ce5 6f0ee96e21ad :   0.064936 s,   0.063822 s,  -0.001114 s, × 0.9828
      mozilla-try     x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.090601 s,   0.088038 s,  -0.002563 s, × 0.9717
      mozilla-try     x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.007510 s,   0.007389 s,  -0.000121 s, × 0.9839
      mozilla-try     x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.004911 s,   0.004868 s,  -0.000043 s, × 0.9912
      mozilla-try     x000_revs_x000_added_x000_copies      1346fd0130e4 4c65cbdabc1f :   0.233231 s,   0.222450 s,  -0.010781 s, × 0.9538
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 :   0.419989 s,   0.370675 s,  -0.049314 s, × 0.8826
      mozilla-try     x0000_revs_x_added_x_copies           9fe69ff0762d bcabf2a78927 :   0.401521 s,   0.358020 s,  -0.043501 s, × 0.8917
      mozilla-try     x0000_revs_xx000_added_x_copies       156f6e2674f2 4d0f2c178e66 :   0.179555 s,   0.145235 s,  -0.034320 s, × 0.8089
      mozilla-try     x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.038004 s,   0.037606 s,  -0.000398 s, × 0.9895
      mozilla-try     x0000_revs_xx000_added_x000_copies    89294cd501d9 7ccb2fc7ccb5 :  52.838482 s,   7.382439 s, -45.456043 s, × 0.1397
      mozilla-try     x0000_revs_x0000_added_x0000_copies   e928c65095ed e951f4ad123a :   8.705874 s,   7.273506 s,  -1.432368 s, × 0.8355
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c :   1.126708 s,   1.074593 s,  -0.052115 s, × 0.9537
      mozilla-try     x00000_revs_x0000_added_x0000_copies  8d3fafa80d4b eb884023b810 :  83.854020 s,  27.746195 s, -56.107825 s, × 0.3309
      
      
      Below is a table comparing the runtime of the current "filelog centric"
      algorithm, with the "changeset centric" one, we just modified.
      
      The changeset centric algorithm is a significant win in many scenario, but they
      are still various cases where it is quite slower. When many revision  has to be
      considered the cost of retrieving the copy information, creating new
      dictionaries, merging dictionaries and checking if revision are ancestors of
      each other can slow things down.
      
      The rest of this series, will introduce a rust version of the copy tracing code
      to deal with most of theses issues.
      
      
      Repo            Case                                  Source-Rev   Dest-Rev         filelog     sidedata      Difference       Factor
      ---------------------------------------------------------------------------------------------------------------------------------------
      mercurial       x_revs_x_added_0_copies               ad6b123de1c7 39cfcef4f463 :  0.000914 s,  0.000044 s, - 0.000870 s,    × 0.048140
      mercurial       x_revs_x_added_x_copies               2b1c78674230 0c1d10351869 :  0.001812 s,  0.000138 s, - 0.001674 s,    × 0.076159
      mercurial       x000_revs_x000_added_x_copies         81f8ff2a9bf2 dd3267698d84 :  0.017954 s,  0.005052 s, - 0.012902 s,    × 0.281386
      pypy            x_revs_x_added_0_copies               aed021ee8ae8 099ed31b181b :  0.001509 s,  0.000219 s, - 0.001290 s,    × 0.145129
      pypy            x_revs_x000_added_0_copies            4aa4e1f8e19a 359343b9ac0e :  0.206881 s,  0.000055 s, - 0.206826 s,    × 0.000266
      pypy            x_revs_x_added_x_copies               ac52eb7bbbb0 72e022663155 :  0.016951 s,  0.000128 s, - 0.016823 s,    × 0.007551
      pypy            x_revs_x00_added_x_copies             c3b14617fbd7 ace7255d9a26 :  0.019096 s,  0.001089 s, - 0.018007 s,    × 0.057028
      pypy            x_revs_x000_added_x000_copies         df6f7a526b60 a83dc6a2d56f :  0.762506 s,  0.017407 s, - 0.745099 s,    × 0.022829
      pypy            x000_revs_xx00_added_0_copies         89a76aede314 2f22446ff07e :  1.179211 s,  0.094175 s, - 1.085036 s,    × 0.079863
      pypy            x000_revs_x000_added_x_copies         8a3b5bfd266e 2c68e87c3efe :  1.249058 s,  0.238009 s, - 1.011049 s,    × 0.190551
      pypy            x000_revs_x000_added_x000_copies      89a76aede314 7b3dda341c84 :  1.614107 s,  0.125876 s, - 1.488231 s,    × 0.077985
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :  0.001064 s,  3.581556 s, + 3.580492 s, × 3366.124060
      pypy            x0000_revs_xx000_added_0_copies       bf2c629d0071 4ffed77c095c :  1.061275 s,  0.016721 s, - 1.044554 s,    × 0.015756
      pypy            x0000_revs_xx000_added_x000_copies    08ea3258278e d9fa043f30c0 :  1.341119 s,  0.242367 s, - 1.098752 s,    × 0.180720
      netbeans        x_revs_x_added_0_copies               fb0955ffcbcd a01e9239f9e7 :  0.027803 s,  0.000165 s, - 0.027638 s,    × 0.005935
      netbeans        x_revs_x000_added_0_copies            6f360122949f 20eb231cc7d0 :  0.130014 s,  0.000114 s, - 0.129900 s,    × 0.000877
      netbeans        x_revs_x_added_x_copies               1ada3faf6fb6 5a39d12eecf4 :  0.024990 s,  0.000296 s, - 0.024694 s,    × 0.011845
      netbeans        x_revs_x00_added_x_copies             35be93ba1e2c 9eec5e90c05f :  0.052201 s,  0.001124 s, - 0.051077 s,    × 0.021532
      netbeans        x000_revs_xx00_added_0_copies         eac3045b4fdd 51d4ae7f1290 :  0.037642 s,  0.013060 s, - 0.024582 s,    × 0.346953
      netbeans        x000_revs_x000_added_x_copies         e2063d266acd 6081d72689dc :  0.197086 s,  0.017112 s, - 0.179974 s,    × 0.086825
      netbeans        x000_revs_x000_added_x000_copies      ff453e9fee32 411350406ec2 :  0.935148 s,  0.660350 s, - 0.274798 s,    × 0.706145
      netbeans        x0000_revs_xx000_added_x000_copies    588c2d1ced70 1aad62e59ddd :  3.920674 s, 10.032499 s, + 6.111825 s,    × 2.558871
      mozilla-central x_revs_x_added_0_copies               3697f962bb7b 7015fcdd43a2 :  0.024232 s,  0.000189 s, - 0.024043 s,    × 0.007800
      mozilla-central x_revs_x000_added_0_copies            dd390860c6c9 40d0c5bed75d :  0.141483 s,  0.000462 s, - 0.141021 s,    × 0.003265
      mozilla-central x_revs_x_added_x_copies               8d198483ae3b 14207ffc2b2f :  0.025775 s,  0.000270 s, - 0.025505 s,    × 0.010475
      mozilla-central x_revs_x00_added_x_copies             98cbc58cc6bc 446a150332c3 :  0.084922 s,  0.001474 s, - 0.083448 s,    × 0.017357
      mozilla-central x_revs_x000_added_x000_copies         3c684b4b8f68 0a5e72d1b479 :  0.194784 s,  0.004806 s, - 0.189978 s,    × 0.024673
      mozilla-central x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :  2.161103 s,  0.085150 s, - 2.075953 s,    × 0.039401
      mozilla-central x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :  0.089347 s,  0.007064 s, - 0.082283 s,    × 0.079063
      mozilla-central x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :  0.732171 s,  0.004741 s, - 0.727430 s,    × 0.006475
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :  1.157287 s,  0.190133 s, - 0.967154 s,    × 0.164292
      mozilla-central x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :  6.726568 s,  0.035651 s, - 6.690917 s,    × 0.005300
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :  3.266229 s,  0.440694 s, - 2.825535 s,    × 0.134924
      mozilla-central x00000_revs_x0000_added_x0000_copies  6832ae71433c 4c222a1d9a00 : 15.860534 s, 18.454163 s, + 2.593629 s,    × 1.163527
      mozilla-central x00000_revs_x00000_added_x000_copies  76caed42cf7c 1daa622bbe42 : 20.450475 s, 31.562719 s, +11.112244 s,    × 1.543373
      mozilla-try     x_revs_x_added_0_copies               aaf6dde0deb8 9790f499805a :  0.080442 s,  0.001189 s, - 0.079253 s,    × 0.014781
      mozilla-try     x_revs_x000_added_0_copies            d8d0222927b4 5bb8ce8c7450 :  0.497672 s,  0.001204 s, - 0.496468 s,    × 0.002419
      mozilla-try     x_revs_x_added_x_copies               092fcca11bdb 936255a0384a :  0.021183 s,  0.000586 s, - 0.020597 s,    × 0.027664
      mozilla-try     x_revs_x00_added_x_copies             b53d2fadbdb5 017afae788ec :  0.230991 s,  0.001845 s, - 0.229146 s,    × 0.007987
      mozilla-try     x_revs_x000_added_x000_copies         20408ad61ce5 6f0ee96e21ad :  1.118461 s,  0.063822 s, - 1.054639 s,    × 0.057062
      mozilla-try     x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :  2.206083 s,  0.088038 s, - 2.118045 s,    × 0.039907
      mozilla-try     x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :  0.089404 s,  0.007389 s, - 0.082015 s,    × 0.082647
      mozilla-try     x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :  0.733043 s,  0.004868 s, - 0.728175 s,    × 0.006641
      mozilla-try     x000_revs_x000_added_x000_copies      1346fd0130e4 4c65cbdabc1f :  1.163367 s,  0.222450 s, - 0.940917 s,    × 0.191212
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 :  0.085456 s,  0.370675 s, + 0.285219 s,    × 4.337612
      mozilla-try     x0000_revs_x_added_x_copies           9fe69ff0762d bcabf2a78927 :  0.083601 s,  0.358020 s, + 0.274419 s,    × 4.282485
      mozilla-try     x0000_revs_xx000_added_x_copies       156f6e2674f2 4d0f2c178e66 :  7.366614 s,  0.145235 s, - 7.221379 s,    × 0.019715
      mozilla-try     x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :  6.664464 s,  0.037606 s, - 6.626858 s,    × 0.005643
      mozilla-try     x0000_revs_xx000_added_x000_copies    89294cd501d9 7ccb2fc7ccb5 :  7.467836 s,  7.382439 s, - 0.085397 s,    × 0.988565
      mozilla-try     x0000_revs_x0000_added_x0000_copies   e928c65095ed e951f4ad123a :  9.801294 s,  7.273506 s, - 2.527788 s,    × 0.742097
      mozilla-try     x00000_revs_x_added_0_copies          6a320851d377 1ebb79acd503 :  0.091886 s, killed
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c : 26.491140 s,  1.074593 s, -25.416547 s,    × 0.040564
      mozilla-try     x00000_revs_x_added_x_copies          5173c4b6f97c 95d83ee7242d :  0.092863 s, killed
      mozilla-try     x00000_revs_x000_added_x_copies       9126823d0e9c ca82787bb23c :  0.226823 s, killed
      mozilla-try     x00000_revs_x0000_added_x0000_copies  8d3fafa80d4b eb884023b810 : 18.914630 s, 27.746195 s, + 8.831565 s,    × 1.466917
      mozilla-try     x00000_revs_x00000_added_x0000_copies 1b661134e2ca 1ae03d022d6d : 21.198903 s, killed
      mozilla-try     x00000_revs_x00000_added_x000_copies  9b2a99adc05e 8e29777b48e6 : 24.952268 s, killed
      d7167308ccb8
  6. Oct 13, 2020
  7. Oct 21, 2020
  8. Oct 29, 2020
  9. Oct 24, 2020
    • Matt Harbison's avatar
      repoview: only pin obsolete wdir parents while there are unresolved conflicts · 341e014fe0fb
      Matt Harbison authored
      I noticed after doing an update from an obsolete revision with a dirty wdir that
      the obsolete commit stayed visible for no obvious reason.  It was decided in
      85b03b1e4715 not to clear mergestate once all of the conflicts were resolved, in
      order to allow re-resolving.  Since the point of pinning the obsolete parents
      was to allow resolving in the first place (aaeccdb6e654), it makes sense to also
      gate it on whether or not there are any remaining files to resolve.  This might
      result in pinning again if files are marked unresolved again, but that seems
      reasonable, given that it still solves the original issue.
      
      Note that this isn't purely cosmetic- pushing with a pinned obsolete revision is
      likely to cause complaints about pushing multiple heads or other unexpected
      errors.  So the faster it comes out of that state, the better.
      
      Differential Revision: https://phab.mercurial-scm.org/D9248
      341e014fe0fb
  10. Oct 28, 2020
  11. Oct 23, 2020
  12. Oct 29, 2020
  13. Oct 17, 2020
  14. Oct 13, 2020
  15. Oct 23, 2020
  16. Oct 20, 2020
  17. Oct 19, 2020
  18. Oct 18, 2020
  19. Oct 07, 2020
    • Pulkit Goyal's avatar
      tags: add safety check for len(record) while reading hgtagsfnodescache · 225e513c444e
      Pulkit Goyal authored
      I am trying to fix a breakage where somehow we end up getting a node of 12
      length from `getfnode()`. Understanding the hgtagsfnodescache code, it seems
      highly unlikely that it can happen unless one of `mctx.readfast().get()` or
      `ctx.filenode()` is returning a node of 12 length.
      
      For safety, I think it's better to add a check to make sure that record which we
      are parsing is of same length we are expecting otherwise we consider that as
      invalid record.
      
      Differential Revision: https://phab.mercurial-scm.org/D9169
      225e513c444e
  20. Oct 14, 2020
  21. Oct 15, 2020
    • Pierre-Yves David's avatar
      clonebundles: move a bundle of clone bundle related code to a new module · 74271829ddc0
      Pierre-Yves David authored
      In the process on general clone bundle automatically, we need to make some
      function available more widely. This is a good opportunity to extract a
      significant amount of code from `mercurial.exchange` into a new
      `mercurial.bundlecaches`. This make `mercurial.exchange` move under the 3K line
      range (hooray…).
      
      The module is called `bundlecaches` because I expect it to be eventually useful
      for more than just clone bundle (like pull bunbles).
      
      Differential Revision: https://phab.mercurial-scm.org/D9208
      74271829ddc0
  22. Jul 01, 2020
  23. Sep 18, 2020
  24. Oct 09, 2020
  25. Oct 20, 2020
  26. Oct 14, 2020
  27. Oct 22, 2020
  28. Oct 20, 2020
  29. Oct 16, 2020
  30. Oct 27, 2020
Loading