Skip to content
Snippets Groups Projects
  1. Jun 09, 2017
    • Gregory Szorc's avatar
      debugcommands: issue warning when repo has secret changesets (issue5589) · 23734c0e
      Gregory Szorc authored
      This seems like a prudent thing to do. As the inline comment says,
      we may want to make this abort once the functionality is stabilized
      as part of `hg bundle`. Let's save that debate for another day.
      23734c0e
    • Gregory Szorc's avatar
      streamclone: consider secret changesets (BC) (issue5589) · 33b7283a
      Gregory Szorc authored
      Previously, a repo containing secret changesets would be served via
      stream clone, transferring those secret changesets. While secret
      changesets aren't meant to imply strong security (if you really
      want to keep them secret, others shouldn't have read access to the
      repo), we should at least make an effort to protect secret changesets
      when possible.
      
      After this commit, we no longer serve stream clones for repos
      containing secret changesets by default. This is backwards
      incompatible behavior. In case anyone is relying on the behavior,
      we provide a config option to opt into the old behavior.
      
      Note that this defense is only beneficial for remote repos
      accessed via the wire protocol: if a client has access to the
      files backing a repo, they can get to the raw data and see secret
      revisions.
      33b7283a
    • Yuya Nishihara's avatar
      json: pass formatting options recursively · f924dd04
      Yuya Nishihara authored
      This bug was introduced in 654e9a1c8a6c. It's okay to escape <>, but is
      unnecessary for command output.
      f924dd04
  2. Apr 23, 2017
  3. Jun 09, 2017
  4. Jun 07, 2017
    • Pierre-Yves David's avatar
      bookmarks: move variable initialization earlier · 999aa9cf
      Pierre-Yves David authored
      Since we no longer set '_clean = False' during the initialization loop, we can
      move the attribute assignment earlier in the function for clarity.
      
      (no speed improvement expected or measured ;-) )
      999aa9cf
    • Pierre-Yves David's avatar
      bookmarks: directly use base dict 'setitem' · d6924192
      Pierre-Yves David authored
      The bmstore '__setitem__' method is setting an extra flag that is not needed
      during initialization. Skipping the method will allow further cleanup and yield
      some speedup as a side effect.
      
      Before:
      ! wall 0.009120 comb 0.010000 user 0.010000 sys 0.000000 (best of 312)
      
      After:
      ! wall 0.007874 comb 0.010000 user 0.010000 sys 0.000000 (best of 360)
      d6924192
    • Pierre-Yves David's avatar
      bookmarks: rely on exception for malformed lines · 173f1bdc
      Pierre-Yves David authored
      Since we already have an exception context open, for other thing, we can
      simplify the code a bit and rely on exception handling for invalid lines.
      
      Speed is not the main motivation for this changes. However as I'm in the middle
      of benchmarking things we can see a small positive impact.
      
      Before:
      ! wall 0.009358 comb 0.000000 user 0.000000 sys 0.000000 (best of 303)
      
      After:
      ! wall 0.009173 comb 0.010000 user 0.010000 sys 0.000000 (best of 310)
      173f1bdc
    • Pierre-Yves David's avatar
      bookmarks: explicitly convert to 'node' during initialization · d7522f98
      Pierre-Yves David authored
      We know the content of the file is supposed to be full hex. So we can do the
      translation ourselves and directly check if the node is known.
      
      As nice side effect we now have proper error handling for invalid node value.
      
      Before:
      ! wall 0.021580 comb 0.020000 user 0.020000 sys 0.000000 (best of 134)
      
      After:
      ! wall 0.009342 comb 0.010000 user 0.010000 sys 0.000000 (best of 302)
      d7522f98
    • Pierre-Yves David's avatar
      bookmarks: prefetch 'lookup' outside of the loop · b5613bda
      Pierre-Yves David authored
      Skipping the attribute lookup up raise a significant speedup.
      
      Example on a repository with about 4000 bookmarks.
      
      Before:
      ! wall 0.026027 comb 0.020000 user 0.020000 sys 0.000000 (best of 112)
      After:
      ! wall 0.021580 comb 0.020000 user 0.020000 sys 0.000000 (best of 134)
      
      (This is also in its own changeset to clarify the perf win from another coming
      changesets)
      b5613bda
    • Pierre-Yves David's avatar
      perf: add a perfbookmarks command · 2b0a8b0f
      Pierre-Yves David authored
      A new command dedicated to benchmark of bookmark initialization.
      2b0a8b0f
  5. May 23, 2017
  6. Jun 07, 2017
  7. Jun 09, 2017
    • Gregory Szorc's avatar
      localrepo: move filtername to __init__ · b8ff7d0f
      Gregory Szorc authored
      This is obviously an instance attribute, not a type attribute. The
      modern Python style is to use __init__ for defining these.
      
      This exposes statichttprepo as inheriting from localrepository
      without calling its __init__. As a result, its __init__ defines
      a lot of variables that methods on localrepository's methods need.
      But factoring the common bits into a separate class is for another
      day.
      b8ff7d0f
    • Gregory Szorc's avatar
      obsolete: move obsstore creation logic from localrepo · c8177792
      Gregory Szorc authored
      This code has more to do with obsolete.py than localrepo.py. Let's
      move it there.
      c8177792
    • Martin von Zweigbergk's avatar
      match: allow pats to be None · 3e8eb6d8
      Martin von Zweigbergk authored
      match.match already interprets "!bool(patterns)" as matching
      everything (but includes and excludes still apply). We might as well
      allow None, which lets us simplify some callers a bit.
      
      I originally wrote this patch while trying to change
      match.match(patterns=[]) to mean to match no patterns. This patch is
      one step towards that goal. I'm not sure it'll be worth the effort to
      go all the way there, but I think this patch still makes sense on its
      own.
      3e8eb6d8
  8. Jun 06, 2017
  9. Jun 08, 2017
  10. Apr 26, 2017
    • Koen Van Hoof's avatar
      chmod: create a new file when flags are set on a hardlinked file · c2cb0de2
      Koen Van Hoof authored
      For performance reasons we have several repositories where the files in the working
      directory of 1 repo are hardlinks to the files of the other repo
      When an update in one repo results in a chmod of a such a file, the hardlink
      has to be deleted and replaced by a regular file to make sure that the change
      does not happen in the other repo
      c2cb0de2
  11. Jun 08, 2017
  12. Jun 07, 2017
  13. May 29, 2017
    • durin42's avatar
      tests: remove sys.executable from "required tools" · 04c19c80
      durin42 authored
      In practice this doesn't appear to have been true for some time - we
      reference Python using the $PYTHON variable in all the tests now
      (which we have to for PyPy and Python 3), and I've been using
      ~/.../python.exe to test with tip of the cpython 3.6 release branch
      while working on manifest tests in Python 3 and everything seems to be
      just fine. The only real observable difference from this change is
      that I stop getting a warning about python.exe not being a thing on
      $PATH, which seems like an improvement.
      04c19c80
  14. Jun 05, 2017
  15. May 29, 2017
    • Pierre-Yves David's avatar
      push: add a way to allow concurrent pushes on unrelated heads · 16ada4cb
      Pierre-Yves David authored
      Client has a mechanism for the server to check that nothing changed server side
      since the client prepared a push. That check is wide and any head changed on
      the server will lead to an aborted push. We introduce a way for the client to
      send a less strict checking. That logic will check that no heads impacted by
      the push have been affected. If other unrelated heads (including named branches
      heads) have been affected, the push will proceed.
      
      This is very helpful for repositories with high developers traffic on different
      heads, a common setup.
      
      That behavior is currently controlled by an experimental option. The config
      should live in the "server" section but bike-shedding of the name will happen
      in the next changesets. Servers advertise this capability through a new bundle2
      capability 'checkeads', using the value 'related'.
      
      The 'test-push-race.t' is updated to check that new capabilities on the
      documented cases.
      16ada4cb
    • Pierre-Yves David's avatar
      headsummary: expose the 'discardedheads' set in the headssummary · 90cb4ec8
      Pierre-Yves David authored
      That information will be useful to detect push race on related part of the
      history.
      
      See next changeset for details.
      90cb4ec8
    • Pierre-Yves David's avatar
      checkheads: perform obsolescence post processing directly in _headssummary · 32c8f98a
      Pierre-Yves David authored
      The goal is to have the function directly return something meaningful and
      useful for the whole pull.
      
      Note: we skip adding post-processing in '_oldheadssummary' because if a client
      is too old for branchmap it will be too old for obsolescence too.
      32c8f98a
    • Pierre-Yves David's avatar
      headssummary: directly feed the function with the 'pushop' object · 993f58db
      Pierre-Yves David authored
      Our goal is to be able to perform the post processing directly into the
      '_headssummary' function. However before this patch the '_headsummary' function
      only had access to repo, remote, outgoing while the '_postprocessobsolete'
      function takes a 'pushop' object.  Experience shows that having the 'pushop'
      object helps extensions so we update '_headssummary' to take a pushop
      object as argument.
      993f58db
Loading