Skip to content
Snippets Groups Projects
  1. Feb 22, 2023
    • Pierre-Yves David's avatar
      transaction: use the standard transaction mechanism to backup branch · 2b097e8a
      Pierre-Yves David authored
      Branch is a bit special :
      - It currently does not collaborate with the transaction (or any scoping) for
        writing (this is bad)
      - It can change without the lock being taken (it is protected by `wlock`)
      
      So we rely on the same mechanism as for the backup of the other dirstate file:
      - we only do a backup if we hold the wlock
      - we force a backup though the transaction
      
      
      Since "branch" write does not collaborate with the transaction, we cannot back
      it up "at the last minute" as we do for the dirstate. We have to back it up
      "upfront". Since we have a backup, the transaction is no longer doing its
      "quick_abort" and get noisy. Which is quite annoying. To work around this, and
      to avoid jumping in yet-another-rabbit-hole of "getting branch written
      properly", I am doing horrible things to the transaction in the meantime.
      We should be able to get this code go away during the next cycle.
      
      In the meantime, I prefer to take this small stop so that we stop abusing the
      "journal" and "undo" mechanism instead of the proper backup mechanism of the
      transaction.
      
      
      Also note that this change regress the warning message for the legacy fallback
      introduced in 2008 when issue902 got fixed in dd5a501cb97f (Mercurial 1.0).
      
      I feel like this is fine as issue 902 remains fixed, and this would only affect
      people deploying a mix of 15 year old Mercurial and modern mercurial, and using
      branch and rollback extensively.
      2b097e8a
  2. Feb 23, 2023
  3. Feb 22, 2023
  4. Feb 23, 2023
  5. Feb 22, 2023
  6. Feb 23, 2023
  7. Feb 22, 2023
  8. Feb 17, 2023
  9. Feb 16, 2023
  10. Feb 20, 2023
  11. Feb 21, 2023
  12. Feb 19, 2023
  13. Feb 22, 2023
  14. Feb 21, 2023
  15. Feb 20, 2023
Loading