Skip to content
Snippets Groups Projects
  1. Apr 21, 2020
    • Pierre-Yves David's avatar
      copies-rust: use immutable "OrdMap" to store copies information · 2ca7f7578d9b
      Pierre-Yves David authored
      The large majority of time is currently spent coping and merging directories.
      the `IM` crate offer "immutable" Map, that use "copy on write" internally.  The
      new object use the same API as the standard HashMap.  So switching to it is
      trivial and it reduce copying cost significantly. More importantly, using
      immutable structure will unlock new possibility for a massive speed up of the
      "merging" part. This will came in a later changesets.
      
      Performance wise, we get very significant boost in the worst case. Below is some
      highlight of how we fare compared to the previous changeset.
      
      Repo            Cases                                 Source-Rev   Dest-Rev         Old-Time      New-Time     Difference   Factor
      ------------------------------------------------------------------------------------------------------------------------------------
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :  62.468362 s,  33.527067 s, -28.941295 s, × 0.5367
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :   3.619850 s,   0.963905 s,  -2.655945 s, × 0.2663
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :  11.926587 s,   4.217003 s,  -7.709584 s, × 0.3536
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 :  10.674920 s,   1.114864 s,  -9.560056 s, × 0.1044
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c :  19.647038 s,   1.442793 s, -18.204245 s, × 0.0734
      
      
      And we sometimes catch up with the performance of the python code as highlighted
      below:
      
      Repo            Cases                                 Source-Rev   Dest-Rev         Py-time       Rust-time    Difference   Factor
      ------------------------------------------------------------------------------------------------------------------------------------
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c :   1.074593 s,   1.442793 s,  +0.368200 s, × 1.3426
      
      However, multiple case remains significantly slower, as highlighted below
      
      Repo            Cases                                 Source-Rev   Dest-Rev         Py-time       Rust-time    Difference   Factor
      ------------------------------------------------------------------------------------------------------------------------------------
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :   0.190133 s,   0.963905 s,  +0.773772 s, × 5.0696
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :   0.440694 s,   4.217003 s,  +3.776309 s, × 9.5690
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 :   0.370675 s,   1.114864 s,  +0.744189 s, × 3.0077
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :   3.581556 s,  33.527067 s, +29.945511 s, × 9.3610
      
      Below are two different tables for full performance comparison
      - this changeset against the previous one (spoiler: it is much better)
      - this changeset against the python code  (spoiler: still slower, but it gets more comparable)
      
      This changeset compared to the previous one
      ===========================================
      
      Repo            Cases                                 Source-Rev   Dest-Rev         Old-Time      New-Time     Difference   Factor
      ------------------------------------------------------------------------------------------------------------------------------------
      mercurial       x_revs_x_added_0_copies               ad6b123de1c7 39cfcef4f463 :   0.000046 s,   0.000049 s,  +0.000003 s, × 1.0652
      mercurial       x_revs_x_added_x_copies               2b1c78674230 0c1d10351869 :   0.000173 s,   0.000179 s,  +0.000006 s, × 1.0347
      mercurial       x000_revs_x000_added_x_copies         81f8ff2a9bf2 dd3267698d84 :   0.006303 s,   0.006494 s,  +0.000191 s, × 1.0303
      pypy            x_revs_x_added_0_copies               aed021ee8ae8 099ed31b181b :   0.000229 s,   0.000339 s,  +0.000110 s, × 1.4803
      pypy            x_revs_x000_added_0_copies            4aa4e1f8e19a 359343b9ac0e :   0.000056 s,   0.000057 s,  +0.000001 s, × 1.0179
      pypy            x_revs_x_added_x_copies               ac52eb7bbbb0 72e022663155 :   0.000143 s,   0.000299 s,  +0.000156 s, × 2.0909
      pypy            x_revs_x00_added_x_copies             c3b14617fbd7 ace7255d9a26 :   0.001166 s,   0.001200 s,  +0.000034 s, × 1.0292
      pypy            x_revs_x000_added_x000_copies         df6f7a526b60 a83dc6a2d56f :   0.022931 s,   0.025120 s,  +0.002189 s, × 1.0955
      pypy            x000_revs_xx00_added_0_copies         89a76aede314 2f22446ff07e :   0.852446 s,   0.506921 s,  -0.345525 s, × 0.5947
      pypy            x000_revs_x000_added_x_copies         8a3b5bfd266e 2c68e87c3efe :   2.221824 s,   1.272060 s,  -0.949764 s, × 0.5725
      pypy            x000_revs_x000_added_x000_copies      89a76aede314 7b3dda341c84 :   1.194162 s,   0.690941 s,  -0.503221 s, × 0.5786
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :  62.468362 s,  33.527067 s, -28.941295 s, × 0.5367
      pypy            x0000_revs_xx000_added_0_copies       bf2c629d0071 4ffed77c095c :   0.022116 s,   0.021970 s,  -0.000146 s, × 0.9934
      pypy            x0000_revs_xx000_added_x000_copies    08ea3258278e d9fa043f30c0 :   2.972788 s,   1.772094 s,  -1.200694 s, × 0.5961
      netbeans        x_revs_x_added_0_copies               fb0955ffcbcd a01e9239f9e7 :   0.000180 s,   0.000185 s,  +0.000005 s, × 1.0278
      netbeans        x_revs_x000_added_0_copies            6f360122949f 20eb231cc7d0 :   0.000123 s,   0.000135 s,  +0.000012 s, × 1.0976
      netbeans        x_revs_x_added_x_copies               1ada3faf6fb6 5a39d12eecf4 :   0.000315 s,   0.000329 s,  +0.000014 s, × 1.0444
      netbeans        x_revs_x00_added_x_copies             35be93ba1e2c 9eec5e90c05f :   0.001297 s,   0.001343 s,  +0.000046 s, × 1.0355
      netbeans        x000_revs_xx00_added_0_copies         eac3045b4fdd 51d4ae7f1290 :   0.024884 s,   0.029396 s,  +0.004512 s, × 1.1813
      netbeans        x000_revs_x000_added_x_copies         e2063d266acd 6081d72689dc :   0.032653 s,   0.040210 s,  +0.007557 s, × 1.2314
      netbeans        x000_revs_x000_added_x000_copies      ff453e9fee32 411350406ec2 :   4.230118 s,   4.556794 s,  +0.326676 s, × 1.0772
      mozilla-central x_revs_x_added_0_copies               3697f962bb7b 7015fcdd43a2 :   0.000197 s,   0.000199 s,  +0.000002 s, × 1.0102
      mozilla-central x_revs_x000_added_0_copies            dd390860c6c9 40d0c5bed75d :   0.000622 s,   0.000639 s,  +0.000017 s, × 1.0273
      mozilla-central x_revs_x_added_x_copies               8d198483ae3b 14207ffc2b2f :   0.000296 s,   0.000542 s,  +0.000246 s, × 1.8311
      mozilla-central x_revs_x00_added_x_copies             98cbc58cc6bc 446a150332c3 :   0.001626 s,   0.001685 s,  +0.000059 s, × 1.0363
      mozilla-central x_revs_x000_added_x000_copies         3c684b4b8f68 0a5e72d1b479 :   0.006218 s,   0.006954 s,  +0.000736 s, × 1.1184
      mozilla-central x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.132760 s,   0.132938 s,  +0.000178 s, × 1.0013
      mozilla-central x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.029001 s,   0.008683 s,  -0.020318 s, × 0.2994
      mozilla-central x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.005886 s,   0.005956 s,  +0.000070 s, × 1.0119
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :   3.619850 s,   0.963905 s,  -2.655945 s, × 0.2663
      mozilla-central x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.058678 s,   0.049239 s,  -0.009439 s, × 0.8391
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :  11.926587 s,   4.217003 s,  -7.709584 s, × 0.3536
      mozilla-try     x_revs_x_added_0_copies               aaf6dde0deb8 9790f499805a :   0.001204 s,   0.001197 s,  -0.000007 s, × 0.9942
      mozilla-try     x_revs_x000_added_0_copies            d8d0222927b4 5bb8ce8c7450 :   0.001217 s,   0.001213 s,  -0.000004 s, × 0.9967
      mozilla-try     x_revs_x_added_x_copies               092fcca11bdb 936255a0384a :   0.000605 s,   0.000762 s,  +0.000157 s, × 1.2595
      mozilla-try     x_revs_x00_added_x_copies             b53d2fadbdb5 017afae788ec :   0.001876 s,   0.001909 s,  +0.000033 s, × 1.0176
      mozilla-try     x_revs_x000_added_x000_copies         20408ad61ce5 6f0ee96e21ad :   0.078190 s,   0.093021 s,  +0.014831 s, × 1.1897
      mozilla-try     x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.135428 s,   0.134536 s,  -0.000892 s, × 0.9934
      mozilla-try     x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.029123 s,   0.009071 s,  -0.020052 s, × 0.3115
      mozilla-try     x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.006141 s,   0.006206 s,  +0.000065 s, × 1.0106
      mozilla-try     x000_revs_x000_added_x000_copies      1346fd0130e4 4c65cbdabc1f :   4.857827 s,   1.150502 s,  -3.707325 s, × 0.2368
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 :  10.674920 s,   1.114864 s,  -9.560056 s, × 0.1044
      mozilla-try     x0000_revs_x_added_x_copies           9fe69ff0762d bcabf2a78927 :   9.789462 s,   1.042658 s,  -8.746804 s, × 0.1065
      mozilla-try     x0000_revs_xx000_added_x_copies       156f6e2674f2 4d0f2c178e66 :   1.087890 s,   0.447402 s,  -0.640488 s, × 0.4113
      mozilla-try     x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.060556 s,   0.051132 s,  -0.009424 s, × 0.8444
      mozilla-try     x0000_revs_xx000_added_x000_copies    89294cd501d9 7ccb2fc7ccb5 : killed         ,  83.508590 s
      mozilla-try     x0000_revs_x0000_added_x0000_copies   e928c65095ed e951f4ad123a : killed         ,  55.079813 s
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c :  19.647038 s,   1.442793 s, -18.204245 s, × 0.0734
      
      
      This changeset compared to the Python Code
      ==========================================
      
      
      Repo            Cases                                 Source-Rev   Dest-Rev         Py-time       Rust-time    Difference   Factor
      ------------------------------------------------------------------------------------------------------------------------------------
      mercurial       x_revs_x_added_0_copies               ad6b123de1c7 39cfcef4f463 :   0.000044 s,   0.000049 s,  +0.000005 s, × 1.1136
      mercurial       x_revs_x_added_x_copies               2b1c78674230 0c1d10351869 :   0.000138 s,   0.000179 s,  +0.000041 s, × 1.2971
      mercurial       x000_revs_x000_added_x_copies         81f8ff2a9bf2 dd3267698d84 :   0.005052 s,   0.006494 s,  +0.001442 s, × 1.2854
      pypy            x_revs_x_added_0_copies               aed021ee8ae8 099ed31b181b :   0.000219 s,   0.000339 s,  +0.000120 s, × 1.5479
      pypy            x_revs_x000_added_0_copies            4aa4e1f8e19a 359343b9ac0e :   0.000055 s,   0.000057 s,  +0.000002 s, × 1.0364
      pypy            x_revs_x_added_x_copies               ac52eb7bbbb0 72e022663155 :   0.000128 s,   0.000299 s,  +0.000171 s, × 2.3359
      pypy            x_revs_x00_added_x_copies             c3b14617fbd7 ace7255d9a26 :   0.001089 s,   0.001200 s,  +0.000111 s, × 1.1019
      pypy            x_revs_x000_added_x000_copies         df6f7a526b60 a83dc6a2d56f :   0.017407 s,   0.025120 s,  +0.007713 s, × 1.4431
      pypy            x000_revs_xx00_added_0_copies         89a76aede314 2f22446ff07e :   0.094175 s,   0.506921 s,  +0.412746 s, × 5.3828
      pypy            x000_revs_x000_added_x_copies         8a3b5bfd266e 2c68e87c3efe :   0.238009 s,   1.272060 s,  +1.034051 s, × 5.3446
      pypy            x000_revs_x000_added_x000_copies      89a76aede314 7b3dda341c84 :   0.125876 s,   0.690941 s,  +0.565065 s, × 5.4891
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :   3.581556 s,  33.527067 s, +29.945511 s, × 9.3610
      pypy            x0000_revs_xx000_added_0_copies       bf2c629d0071 4ffed77c095c :   0.016721 s,   0.021970 s,  +0.005249 s, × 1.3139
      pypy            x0000_revs_xx000_added_x000_copies    08ea3258278e d9fa043f30c0 :   0.242367 s,   1.772094 s,  +1.529727 s, × 7.3116
      netbeans        x_revs_x_added_0_copies               fb0955ffcbcd a01e9239f9e7 :   0.000165 s,   0.000185 s,  +0.000020 s, × 1.1212
      netbeans        x_revs_x000_added_0_copies            6f360122949f 20eb231cc7d0 :   0.000114 s,   0.000135 s,  +0.000021 s, × 1.1842
      netbeans        x_revs_x_added_x_copies               1ada3faf6fb6 5a39d12eecf4 :   0.000296 s,   0.000329 s,  +0.000033 s, × 1.1115
      netbeans        x_revs_x00_added_x_copies             35be93ba1e2c 9eec5e90c05f :   0.001124 s,   0.001343 s,  +0.000219 s, × 1.1948
      netbeans        x000_revs_xx00_added_0_copies         eac3045b4fdd 51d4ae7f1290 :   0.013060 s,   0.029396 s,  +0.016336 s, × 2.2508
      netbeans        x000_revs_x000_added_x_copies         e2063d266acd 6081d72689dc :   0.017112 s,   0.040210 s,  +0.023098 s, × 2.3498
      netbeans        x000_revs_x000_added_x000_copies      ff453e9fee32 411350406ec2 :   0.660350 s,   4.556794 s,  +3.896444 s, × 6.9006
      netbeans        x0000_revs_xx000_added_x000_copies    588c2d1ced70 1aad62e59ddd :  10.032499 s, killed
      mozilla-central x_revs_x_added_0_copies               3697f962bb7b 7015fcdd43a2 :   0.000189 s,   0.000199 s,  +0.000010 s, × 1.0529
      mozilla-central x_revs_x000_added_0_copies            dd390860c6c9 40d0c5bed75d :   0.000462 s,   0.000639 s,  +0.000177 s, × 1.3831
      mozilla-central x_revs_x_added_x_copies               8d198483ae3b 14207ffc2b2f :   0.000270 s,   0.000542 s,  +0.000272 s, × 2.0074
      mozilla-central x_revs_x00_added_x_copies             98cbc58cc6bc 446a150332c3 :   0.001474 s,   0.001685 s,  +0.000211 s, × 1.1431
      mozilla-central x_revs_x000_added_x000_copies         3c684b4b8f68 0a5e72d1b479 :   0.004806 s,   0.006954 s,  +0.002148 s, × 1.4469
      mozilla-central x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.085150 s,   0.132938 s,  +0.047788 s, × 1.5612
      mozilla-central x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.007064 s,   0.008683 s,  +0.001619 s, × 1.2292
      mozilla-central x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.004741 s,   0.005956 s,  +0.001215 s, × 1.2563
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :   0.190133 s,   0.963905 s,  +0.773772 s, × 5.0696
      mozilla-central x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.035651 s,   0.049239 s,  +0.013588 s, × 1.3811
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :   0.440694 s,   4.217003 s,  +3.776309 s, × 9.5690
      mozilla-central x00000_revs_x0000_added_x0000_copies  6832ae71433c 4c222a1d9a00 :  18.454163 s, killed
      mozilla-central x00000_revs_x00000_added_x000_copies  76caed42cf7c 1daa622bbe42 :  31.562719 s, killed
      mozilla-try     x_revs_x_added_0_copies               aaf6dde0deb8 9790f499805a :   0.001189 s,   0.001197 s,  +0.000008 s, × 1.0067
      mozilla-try     x_revs_x000_added_0_copies            d8d0222927b4 5bb8ce8c7450 :   0.001204 s,   0.001213 s,  +0.000009 s, × 1.0075
      mozilla-try     x_revs_x_added_x_copies               092fcca11bdb 936255a0384a :   0.000586 s,   0.000762 s,  +0.000176 s, × 1.3003
      mozilla-try     x_revs_x00_added_x_copies             b53d2fadbdb5 017afae788ec :   0.001845 s,   0.001909 s,  +0.000064 s, × 1.0347
      mozilla-try     x_revs_x000_added_x000_copies         20408ad61ce5 6f0ee96e21ad :   0.063822 s,   0.093021 s,  +0.029199 s, × 1.4575
      mozilla-try     x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.088038 s,   0.134536 s,  +0.046498 s, × 1.5282
      mozilla-try     x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.007389 s,   0.009071 s,  +0.001682 s, × 1.2276
      mozilla-try     x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.004868 s,   0.006206 s,  +0.001338 s, × 1.2749
      mozilla-try     x000_revs_x000_added_x000_copies      1346fd0130e4 4c65cbdabc1f :   0.222450 s,   1.150502 s,  +0.928052 s, × 5.1720
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 :   0.370675 s,   1.114864 s,  +0.744189 s, × 3.0077
      mozilla-try     x0000_revs_x_added_x_copies           9fe69ff0762d bcabf2a78927 :   0.358020 s,   1.042658 s,  +0.684638 s, × 2.9123
      mozilla-try     x0000_revs_xx000_added_x_copies       156f6e2674f2 4d0f2c178e66 :   0.145235 s,   0.447402 s,  +0.302167 s, × 3.0805
      mozilla-try     x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.037606 s,   0.051132 s,  +0.013526 s, × 1.3597
      mozilla-try     x0000_revs_xx000_added_x000_copies    89294cd501d9 7ccb2fc7ccb5 :   7.382439 s,  83.508590 s, +76.126151 s, × 11.3118
      mozilla-try     x0000_revs_x0000_added_x0000_copies   e928c65095ed e951f4ad123a :   7.273506 s,  55.079813 s, +47.806307 s, × 7.5727
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c :   1.074593 s,   1.442793 s,  +0.368200 s, × 1.3426
      mozilla-try     x00000_revs_x0000_added_x0000_copies  8d3fafa80d4b eb884023b810 :  27.746195 s, killed
      
      Differential Revision: https://phab.mercurial-scm.org/D9300
      2ca7f7578d9b
  2. Oct 01, 2020
    • Pierre-Yves David's avatar
      copies: use the rust code for `combine_changeset_copies` · 2da61c32131d
      Pierre-Yves David authored
      Changeset centric copy tracing now use the rust code. The rust code focussed on
      simplicity and will be optimised later. So the performance is not great yet. Now
      that all the pieces are in place we can start working on performance in the
      coming changesets.
      
      Below is a table that summarize how slower we got:
      
      Repo            Cases                                 Source-Rev   Dest-Rev         Py-time       Rust-time    Difference   Factor
      ------------------------------------------------------------------------------------------------------------------------------------
      mercurial       x_revs_x_added_0_copies               ad6b123de1c7 39cfcef4f463 :   0.000049 s,   0.000046 s,  -0.000003 s, × 0.9388
      mercurial       x_revs_x_added_x_copies               2b1c78674230 0c1d10351869 :   0.000112 s,   0.000173 s,  +0.000061 s, × 1.5446
      mercurial       x000_revs_x000_added_x_copies         81f8ff2a9bf2 dd3267698d84 :   0.004216 s,   0.006303 s,  +0.002087 s, × 1.4950
      pypy            x_revs_x_added_0_copies               aed021ee8ae8 099ed31b181b :   0.000204 s,   0.000229 s,  +0.000025 s, × 1.1225
      pypy            x_revs_x000_added_0_copies            4aa4e1f8e19a 359343b9ac0e :   0.000058 s,   0.000056 s,  -0.000002 s, × 0.9655
      pypy            x_revs_x_added_x_copies               ac52eb7bbbb0 72e022663155 :   0.000112 s,   0.000143 s,  +0.000031 s, × 1.2768
      pypy            x_revs_x00_added_x_copies             c3b14617fbd7 ace7255d9a26 :   0.000339 s,   0.001166 s,  +0.000827 s, × 3.4395
      pypy            x_revs_x000_added_x000_copies         df6f7a526b60 a83dc6a2d56f :   0.010214 s,   0.022931 s,  +0.012717 s, × 2.2451
      pypy            x000_revs_xx00_added_0_copies         89a76aede314 2f22446ff07e :   0.047497 s,   0.852446 s,  +0.804949 s, × 17.9474
      pypy            x000_revs_x000_added_x_copies         8a3b5bfd266e 2c68e87c3efe :   0.075297 s,   2.221824 s,  +2.146527 s, × 29.5075
      pypy            x000_revs_x000_added_x000_copies      89a76aede314 7b3dda341c84 :   0.057322 s,   1.194162 s,  +1.136840 s, × 20.8325
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :   0.796264 s,  62.468362 s, +61.672098 s, × 78.4518
      pypy            x0000_revs_xx000_added_0_copies       bf2c629d0071 4ffed77c095c :   0.020491 s,   0.022116 s,  +0.001625 s, × 1.0793
      pypy            x0000_revs_xx000_added_x000_copies    08ea3258278e d9fa043f30c0 :   0.121612 s,   2.972788 s,  +2.851176 s, × 24.4449
      netbeans        x_revs_x_added_0_copies               fb0955ffcbcd a01e9239f9e7 :   0.000143 s,   0.000180 s,  +0.000037 s, × 1.2587
      netbeans        x_revs_x000_added_0_copies            6f360122949f 20eb231cc7d0 :   0.000112 s,   0.000123 s,  +0.000011 s, × 1.0982
      netbeans        x_revs_x_added_x_copies               1ada3faf6fb6 5a39d12eecf4 :   0.000232 s,   0.000315 s,  +0.000083 s, × 1.3578
      netbeans        x_revs_x00_added_x_copies             35be93ba1e2c 9eec5e90c05f :   0.000721 s,   0.001297 s,  +0.000576 s, × 1.7989
      netbeans        x000_revs_xx00_added_0_copies         eac3045b4fdd 51d4ae7f1290 :   0.010115 s,   0.024884 s,  +0.014769 s, × 2.4601
      netbeans        x000_revs_x000_added_x_copies         e2063d266acd 6081d72689dc :   0.015461 s,   0.032653 s,  +0.017192 s, × 2.1120
      netbeans        x000_revs_x000_added_x000_copies      ff453e9fee32 411350406ec2 :   0.060756 s,   4.230118 s,  +4.169362 s, × 69.6247
      netbeans        x0000_revs_xx000_added_x000_copies    588c2d1ced70 1aad62e59ddd :   0.605842 s, killed
      mozilla-central x_revs_x_added_0_copies               3697f962bb7b 7015fcdd43a2 :   0.000164 s,   0.000197 s,  +0.000033 s, × 1.2012
      mozilla-central x_revs_x000_added_0_copies            dd390860c6c9 40d0c5bed75d :   0.000331 s,   0.000622 s,  +0.000291 s, × 1.8792
      mozilla-central x_revs_x_added_x_copies               8d198483ae3b 14207ffc2b2f :   0.000249 s,   0.000296 s,  +0.000047 s, × 1.1888
      mozilla-central x_revs_x00_added_x_copies             98cbc58cc6bc 446a150332c3 :   0.000711 s,   0.001626 s,  +0.000915 s, × 2.2869
      mozilla-central x_revs_x000_added_x000_copies         3c684b4b8f68 0a5e72d1b479 :   0.003438 s,   0.006218 s,  +0.002780 s, × 1.8086
      mozilla-central x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.069869 s,   0.132760 s,  +0.062891 s, × 1.9001
      mozilla-central x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.005701 s,   0.029001 s,  +0.023300 s, × 5.0870
      mozilla-central x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.005757 s,   0.005886 s,  +0.000129 s, × 1.0224
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :   0.061826 s,   3.619850 s,  +3.558024 s, × 58.5490
      mozilla-central x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.043354 s,   0.058678 s,  +0.015324 s, × 1.3535
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :   0.198979 s,  11.926587 s, +11.727608 s, × 59.9389
      mozilla-central x00000_revs_x0000_added_x0000_copies  6832ae71433c 4c222a1d9a00 :   2.067096 s, killed
      mozilla-central x00000_revs_x00000_added_x000_copies  76caed42cf7c 1daa622bbe42 :   3.102616 s, killed
      mozilla-try     x_revs_x_added_0_copies               aaf6dde0deb8 9790f499805a :   0.001212 s,   0.001204 s,  -0.000008 s, × 0.9934
      mozilla-try     x_revs_x000_added_0_copies            d8d0222927b4 5bb8ce8c7450 :   0.001237 s,   0.001217 s,  -0.000020 s, × 0.9838
      mozilla-try     x_revs_x_added_x_copies               092fcca11bdb 936255a0384a :   0.000557 s,   0.000605 s,  +0.000048 s, × 1.0862
      mozilla-try     x_revs_x00_added_x_copies             b53d2fadbdb5 017afae788ec :   0.001532 s,   0.001876 s,  +0.000344 s, × 1.2245
      mozilla-try     x_revs_x000_added_x000_copies         20408ad61ce5 6f0ee96e21ad :   0.035166 s,   0.078190 s,  +0.043024 s, × 2.2235
      mozilla-try     x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :   0.070336 s,   0.135428 s,  +0.065092 s, × 1.9254
      mozilla-try     x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   0.006080 s,   0.029123 s,  +0.023043 s, × 4.7900
      mozilla-try     x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :   0.006099 s,   0.006141 s,  +0.000042 s, × 1.0069
      mozilla-try     x000_revs_x000_added_x000_copies      1346fd0130e4 4c65cbdabc1f :   0.064317 s,   4.857827 s,  +4.793510 s, × 75.5294
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 :   0.303263 s,  10.674920 s, +10.371657 s, × 35.2002
      mozilla-try     x0000_revs_x_added_x_copies           9fe69ff0762d bcabf2a78927 :   0.292804 s,   9.789462 s,  +9.496658 s, × 33.4335
      mozilla-try     x0000_revs_xx000_added_x_copies       156f6e2674f2 4d0f2c178e66 :   0.107594 s,   1.087890 s,  +0.980296 s, × 10.1111
      mozilla-try     x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :   0.045202 s,   0.060556 s,  +0.015354 s, × 1.3397
      mozilla-try     x0000_revs_xx000_added_x000_copies    89294cd501d9 7ccb2fc7ccb5 :   1.926277 s, killed
      mozilla-try     x0000_revs_x0000_added_x0000_copies   e928c65095ed e951f4ad123a :   0.794492 s, killed
      mozilla-try     x00000_revs_x_added_0_copies          6a320851d377 1ebb79acd503 :  84.521497 s, killed
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c :   0.965937 s,  19.647038 s, +18.681101 s, × 20.3399
      mozilla-try     x00000_revs_x_added_x_copies          5173c4b6f97c 95d83ee7242d :  83.367146 s, killed
      mozilla-try     x00000_revs_x000_added_x_copies       9126823d0e9c ca82787bb23c :  84.260895 s, killed
      mozilla-try     x00000_revs_x0000_added_x0000_copies  8d3fafa80d4b eb884023b810 :   3.274537 s, killed
      mozilla-try     x00000_revs_x00000_added_x0000_copies 1b661134e2ca 1ae03d022d6d :  42.235843 s, killed
      mozilla-try     x00000_revs_x00000_added_x000_copies  9b2a99adc05e 8e29777b48e6 :  49.872829 s, killed
      
      Differential Revision: https://phab.mercurial-scm.org/D9299
      2da61c32131d
    • Pierre-Yves David's avatar
      copies: introduce the hg-cpython wrapper for `combine_changeset_copies` · 50c5ee3bdf9a
      Pierre-Yves David authored
      This patch focus on the `hg-cpython` part of this work. Bridging the python code
      with the new rust code in `hg-core`. The next patch will actually plug this in
      the python code.
      
      The rust code use multiple Python callback, python related error within this
      callback are not expected unless they are a programming error or a data
      corruption. In addition, these callback will slowly be replaced by native Rust
      code. For these reasons, we use will deal with unexpected error within this
      callback using rust Panic and let the `rust-cpython` layer deal with raising a
      Python exception.
      
      The code dealing with the ChangedFile instance is repeating itself a lot. I did
      not factor these duplication out because that whole code will get replaced by
      entirely different one in a handful of changesets.
      
      Differential Revision: https://phab.mercurial-scm.org/D9298
      50c5ee3bdf9a
    • Pierre-Yves David's avatar
      copies: introduce a basic Rust function for `combine_changeset_copies` · 595979dc924e
      Pierre-Yves David authored
      This new function mirror the python code.  This first implementation does a lot
      of data copies and is therefore quite slow. However my goal here is to create a
      simple "frame" from where to start adding optimization.
      
      This patch focus on the `hg-core` part of this work. Coming patches will do the
      necessary `hg-cpython` work  to be able to use this from Python.
      
      Differential Revision: https://phab.mercurial-scm.org/D9297
      595979dc924e
  3. Nov 27, 2020
  4. Nov 25, 2020
  5. Nov 24, 2020
  6. Oct 06, 2020
  7. Nov 11, 2020
    • Mathias De Mare's avatar
      packaging: enable rust extensions on centos · eccbfa7e19c0
      Mathias De Mare authored
      Test on CentOS 7, repository with ~170000 tracked files,
          no untracked files:
      10 runs with this enabled:
       -- Run #0 time: 0.6519973278045654
       -- Run #1 time: 0.6933724880218506
       -- Run #2 time: 0.7512078285217285
       -- Run #3 time: 0.7517638206481934
       -- Run #4 time: 0.5966529846191406
       -- Run #5 time: 0.5960886478424072
       -- Run #6 time: 0.5940573215484619
       -- Run #7 time: 0.5963726043701172
       -- Run #8 time: 0.6048009395599365
       -- Run #9 time: 0.603604793548584
      
      10 runs without this enabled:
       -- Run #0 time: 2.127584457397461
       -- Run #1 time: 2.066192865371704
       -- Run #2 time: 2.0831892490386963
       -- Run #3 time: 2.077716588973999
       -- Run #4 time: 2.07608962059021
       -- Run #5 time: 2.072899341583252
       -- Run #6 time: 2.094369888305664
       -- Run #7 time: 2.067504644393921
       -- Run #8 time: 2.069610834121704
       -- Run #9 time: 2.0567898750305176
      
      Differential Revision: https://phab.mercurial-scm.org/D9294
      eccbfa7e19c0
  8. Nov 22, 2020
  9. Nov 21, 2020
    • Matt Harbison's avatar
      setup: copy pythonXY.dll next to the hg.exe wrapper when building · 2960b7fac966
      Matt Harbison authored
      This avoids the problem of having the newly built binary complaining that it
      can't find the DLL.  There is an option in the python.org installer to add the
      python install to PATH (which defaulted to "on" with py2, and therefore was not
      an issue up to this point), but that makes switching between python versions
      harder.
      
      This shouldn't be an issue with the PyOxidizer binary, but that current has
      issues running some of the tests, and took noticeably longer to build last time
      I tried it.
      
      Differential Revision: https://phab.mercurial-scm.org/D9362
      2960b7fac966
  10. Nov 22, 2020
  11. Nov 23, 2020
    • Matt Harbison's avatar
      ui: ensure `getpass()` returns bytes · 87e7dd8e7734
      Matt Harbison authored
      Previously, this could return either bytes or str.  I'm not sure which direction
      we should go in, but since the input is bytes, I guess bytes makes sense as
      output.  `debuguigetpass` crashed because it assumed bytes would be returned,
      `sslcontext.load_cert_chain()` is happy with bytes or str if the type info in
      PyCharm is correct, and `smtplib.SMTP.login()` wants str.
      
      I couldn't figure out how to test this, because the test stalls for input with
      `echo test | hg debuguigetpass --config ui.interactive=1`, likely because it
      drains stdin before prompting.  The custom input reading with `ui.nontty=1` does
      not.
      
      I'm also a bit concerned with all of this encoding/decoding.  The existing code
      in the mail module uses `encoding.strfromlocal()`, but the username and password
      are ascii encoded/decoded in `mercurial.url.passwordmgr.find_user_password()`
      with `pycompat.{str,bytes}url()`.  I'm not sure if this inconsistency could
      cause subtle compatability issues.
      
      Differential Revision: https://phab.mercurial-scm.org/D9375
      87e7dd8e7734
  12. Nov 26, 2020
  13. Nov 24, 2020
  14. Nov 25, 2020
  15. Nov 21, 2020
  16. Nov 20, 2020
  17. Oct 16, 2020
  18. Nov 23, 2020
  19. Nov 24, 2020
  20. Nov 18, 2020
  21. Nov 23, 2020
Loading