Skip to content
Snippets Groups Projects
  1. Jun 29, 2013
  2. Jul 04, 2013
    • Alexander Plavin's avatar
      hgweb: color line which is linked to in file source view · 41c4bdd1
      Alexander Plavin authored
      Browser compatibility (':target' selector used): IE 8+, FF 3.5+, Safari 3.1+,
      Opera 9.5+, Chromium 4+, all popular mobile browsers.
      41c4bdd1
    • Alexander Plavin's avatar
      hgweb: wrap lines in file source view · 7f0a3074
      Alexander Plavin authored
      7f0a3074
    • Alexander Plavin's avatar
      hgweb: code selection without line numbers in file source view · f2e4fdb3
      Alexander Plavin authored
      All the source lines are put in a <pre> tag, which gives correct display and
      copy&paste in both Chromium (WebKit) and FireFox: line numbers are not copied,
      all the tabs and spaces are kept. This doesn't change the visual appearance
      of the view compared to current hgweb version and doesn't use any JS code.
      Also, stripes in this view are now generated clientside with CSS.
      
      This implementation is chosen because other variants have important issues:
      
      Strategy             FF              Chrome
      
      current             D,LT,E,T,L        D,L
      pre                 S,NW              S,NW
      pre/div/nbsp        LT,E,T,TS,NW      TS,NW
      pre/div/br          LT,E,T,NW         NW
      ol/li/nbsp          LT,E,T,TS,AJ      TS,AJ
      ol/li/br            LT,E,T,AJ         AJ
      pre/span            LV                LV
      
      Legend
      
      Strategies:
      - current: implemented in hgweb before this patch, i.e. divs for each line,
      and line numbers links in the div too
      - pre: the whole code in one pre tag with newlines, all line numbers
      in another one with 'float: left'
      - pre/div/{nbsp,br}: same as just 'pre', but separate divs for each line and
      &nbsp; or <br> instead of empty lines (otherwise they are not copied at all)
      - ol/li/{nbsp,br}: a single ol with li's and divs for each line,
      &nbsp; or <br> same as in previous strategy
      - pre/span: this patch
      
      Problems:
      D = (very minor) display problems, like wrong width of leading tabs
      LT = loses leading/trailing whitespace
      E = loses embedded whitespace
      B = loses blank lines
      T = loses tabs
      L = selects line numbers
      LV = (only) visually selects line numbers
      LVE = (only) visually selects line numbers at empty lines
      S = no stripes (and no ability to easily highlight
      lines-which-are-linked-at in the future)
      TS = space copied instead of empty line
      AJ = get anchor links only with JS (they work even without)
      NW = no linewrap easily possible (in future)
      
      As for browser versions compatibility, the CSS tricks used are supported in
      (according to caniuse.com):
      a) line numbers generation with 'content:' property and CSS counters:
      IE 8+, all other popular browsers (in pre-WebKit Opera numbers are being copied)
      b) stripes ('nth-child' selector):
      IE 8+, FF 3.5+, Safari 3.2+, Opera 9.5+, all other popular browsers
      c) line numbers are not visually selected ('user-select:' property):
      IE 10+, Opera 15.0+, all other popular browsers
      
      This patch is based on a demo implementation by
      Martin Geisler <martin@geisler.net>.
      f2e4fdb3
  3. Jul 06, 2013
  4. Jul 04, 2013
  5. Jul 01, 2013
    • Simon Heimberg's avatar
      check-code: concatenate "check-code" on compile time · 5aeb03b4
      Simon Heimberg authored
      The python compiler concatenates two string constants. Use this instead of
      doing it on run time or instruct the user how to do it.
      The strings "no-check-code" and "check-code-ignore" has to be specially written
      for not skipping some checking of the code of this file.
      5aeb03b4
    • Simon Heimberg's avatar
      tests: do not skip code-checking on some whole files · e033a7d4
      Simon Heimberg authored
      In filterpyflakes the term no-check-code was probably by accident.
      In the test the intention was not to skip the entire file but only one
      line. But any skipping seems to be unnecessary since a longer time.
      e033a7d4
    • Simon Heimberg's avatar
      check-code: do not warn on printf \\x or \\[1-9] · ee07f9d1
      Simon Heimberg authored
      When there is a double backslash the following char does not have any special
      meaning. So do not warn on this.
      Remove the now obsolete no-check-code statement. (It was used wrongly anyway, it
      skipped checking the entire file.)
      ee07f9d1
  6. Nov 05, 2012
  7. Jul 01, 2013
  8. Jul 09, 2013
  9. Jul 01, 2013
  10. Jun 30, 2013
  11. Jun 25, 2013
Loading