Skip to content
Snippets Groups Projects
  1. Oct 10, 2019
    • Georges Racinet's avatar
      py3-discovery: using plain str in stats dict · 3c6976b1
      Georges Racinet authored
      rust-cpython converts automatically from Rust strings to
      the appropriate `str` for the target Python version.
      
      Insisting on discovery stats dict keys to be bytes hence breaks
      the process (this is spotted by test-setdiscovery.t).
      
      Now that byteify-strings has been run on the entire
      codebase, and the import transformer is not there any more,
      the simplest fix is to make the keys plain str again.
      
      Another possible fix would be to forcefully convert to bytes in
      rust-cpython code, but that feels less natural, and would probably
      have to be reverted down the road.
      
      Differential Revision: https://phab.mercurial-scm.org/D7039
      3c6976b1
    • Pierre-Yves David's avatar
      perf: fix `perfhelper-mergecopies` report of #changesets · 9d57c2df
      Pierre-Yves David authored
      Same as `perfhelper-pathcopies`. The previous computation `<base>::<target>` was
      wrong, what we actually need is `::<target> - ::<base>`.
      
      This is now fixed.
      9d57c2df
  2. Oct 02, 2019
  3. Oct 10, 2019
  4. Aug 29, 2019
  5. Oct 10, 2019
  6. Oct 08, 2019
    • Augie Fackler's avatar
      dirs: fix trivial over-read of input data · 2a0774e9
      Augie Fackler authored
      This code, introduced in 8c0a7eeda06d, was intentionally over-reading
      an input string to avoid getting a shared string object for a one-byte
      input. Unfortunately with an empty input (like in the case of a fuzzer
      getting started) this was a trivial over-read and triggered an
      AddressSanitizer failure.
      
      I went out of my way to make sure the code still does the
      copy-avoidance tricks. I don't think this change will cost us much
      performance since the one-character strings should be cached
      aggressively anyway.
      
      Differential Revision: https://phab.mercurial-scm.org/D7030
      2a0774e9
  7. Oct 07, 2019
  8. Oct 09, 2019
  9. Oct 07, 2019
  10. Oct 08, 2019
Loading