- Jun 17, 2017
-
-
Pierre-Yves David authored
We introduce a small object used to detect that no specific default value has been passed to 'ui.config'. We need this explicit special value since "None" is a valid and common default value. The end goal here is to make progress on a centralised and explicit declaration of the available config option. A first good usecase for this are "default" value. Before starting looking further down this alley we needs to rework the handling of default value in the 'ui' object to have all configxyz methods going through the same logic. This is the first changeset on this trek.
-
- Jun 20, 2017
-
-
Martin von Zweigbergk authored
By calling applybundle() with 'clonebundles' and the url instead of calling processbundle(), the hooks will get different arguments: HG_SOURCE will be 'clonebundles' instead of 'bundle2' and HG_URL will be the url instead of 'bundle2'. This is consistent with the bundle1 behavior and seems like a bug fix, but I'm marking it BC anyway.
-
- Jun 11, 2017
-
-
Sean Farley authored
Again, commands.bookmark is getting too large. checkconflict already has a lot of state and putting it in the bmstore makes more sense than having it as a closure. This also allows extensions a place to override this behavior. While we're here, add a documentation string because, well, we should be documenting more of our methods.
-
Sean Farley authored
commands.bookmark has grown quite large with two closures already. Let's split this up (and in the process allow extensions to override the default behavior).
-
- Jun 20, 2017
-
-
Danek Duvall authored
pip will check to see if it's the latest version, and complain if it isn't. The --no-index flag implies the --disable-pip-version-check flag, and makes the warning (and any associated network activity) go away.
-
- Apr 22, 2017
-
-
Yuya Nishihara authored
-
Yuya Nishihara authored
Unlike a mapfile whose template is looked up by spec -> mapfile -> topic, [templates] section is global. We use :sub-section syntax to define parts per template.
-
- Jun 17, 2017
-
-
Yuya Nishihara authored
As commented, this should be used with docheader and docfooter, not with header nor footer. That's one reason why no props are passed to templater when rendering a separator. (See map-cmdline.changelog to understand what the "header" is.)
-
- Apr 22, 2017
-
-
Yuya Nishihara authored
This seems useful for writing JSON template.
-
Yuya Nishihara authored
templatepartsmap() is a minimal copy of changeset_templater.__init__(). I tried to factor out a common function, but it was unnecessarily complicated.
-
Yuya Nishihara authored
-
Yuya Nishihara authored
Since this postfix hack exists only for backward compatibility, we don't need it for new [templates] section. This isn't a BC as templates defined in [templates] section weren't loaded until recently.
-
Yuya Nishihara authored
-
- Jun 20, 2017
-
-
Augie Fackler authored
-
- Jun 19, 2017
-
-
Danek Duvall authored
-
- Jun 04, 2017
-
-
Gregory Szorc authored
The only call site called addFailure before raising, which is exactly what the failure exception handler does. So this complexity is not needed. We have test coverage of this "server failed to start" scenario and nothing appeared to change.
-
Gregory Szorc authored
The previous changeset removed the last caller of addWarn(). So, we rip out that method and all the code related to tracking warned tests in the results system. There was even a comment saying we may want to fold warned tests into the "failed" state, which is what the previous changeset did.
-
- Jun 20, 2017
-
-
Augie Fackler authored
-
Augie Fackler authored
Spotted one of these, then wrote a check-code rule that caught them all. It will be the next change.
-
- Jun 15, 2017
-
-
Augie Fackler authored
-
Augie Fackler authored
-
- Jun 20, 2017
-
-
Augie Fackler authored
-
Augie Fackler authored
It's about to be a source of trouble, but removing it changes a ton of test lines, so doing this change as a standalone commit.
-
Christian Ebert authored
-
- Jun 04, 2017
-
-
Gregory Szorc authored
We would raise this if a test didn't return a result code. AFAICT this can only occur if there is a logic error in the test harness itself. I don't think it is worth the code complexity to distinguish this failure scenario from a regular test failure.
-
Gregory Szorc authored
AFAICT its last use was removed in d839e4820da7.
-
Gregory Szorc authored
unittest.SkipTest was introduced in Python 2.7. We previously defined it with our own class so we could run on Python 2.6.
-
- Jun 16, 2017
-
-
Martin von Zweigbergk authored
-
Martin von Zweigbergk authored
I think passing in the transaction makes it a little clearer and more consistent with bundle2.
-
Martin von Zweigbergk authored
See earlier patch for motivation.
-
Martin von Zweigbergk authored
See earlier patch for motivation.
-
- Jun 15, 2017
-
-
Martin von Zweigbergk authored
changegroup.apply() currently creates a transation if there isn't already one. Having the callers of that method pass in an existing transaction seems a little cleaner. To do that, we need to make sure all callers have a transaction. Since the transaction name is used as a hook argument (HG_TXNNAME), we need to match the name from changegroup.apply().
-
- Jun 19, 2017
-
-
Martin von Zweigbergk authored
-
Martin von Zweigbergk authored
The caller has already locked the repo.
-
Martin von Zweigbergk authored
Several benefits: * Gets close the comment describing it * Splits off unrelated comment about "backup" argument * Error checking is customarily done early * If we added an early return to the method, it would still consistently fail if there was an existing transaction (so we would find and fix that case quickly) One test needs updating with for this change, because we no longer create the backup bundle before we fail. I don't see much reason to create that backup bundle. If some command was adding content and then trying to strip it as well within the transaction, we would have a backup for the user, but the risk of that not being discovered in development seems very small.
-
Martin von Zweigbergk authored
-
Martin von Zweigbergk authored
I have checked that all callers have already taken the lock (and if they hadn't, we should have seen tests fail thanks to the 'transaction requires locking' devel warning in localrepo.transaction()).
-
Martin von Zweigbergk authored
-
Martin von Zweigbergk authored
-
Martin von Zweigbergk authored
-