- Aug 09, 2018
-
-
Martin von Zweigbergk authored
It's clearer to have the check just before the allocation happens. Differential Revision: https://phab.mercurial-scm.org/D4164
-
Martin von Zweigbergk authored
As noted by Yuya in the review of D4118, the fact that the nodetree always contains the nullid is not what we want for the disambiguation case. It's not what the pure version of the code does. Note that the updated test also passes before this patch, but it wouldn't have passed in native-code mode once we start using the nodetree for disambiguating nodeid prefixes. Differential Revision: https://phab.mercurial-scm.org/D4163
-
Martin von Zweigbergk authored
This is a follow-up to 781b2720d2ac (index: don't include nullid in len(), 2018-07-20). I intentionally didn't update the "index stats", so it will also not include the space for nullid after this patch. Differential Revision: https://phab.mercurial-scm.org/D4162
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D4184
-
- Aug 01, 2018
-
-
Pulkit Goyal authored
Follows up for d558e53cd6b6. Differential Revision: https://phab.mercurial-scm.org/D4259
-
- Aug 10, 2018
-
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D4258
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D4257
-
Augie Fackler authored
Otherwise we get an exception. Sadly, this manifesting deep inside the wireproto code, inside a future. For some reason the exception was /causing a hang/ rather than actually propagating out, which seems like it might merit some investigation in the future. Differential Revision: https://phab.mercurial-scm.org/D4256
-
Augie Fackler authored
This wasn't causing any immediate problems because of the source transformer, but I noticed the inconsistency and it bugged me. # skip-blame just a b prefix Differential Revision: https://phab.mercurial-scm.org/D4255
-
Augie Fackler authored
# skip-blame just b prefixes Differential Revision: https://phab.mercurial-scm.org/D4254
-
Augie Fackler authored
The format string expected the result, callers all passed the result, but we didn't actually accept the result to this function. I swear I've looked at this code a dozen times trying to find the problem, and it was this simple all along. Differential Revision: https://phab.mercurial-scm.org/D4253
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D4252
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D4251
-
Augie Fackler authored
It now passes on Python 3. # skip-blame b prefix Differential Revision: https://phab.mercurial-scm.org/D4250
-
Augie Fackler authored
This way all files open. So far none of our patterns look like they'll care. Differential Revision: https://phab.mercurial-scm.org/D4249
-
Augie Fackler authored
test-glog-beautifygraph.t now passes on Python 3. Differential Revision: https://phab.mercurial-scm.org/D4247
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D4246
-
Augie Fackler authored
# skip-blame just an r prefix Differential Revision: https://phab.mercurial-scm.org/D4245
-
Augie Fackler authored
This stabilizes some revset reprs across Python 2 and 3. Differential Revision: https://phab.mercurial-scm.org/D4244
-
Augie Fackler authored
This is the old (Python 2) way of printing sets. I actually prefer the Python 3 version of the repr, but this will result in less test churn in the short term. Differential Revision: https://phab.mercurial-scm.org/D4243
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D4242
-
Augie Fackler authored
Resolves a few output changes on Python 3 in test-mq.t, and gets us two new passing tests. Differential Revision: https://phab.mercurial-scm.org/D4248
-
- Aug 09, 2018
-
-
Augie Fackler authored
Everything uses unittest idioms now, so this can go away. Differential Revision: https://phab.mercurial-scm.org/D4185
-
Augie Fackler authored
This was caught by the tests, to my surprise. I'll also follow up with a test of the index[-1] behavior so we can be sure that remains consistent, as I think that currently has no coverage. Differential Revision: https://phab.mercurial-scm.org/D4183
-
Augie Fackler authored
I think this was previously getting lucky in Python 3, and would have stacktraced if something failed. Now that failure messages are eagerly computed, this turned into a problem. Differential Revision: https://phab.mercurial-scm.org/D4182
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D4181
-
- Aug 10, 2018
-
-
Augie Fackler authored
test-grep.t now passes on Python 3. Differential Revision: https://phab.mercurial-scm.org/D4240
-
Augie Fackler authored
This lets us correctly use %d as needed. Differential Revision: https://phab.mercurial-scm.org/D4239
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D4238
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D4237
-
Augie Fackler authored
Python 3 adds this newline, which is harmless. test-patchbomb.t now passes on Python 3. Differential Revision: https://phab.mercurial-scm.org/D4234
-
Augie Fackler authored
It's suboptimal that we get a bytes on 2 and a unicode on 3, but it's easy to work with and I'm disinclined to change anything unless we start using some sort of type inferencer. Differential Revision: https://phab.mercurial-scm.org/D4233
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D4232
-
Augie Fackler authored
It looks like this was a well-intentioned backwards compat hack for previewing the output of `hg email` in a stable way. Unfortunately I think this hack's time has come, because Python 3 does a much better job of ensuring it actually emits *valid* email messages. In particular, Python 2 would blindly trust us that the bytes we handed it were valid for the encoding we claimed, but Python 3 has some more sniff-tests that we end up failing. As a result, if we're going to print an email to the terminal, try us-ascii first, but if that fails go straight to iso-8859-1 which should be reasonably readable for ascii-compatible patch bodies. This *will* be a breaking change for ascii-incompatible textual patch content, but I don't think that's avoidable if we want to continue using the email library from the stdlib. .. bc:: Emails from the patchbomb extension will always be printed as though they are iso-8859-1 if they're not valid us-ascii. Previously, previewed emails were always claimed to be us-ascii and might contain invalid byte sequences. Differential Revision: https://phab.mercurial-scm.org/D4231
-
Augie Fackler authored
A couple of these became inline python sessions because they got more involved, and one of them is super-annoying and writes directly to sys.stdout.buffer because I just couldn't make it work any other way. Differential Revision: https://phab.mercurial-scm.org/D4230
-
- Aug 09, 2018
-
-
Augie Fackler authored
This dict-like of headers is only mostly dict-like: if you set a key that already exists, you it appends another value, rather than replacing the one that was already present. This fixes test-patchbomb-bookmark.t on Python 3. Differential Revision: https://phab.mercurial-scm.org/D4229
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D4228
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D4223
-
Augie Fackler authored
No idea when this became a thing, but it exists for me in both 2.7 and 3.6. Differential Revision: https://phab.mercurial-scm.org/D4222
-
Augie Fackler authored
Visible progress in test-patchbomb.t on Python 3. Differential Revision: https://phab.mercurial-scm.org/D4221
-