- Feb 13, 2018
-
-
Matt Harbison authored
test-narrow-strip.t is still broken. I don't see any feature condititionals, so it might be an actual problem.
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D2223
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D2222
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D2221
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D2220
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D2213
-
Augie Fackler authored
With this change, test-devel-warnings.t passes except for differences in how ProgrammingError is formatted and one mysterious traceback inside of transaction.__del__. Differential Revision: https://phab.mercurial-scm.org/D2212
-
Augie Fackler authored
Required on Python 3, functional on Python 2. Differential Revision: https://phab.mercurial-scm.org/D2211
-
Augie Fackler authored
This preserves nouideprecwarn wanting a bytes, which is consistent with the rest of hg. Differential Revision: https://phab.mercurial-scm.org/D2210
-
Augie Fackler authored
They're coming back as unicodes, so sysbytes seems like the best we can do. This is like D2171 and D2172, but those fail on Python 2.7.5 (seriously!), so this is my version of the same change. I actually wrote this before reviewing those, then discarded it, then came back to it after finding out 2.7.5 is a silly place. Differential Revision: https://phab.mercurial-scm.org/D2209
-
Augie Fackler authored
We don't know what type we'll get here, so we need something that'll behave like a repr without returning a unicode. Differential Revision: https://phab.mercurial-scm.org/D2208
-
Augie Fackler authored
# skip-blame because it's just b prefixes Differential Revision: https://phab.mercurial-scm.org/D2207
-
- Feb 12, 2018
-
-
Gregory Szorc authored
Python's APIs should return a system string. We want to use bytes for logging. So convert the traceback to bytes before sending it to the logger. Differential Revision: https://phab.mercurial-scm.org/D2176
-
Gregory Szorc authored
This yields identical behavior on Python 2 and 3. Differential Revision: https://phab.mercurial-scm.org/D2174
-
Gregory Szorc authored
Everywhere else in this file uses b''. I must have missed a line when I wrote this code a few days ago. # skip-blame b prefix Differential Revision: https://phab.mercurial-scm.org/D2173
-
Gregory Szorc authored
Required encoding a str to bytes and writing bytes to a file descriptor. Differential Revision: https://phab.mercurial-scm.org/D2170
-
Gregory Szorc authored
email.Utils was renamed to email.utils in Python 2.5. But it appears at some point before Python 2.7 (possibly 2.5) email.Utils was aliased to the new home. So email.utils should be safe for all versions of Python we support. Differential Revision: https://phab.mercurial-scm.org/D2168
-
Gregory Szorc authored
The returned value from this function is eventually fed into email.charset.Charset.__init__. However, the standard library appears to handle both string types in Python 2 and 3. So there shouldn't be any problem returning a bytes here. Differential Revision: https://phab.mercurial-scm.org/D2167
-
Gregory Szorc authored
The actual types here may be mixed due to string literals and variables from other modules. So a cast is necessary. Differential Revision: https://phab.mercurial-scm.org/D2166
-
Gregory Szorc authored
dict.items() and friends are iterators/views in Python 3. You aren't allowed to mutate the underlying dictionary when iterating on these views. So iterate over a copy of things. Differential Revision: https://phab.mercurial-scm.org/D2164
-
Gregory Szorc authored
Otherwise Python 3 is unhappy. We only set a single key here. So I don't think pycompat.strkwargs() is necessary. Differential Revision: https://phab.mercurial-scm.org/D2163
-
Gregory Szorc authored
patch.diffstat() returns a bytes. util.chunkbuffer() expects an iterable of bytes. Feeding it a single bytes instance on Python 3 will iterate the characters as integers. This blows up util.chunkbuffer. Differential Revision: https://phab.mercurial-scm.org/D2162
-
Gregory Szorc authored
Test extensions aren't currently loaded with our custom module importer. # skip-blame b prefix Differential Revision: https://phab.mercurial-scm.org/D2161
-
Gregory Szorc authored
# skip-blame b prefix Differential Revision: https://phab.mercurial-scm.org/D2160
-
Gregory Szorc authored
.hexdigest() returns a system str. .digest() consistently returns bytes. Differential Revision: https://phab.mercurial-scm.org/D2159
-
Gregory Szorc authored
The extras dict on commits has string keys and values. Before this commit, we passed "close" as an integer, which Python 2 gladly coerced to a string during a %s formatting in the bowels of changelog.py. Differential Revision: https://phab.mercurial-scm.org/D2157
-
Gregory Szorc authored
Two places in this code Python 3 changed from raising ValueError to TypeError. So catch the addition exceptions. IMO this code might be better off performing type sniffing. But I'm not sure the implications of changing that. Differential Revision: https://phab.mercurial-scm.org/D2156
-
Gregory Szorc authored
These extensions don't get run through our custom module importer. It's easy enough to make them dual compatible with Python 2 and 3. # skip-blame b prefixes Differential Revision: https://phab.mercurial-scm.org/D2155
-
Gregory Szorc authored
We must pass the native str type when importing. Differential Revision: https://phab.mercurial-scm.org/D2154
-
- Feb 11, 2018
-
-
Gregory Szorc authored
And switch to using the context manager form of open() while we're here. Differential Revision: https://phab.mercurial-scm.org/D2153
-
Gregory Szorc authored
Differential Revision: https://phab.mercurial-scm.org/D2152
-
- Feb 12, 2018
-
-
Gregory Szorc authored
This unmasks a ton of other TypeError in blackbox code. # skip-blame since it's just a b prefix Differential Revision: https://phab.mercurial-scm.org/D2175
-
Augie Fackler authored
These are things that are bigger than we want to handle right now, but are pretty important to get narrowing to be non-experimental. Differential Revision: https://phab.mercurial-scm.org/D2196
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D2195
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D2194
-
Augie Fackler authored
The expandnarrow functionality lets a client have a shorthand (for Google it's a reference to a checked-in file) for a set of includes and excludes. For testing we should probably implement a simple version of that functionality here. For now, rename the capability so we don't burn the good name in the future if we need to change behavior. It's plausible that this functionality should be dropped from the narrowhg we ship long-term, but I'm dubious as it seems pretty likely other organizations will want similar shorthands for commonly-used subsets of their trees. Differential Revision: https://phab.mercurial-scm.org/D2193
-
Augie Fackler authored
I'm not sure why invalid_includes was an out-param, but it doesn't look like there's any reason for it to be now. Differential Revision: https://phab.mercurial-scm.org/D2192
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D2191
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D2190
-
Augie Fackler authored
We should clean this up considerably when remotefilelog lands, which we expect to try and accomplish in the near-ish future. Differential Revision: https://phab.mercurial-scm.org/D2189
-