Skip to content
Snippets Groups Projects
  1. Apr 14, 2021
  2. Apr 13, 2021
  3. Apr 11, 2021
  4. Apr 13, 2021
  5. Apr 11, 2021
  6. Apr 10, 2021
    • Pierre-Yves David's avatar
      infinitepush: use the new function to determine push destination · 6071bfab6292
      Pierre-Yves David authored
      Since 066b8d8f75b8, the push command accept multiple destination. `infinitepush`
      was not aware of that. We now use the new `urlutil.get_push_paths` function to
      determine the push destination, fixing the issue. This will also make future
      evolution of that logic transparent for infinitepush
      
      We still disallow push to multiple destinations if infinite push is enabled
      because I don't know what this means for infinite push. However user will now
      get a clear error message instead of a crash.
      
      Differential Revision: https://phab.mercurial-scm.org/D10379
      6071bfab6292
  7. Apr 13, 2021
  8. Apr 12, 2021
  9. Apr 11, 2021
  10. Apr 10, 2021
  11. Apr 13, 2021
  12. Apr 09, 2021
  13. Mar 26, 2021
  14. Mar 25, 2021
    • Matt Harbison's avatar
      typing: add type hints to mercurial/error.py · 8b6e36e4b553
      Matt Harbison authored
      The only slightly unusual things here are that `location` is passed to
      `ParseError` and both bytes and an int (so this accepts both), and the message
      passed `ProgrammingError` is immediately converted to str.  Therefore it is
      typed as `AnyStr`, because there are a couple of instances that are already
      passed as str.
      
      There are a couple of places where bytes are being passed to builtin exceptions
      that might need to be converted to str.
      
      Differential Revision: https://phab.mercurial-scm.org/D10274
      8b6e36e4b553
  15. Mar 19, 2021
  16. Apr 06, 2021
  17. Apr 05, 2021
  18. Mar 31, 2021
  19. Apr 08, 2021
    • Simon Sapin's avatar
      rust: Remove use of `py.eval()` · c6ceb5f27f97
      Simon Sapin authored
      The previous Rust code allocated an intermediate `Vec`, converted that
      to a Python list, then used `eval` to run Python code that converts that
      list to a Python set.
      
      rust-cpython exposes Rust bindings for Python sets, let’s use that instead
      to construct a set directly.
      
      Differential Revision: https://phab.mercurial-scm.org/D10328
      c6ceb5f27f97
    • Simon Sapin's avatar
      rust: Remove the compile-time 'dirstate-tree' feature flag · 441024b279a6
      Simon Sapin authored
      This code has compiler errors since it is not built on CI and nobody has been
      working on it for some time.
      
      We (Octobus) are still pursuing status optimizations based on a tree data
      structure for the dirstate, but upcoming patches will use a run-time opt-in
      instead of compile-time, so that at least corresponding Rust code keeps
      compiling when other changes are made.
      
      Differential Revision: https://phab.mercurial-scm.org/D10329
      441024b279a6
  20. Sep 14, 2020
    • sliquister's avatar
      procutil: avoid using os.fork() to implement runbgcommand · 8759e22f1649
      sliquister authored
      We ran into the following deadlock:
      
      - some command creates an ssh peer, then raises without explicitly
        closing the peer (hg id + extension in our case)
      
      - dispatch catches the exception, calls ui.log('commandfinish', ..)
        (the sshpeer is still not closed), which calls logtoprocess, which
        calls procutil.runbgcommand.
      
      - in the child of runbgcommand's fork(), between the fork and the
        exec, the opening of file descriptors triggers a gc which runs the
        destructor for sshpeer, which waits on ssh's stderr being closed,
        which never happens since ssh's stderr is held open by the parent of
        the fork where said destructor hasn't run
      
      Remotefilelog appears to have a hack around this deadlock as well.
      
      I don't know if there's more subtlety to it, because even though the
      problem is determistic, it is very fragile, so I didn't manage to
      reduce it.
      
      I can imagine three ways of tackling this problem:
      1. don't run any python between fork and exec in runbgcommand
      2. make the finalizer harmless after the fork
      3. close the peer without relying on gc behavior
      
      This commit goes with 1, as forking without exec'ing is tricky in
      general in a language with gc finalizers. And maybe it's better in the
      presence of rust threads. A future commit will try 2 or 3.
      
      Performance wise: at low memory usage, it's an improvement. At higher
      memory usage, it's about 2x faster than before when ensurestart=True,
      but 2x slower when ensurestart=False. Not sure if that matters. The
      reason for that last bit is that the subprocess.Popen always waits for
      the execve to finish, and at high memory usage, execve is slow because
      it deallocates the large page table. Numbers and script:
      
      				 before after
          mem=1.0GB, ensurestart=True  52.1ms 26.0ms
          mem=1.0GB, ensurestart=False 14.7ms 26.0ms
          mem=0.5GB, ensurestart=True  23.2ms 11.2ms
          mem=0.5GB, ensurestart=False  6.2ms 11.3ms
          mem=0.2GB, ensurestart=True  15.7ms 7.4ms
          mem=0.2GB, ensurestart=False  4.3ms 8.1ms
          mem=0.0GB, ensurestart=True   2.3ms 0.7ms
          mem=0.0GB, ensurestart=False  0.8ms 0.8ms
      
          import time
          for memsize in [1_000_000_000, 500_000_000, 250_000_000, 0]:
              mem = 'a' * memsize
              for ensurestart in [True, False]:
                  now = time.time()
                  n = 100
                  for i in range(n):
                      procutil.runbgcommand([b'true'], {}, ensurestart=ensurestart)
                  after = time.time()
                  ms = (after - now) / float(n) * 1000
                  print(f'mem={memsize / 1e9:.1f}GB, ensurestart={ensurestart} -> {ms:.1f}ms')
      
      Differential Revision: https://phab.mercurial-scm.org/D9019
      8759e22f1649
  21. Apr 08, 2021
    • Matt Harbison's avatar
      share: store relative share paths with '/' separators · 218a26df7813
      Matt Harbison authored
      I created a relative share in Windows and tried to use it in WSL, and it failed:
      
          abort: .hg/sharedpath points to nonexistent directory
              /mnt/c/Users/Matt/hg-review/.hg/..\..\hg\.hg
      
      Use `normpath` on the read side so that the code has the usual Windows style
      paths it always had (I don't think that matters much), but it also eliminates
      the directory escaping path components in the case where the path is printed.
      
      This will not fix repositories that have already been created, but it's trivial
      enough to hand edit the file to correct it.
      
      Differential Revision: https://phab.mercurial-scm.org/D10330
      218a26df7813
  22. Apr 09, 2021
  23. Jan 14, 2021
  24. Apr 09, 2021
Loading