Skip to content
Snippets Groups Projects
  1. May 19, 2022
  2. May 16, 2022
    • Pierre-Yves David's avatar
      fix-ci: backed out changeset 308e45f7b455 · 22279b60
      Pierre-Yves David authored
      The  chg variant of the CI see a failure on `tests/test-narrow-pull.t`.
      Bisecting point the failure as starting at this small changeset…
      
      Backing it out, restore the CI on default. It was never broken on
      stable, which is even more puzzling.
      22279b60
  3. May 17, 2022
  4. May 16, 2022
    • Pierre-Yves David's avatar
      ci: do not trigger phabricator for merge-request · 477b5145
      Pierre-Yves David authored
      The fast the phabricator steps has a `rules` entry makes it selected for the
      special `merge_requests` pipelines. The other ones behave as default and are not
      selected tot the mrege_request pipelines.
      
      This result in a second pipeline to be created, with only the phabricator
      pipeline in it. Which usually succeed fast (since there is nothing to do).
      
      This is harmful as this create a false sense of "the series is passing" and
      Gitlab will use this simplistic pipeline for validation.
      
      By explicitly preventing the pipeline to be created in the merge-request case,
      we prevent this situation to happens
      
      Note that the job will be dropped (alonside phabricator) in the next two weeks
      anyway.
      477b5145
  5. May 12, 2022
  6. Apr 21, 2022
    • Martin von Zweigbergk's avatar
      rust-repo: make `Send` by not storing functions in `LazyCell` · 90a15199
      Martin von Zweigbergk authored
      We (Google) want to use `Repo` in a context where we can store it in
      `Mutex<Repo>`. However, that currently doesn't work because it's not
      `Send` because the `LazyCell` initialization functions are not
      `Send`. It's easy to fix that by passing them to the `get_or_init()`
      and `get_mut_or_init()` functions. We'll probably also want `Repo` to
      be `Send` (and even `Sync`) in core later, so this seems like a step
      in the right direction.
      
      Differential Revision: https://phab.mercurial-scm.org/D12582
      90a15199
  7. May 05, 2022
  8. May 04, 2022
  9. Apr 22, 2022
  10. May 02, 2022
    • Anton Shestakov's avatar
      followlines: don't put Unicode directly into the .js file (issue6559) · 2c0570a6
      Anton Shestakov authored
      Apparently some web server setups may serve this file in a different encoding
      than UTF-8, and that results in visual garbage in the followlines button that
      renders for every line in a file. So instead of using this Unicode character in
      UTF-8 we can encode it as \u2212. Or, to be more explicit, we can use &minus;
      HTML entity, which resolves into exactly that character.
      
      Since now we're using innerHTML property to set the minus part of the button,
      let's use it to set the plus part as well (even though the plus sign was plain
      ASCII). A wise man once said "A foolish consistency is the hobgob... eh,
      whatever." Throw a brick at me if this makes things worse.
      
      Differential Revision: https://phab.mercurial-scm.org/D12597
      2c0570a6
  11. Apr 28, 2022
  12. Apr 27, 2022
  13. Apr 26, 2022
  14. May 04, 2022
  15. May 03, 2022
  16. May 04, 2022
  17. Apr 28, 2022
  18. May 03, 2022
  19. Apr 25, 2022
  20. Apr 19, 2022
    • Raphaël Gomès's avatar
      rhg: use `Command::exec` instead of `Command::status` · 006688e3
      Raphaël Gomès authored
      `rhg` is supposed to be a transparent executable, using a subprocess defeats
      that purpose. See inline comments for more details.
      
      This also introduces the `which` crate to check if the fallback executable
      actually exists to help debugging (plain `execve` doesn't give much
      information).
      
      The error code 253 is used to signify that the fallback is not found, but may
      mean in the future that it is otherwise invalid if we start being more
      specific.
      
      Differential Revision: https://phab.mercurial-scm.org/D12578
      006688e3
  21. Apr 27, 2022
  22. Apr 25, 2022
Loading