- Jun 08, 2018
-
-
Yuya Nishihara authored
This allows us to create ctx objects only if necessary. I tried another idea which is to populate ctx from 'repo' and 'node' value on demand. It worked, but seemed unnecessarily complicated. So I chose a simpler one. The datafields argument is a space-separated string for consistency with fm.write() API.
-
- Jun 14, 2018
-
-
Yuya Nishihara authored
-
Yuya Nishihara authored
-
- Jun 21, 2018
-
-
Martin von Zweigbergk authored
-
- Jun 19, 2018
-
-
Yuya Nishihara authored
Since a75d24539aba "convert: fix convert dropping p2 contents during filemap merge", wctx is not always a committablectx because the convert extension passes in repo[n] as wctx. If wctx is a committed changeset, its manifest dict shouldn't be mutated reflecting to the working directory.
-
Martin von Zweigbergk authored
With this change, hg split will preserve the phase of the commit that is being split, ignoring the phases.new-commit setting. Previously, we would use whatever phases.new-commit was set to (unless our parent was secret, then we would be secret even if phases.new-commit=draft). Now, splitting a draft commit with phases.new-commit=secret does not cause the new commits to become secret, and splitting a secret commit with phases.new-commit=draft and a draft parent does not cause the new commits to become draft. Test cases and commit message taken from Kyle Lippincott's D2016 (thanks!). Differential Revision: https://phab.mercurial-scm.org/D3819
-
Martin von Zweigbergk authored
We have had multiple bugs where the phase wasn't correctly carried forward to a rewritten changeset (for example: phabricator, split, evolve, fix). Handling the phase update in cleanupnodes() makes it less likely to happen again, especially once we have made it fix the phase by default (perhaps in the next release cycle). This patch also updates all applicable callers so we get some testing of it. Note that rebase and histedit can't be fixed yet because they call cleanupnodes() only at the end and the phase may have been changed by the user when the rebase/histedit was interrupted (due to merge conflicts). I think we should make them write one commit at a time (as it already does), along with associated obsmarkers, bookmark moves, etc. When that's done, we can switch them over to cleanupnodes(). Differential Revision: https://phab.mercurial-scm.org/D3818
-
Martin von Zweigbergk authored
We didn't seem to have any test checking that uncommitting a draft commit with phase.new-phase=secret preserved the draft phase. Differential Revision: https://phab.mercurial-scm.org/D3817
-
- Jun 17, 2018
-
-
Sangeet Kumar Mishra authored
Adds a diff flag, which works exactly same as all, in fact since --all searches diffs, there diff is a better name for it. The all flag is still here for backward compatibility reasons. Some major tests for all has been picked and added for diff. Differential Revision: https://phab.mercurial-scm.org/D3763
-
- Jun 20, 2018
-
-
Martin von Zweigbergk authored
As pointed out by Yuya, we need a transaction to make sure the state before the call to cleanupnodes() is not observable. Differential Revision: https://phab.mercurial-scm.org/D3823
-
Martin von Zweigbergk authored
complete() is preferred over update(None), so let's enforce that. Differential Revision: https://phab.mercurial-scm.org/D3822
-
Martin von Zweigbergk authored
progress(None) had a completely different implementation from the progress(<not None>) implementation. It very much feels like it should be a separate method, so this patch makes it so. That also makes it clear that only the topic parameter matters when closing a topic (e.g. "total" does not matter). Differential Revision: https://phab.mercurial-scm.org/D3821
-
Martin von Zweigbergk authored
Differential Revision: https://phab.mercurial-scm.org/D3820
-
- Jun 19, 2018
-
-
Boris Feld authored
Keeping things alphabetically sorted.
-
- Jun 21, 2018
-
-
Matt Harbison authored
This ensures that the blobs don't need to be present to be filtered properly.
-
Matt Harbison authored
Since LFS stores the binary attribute in the pointer file, this means that the file doesn't need to be downloaded in order to be skipped. This function also catches an IOError if the data can't be loaded in the non-LFS case. I wonder if it's worth storing the unix/dos attributes in the pointer file as well, though I'd expect LFS files to be binary most of the time.
-
- Jun 19, 2018
-
-
Matti Hämäläinen authored
A long-standing issue in the crecord (interactive curses commit interface) is that using PageUp/Down to move along longer-than current screen size chunks would "lose" the cursor and not properly re-center. There has been self.recenterdisplayedarea() to do that, but it has not been in use for some reason. Add calls to the appropriate uparrowshiftevent() and downarrowshiftevent() methods to fix this.
-
- Feb 02, 2018
-
-
Kyle Lippincott authored
Differential Revision: https://phab.mercurial-scm.org/D2015
-
- Jun 18, 2018
-
-
Martin von Zweigbergk authored
With this commit, the only in-tree caller of ui.progress() is scmutil.progress(). That means that we could deprecate it. It also means that we can considering inlining it in scmutil.progress. Differential Revision: https://phab.mercurial-scm.org/D3812
-
Martin von Zweigbergk authored
Although it looks like this code was micro-optimized, I could not measure any slow-down. Differential Revision: https://phab.mercurial-scm.org/D3811
-
Martin von Zweigbergk authored
Differential Revision: https://phab.mercurial-scm.org/D3810
-
Martin von Zweigbergk authored
Differential Revision: https://phab.mercurial-scm.org/D3809
-
Martin von Zweigbergk authored
Differential Revision: https://phab.mercurial-scm.org/D3808
-
Martin von Zweigbergk authored
Differential Revision: https://phab.mercurial-scm.org/D3807
-
Martin von Zweigbergk authored
Differential Revision: https://phab.mercurial-scm.org/D3806
-
Martin von Zweigbergk authored
This doesn't use progress.increment() because progress output is skipped for some positions (so we may end up calling "update(0), update(2), update(7)", or similar). Differential Revision: https://phab.mercurial-scm.org/D3805
-
Martin von Zweigbergk authored
Differential Revision: https://phab.mercurial-scm.org/D3804
-
Martin von Zweigbergk authored
The "writing" topic has not been used since 1830d0cc4bc1 (patchbomb: minor refactoring of mbox functionality, preparing for move, 2011-11-23). Differential Revision: https://phab.mercurial-scm.org/D3803
-
Martin von Zweigbergk authored
Differential Revision: https://phab.mercurial-scm.org/D3802
-
Martin von Zweigbergk authored
Differential Revision: https://phab.mercurial-scm.org/D3801
-
Martin von Zweigbergk authored
A minor side-effect is that we no longer print the progress at 0 (and that we don't re-print it at its current value when starting the next manifest/file). Differential Revision: https://phab.mercurial-scm.org/D3800
-
Martin von Zweigbergk authored
IIUC, one is supposed to close each progress topic before strarting a new one. Otherwise the topics are considered nested, which we don't want here. Differential Revision: https://phab.mercurial-scm.org/D3799
-
Martin von Zweigbergk authored
Differential Revision: https://phab.mercurial-scm.org/D3798
-
Martin von Zweigbergk authored
I also reworded a variable to make it clearer that it's only used for subdirectories. Differential Revision: https://phab.mercurial-scm.org/D3797
-
Martin von Zweigbergk authored
A side-effect is that progress is now reported as 1 *before* we start checking the first file. That seems to be how we do it in most places. Also, the right topic is now closed. Differential Revision: https://phab.mercurial-scm.org/D3796
-
Martin von Zweigbergk authored
Differential Revision: https://phab.mercurial-scm.org/D3795
-
Martin von Zweigbergk authored
Differential Revision: https://phab.mercurial-scm.org/D3794
-
- Jun 03, 2018
-
-
Yuya Nishihara authored
Transformed by contrib/byteify-strings.py and adjusted exceeded lines manually. Some of b''s would be wrong as the phabriactor extension has to work with JSON data. # skip-blame just many b prefixes
-
Yuya Nishihara authored
-
- May 31, 2018
-
-
Yuya Nishihara authored
-