Skip to content
Snippets Groups Projects
  1. Mar 09, 2013
    • Durham Goode's avatar
      sshpeer: store subprocess so it cleans up correctly · 9baf4330
      Durham Goode authored
      When running 'hg pull --rebase', I was seeing this exception 100% of the
      time as the python process was closing down:
      
      Exception TypeError: TypeError("'NoneType' object is not callable",) in
      <bound method Popen.__del__ of <subprocess.Popen object at 0x937c10>> ignored
      
      By storing the subprocess on the sshpeer, the subprocess seems to clean up
      correctly, and I no longer see the exception. I have no idea why this actually
      works, but I get a 0% repro if I store the subprocess in self.subprocess,
      and a 100% repro if I store None in self.subprocess.
      
      Possibly related to issue 2240.
      9baf4330
  2. Feb 28, 2013
  3. Feb 09, 2013
  4. Feb 10, 2013
  5. Feb 09, 2013
  6. Mar 01, 2013
  7. Feb 17, 2013
    • Matt Mackall's avatar
      httppeer: avoid large dumps when we don't see an hgweb repo · b376e8f9
      Matt Mackall authored
      When we don't get an hgweb protocol response, we dump the response to
      the user for diagnostic purposes (it might be a cgitb message, for
      instance).
      
      But if we try to clone a bundle, we don't want to show the
      entire bundle in the error message. Also, we don't want fetch the
      full bundle multiple times during fallback. So we only fetch 1k here.
      b376e8f9
    • Matt Mackall's avatar
      httppeer: improve protocol check · 56f8522c
      Matt Mackall authored
      Pre-0.6c hgweb used text/plain for protocol responses. This meant
      that a web server could serve a static file and confuse a client into
      generating a nasty traceback.
      
      Now we insist that text/plain protocol responses not include a
      Content-Length, which older hgweb didn't generate but will typically
      be produced for static files.
      56f8522c
  8. Feb 28, 2013
  9. Feb 26, 2013
  10. Feb 28, 2013
  11. Feb 23, 2013
  12. Feb 22, 2013
Loading