- Oct 13, 2018
-
-
Augie Fackler authored
All tests now pass. Differential Revision: https://phab.mercurial-scm.org/D5054
-
Augie Fackler authored
The big annoyance here was having to feed textwrap unicodes instead of bytes, but it all seems to work. Differential Revision: https://phab.mercurial-scm.org/D5053
-
Yuya Nishihara authored
Surprisingly, this fixes test-cache-abuse.t, which would generate a different revbranch cache if filtered set had no cache.
-
Yuya Nishihara authored
-
Mark Thomas authored
test-bookmarks-pushpull.t writes a temporary file in $TESTDIR instead of $TESTTMP. Make it use $TESTTMP instead. Differential Revision: https://phab.mercurial-scm.org/D5057
-
Pulkit Goyal authored
This makes test-pathconflicts-basic.t and test-origbackup-conflict.t passing on Python 3. Differential Revision: https://phab.mercurial-scm.org/D5042
-
Pulkit Goyal authored
This makes the test pass on Python 3. # skip-blame because just b'' prefix. Differential Revision: https://phab.mercurial-scm.org/D5041
-
Pulkit Goyal authored
This makes test-close-head.t pass on Python 3. Differential Revision: https://phab.mercurial-scm.org/D5040
-
Pulkit Goyal authored
This also makes the test-ssh-repoerror.t pass on Python 3. Differential Revision: https://phab.mercurial-scm.org/D5038
-
Pulkit Goyal authored
This makes test-pager-legacy.t pass on Python 3. Differential Revision: https://phab.mercurial-scm.org/D5037
-
Pulkit Goyal authored
Differential Revision: https://phab.mercurial-scm.org/D5036
-
Pulkit Goyal authored
This makes the test work on Python 3. Differential Revision: https://phab.mercurial-scm.org/D5035
-
Pulkit Goyal authored
This fixes the test-status-color.t on python 3. Differential Revision: https://phab.mercurial-scm.org/D5034
-
Pulkit Goyal authored
This makes the test pass on Python 3. # skip-blame because just b'' prefixes Differential Revision: https://phab.mercurial-scm.org/D5033
-
Pulkit Goyal authored
This test is now pretty close to passing on Python 3. # skip-blame because just b'' prefixes. Differential Revision: https://phab.mercurial-scm.org/D5032
-
Pulkit Goyal authored
Differential Revision: https://phab.mercurial-scm.org/D5031
-
Pulkit Goyal authored
On py2, the directory names are under quotes and on py3 they are not and I don't know why. Differential Revision: https://phab.mercurial-scm.org/D5030
-
Pulkit Goyal authored
# skip-blame because just b'' prefixes Differential Revision: https://phab.mercurial-scm.org/D5029
-
Pulkit Goyal authored
This takes us close to make the test passing. # skip-blame because just b'' prefixes Differential Revision: https://phab.mercurial-scm.org/D5028
-
Pulkit Goyal authored
Just following 6c0b1d964537 here. Differential Revision: https://phab.mercurial-scm.org/D5027
-
Pulkit Goyal authored
Using '%r' on bytes in python 3 adds b'' prefixes to output which is bad. I don't see a reason why we want to repr() the string here, so just switched to '%s'. This fixes some output failure in one of the subversion test. Differential Revision: https://phab.mercurial-scm.org/D5026
-
Pulkit Goyal authored
Differential Revision: https://phab.mercurial-scm.org/D5025
-
Pulkit Goyal authored
Differential Revision: https://phab.mercurial-scm.org/D5024
-
- Oct 12, 2018
-
-
Pulkit Goyal authored
This fixes test-narrow-widen-no-ellipsis.t on Python 3. # skip-blame because just r'' prefixes Differential Revision: https://phab.mercurial-scm.org/D5023
-
Gregory Szorc authored
As suggested by @yuja in D4967. Differential Revision: https://phab.mercurial-scm.org/D5020
-
Mark Thomas authored
Update the help text to reflect the recent changes to absorb in D4999. The `-p` option actually only affects the `-a` option: without `-a`, the changes are printed; with `-a` the changes are only printed if `-p` is specified. Reword the help text for `-p` to reflect this. Differential Revision: https://phab.mercurial-scm.org/D5022
-
Katsunori FUJIWARA authored
"opener" of localrepository object was dropped at Mercurial 4.3 (or a7e210167c28). "vfs" should be used instead. wlock is required to write into a file under .hg directory. For efficiency, we should change _cmpsets() from: 1. acquire wlock 2. open log file under .hg directory with write mode 3. compare between result of watchman and Mercurial's dirstate logic 4. write out error info into a file, if error is detected 5. release wlock to: 1. compare between result of watchman and Mercurial's dirstate logic 2. acquire wlock, if error is detected 3. open and write error info into a file 4. release wlock But this is another issue.
-
Katsunori FUJIWARA authored
This forces fsmonitor extension execute "paranoid" code path. Strict speaking, we should make fsmonitor-run-tests.py accept own specific options, but there is no code path, which is disabled in "paranoid" mode, at least now. Therefore, this solution seems reasonable enough.
-
- Oct 08, 2018
-
-
Katsunori FUJIWARA authored
Now, these files has no style issue at checking with import-checker.py. BTW, tests/test-imports-checker.t is still excluded, because almost all code fragments in it has intentional importing style violation. Using NO_CHECK_EOF instead of EOF as heredoc limit mark can make import-checker.py ignore such fragments. But keeping these fragments checkable seems still useful: for example, test-imports-checker.t can be used to test whether import-checker.py can detect erroneous code fragment in test script as expected.
-
Katsunori FUJIWARA authored
test-extension.t is excluded in test-check-module-imports.t, because import-checker.py reports that some python code fragments in it does not import modules in recommended style. These code fragments are used to test importing modules relatively and absolutely via extension (e.g. issue4029, issue5208, and so on). Test specific package hierarchy becomes complicated for this purpose, and it seems reasonable to avoid checking these code fragments with import-checker.py. But on the other hand, other code fragments in test-extension.t should be checked by import-checker.py. Therefore, this patch uses NO_CHECK_EOF limit mark only for python code fragments, which are used to test importing via extension in test-extension.t. NO_CHECK_EOF limit mark tells import-checker.py that this code fragment should be ignored, via testparseutil.py.
-
Katsunori FUJIWARA authored
Some test scripts are excluded in test-check-module-imports.t, because import-checker.py reports that code fragments embedded in these test scripts have syntax error. But these syntax error is intentional. This patch uses NO_CHECK_EOF instead of EOF as heredoc limit mark for such fragments, in order to make import-checker.py ignore them. NO_CHECK_EOF limit mark tells import-checker.py that this code fragment should be ignored, via testparseutil.py.
-
Katsunori FUJIWARA authored
test-lock.py is excluded in test-check-module-imports.t, because import-checker.py reports that some stdlibs are imported after local silenttestrunner module. I can not found out any reason why tests/silenttestrunner.py should be imported before some stdlibs from the point of functionality view.
-
Katsunori FUJIWARA authored
Some test scripts are excluded in test-check-module-imports.t, because import-checker.py reports that hgweb and/or hgwebdir of mercurial.hgweb are not imported in recommended style. To fix this issues, this patch make python code fragments embedded in these files import hgweb from mercurial package at first, and refer hgweb and hgwebdir via imported hgweb.
-
- Oct 12, 2018
-
-
Gregory Szorc authored
These fields are str on Python 2 and 3. This module doesn't import any Mercurial modules. So I just did the str -> bytes inline. Differential Revision: https://phab.mercurial-scm.org/D5010
-
Gregory Szorc authored
Trying to chase the long tail of unicode badness in this file due to frame / code objects holding str everywhere. Differential Revision: https://phab.mercurial-scm.org/D5016
-
Gregory Szorc authored
This avoids buffering due to mixed print() and sys.stdout.write() by profiling code. And with this, test-profile.t passes on Python 3 \o/. Honestly, I'd be shocked if there weren't more Python 3 encoding issues lingering in the profiling code. That code isn't super high quality and doesn't seem to have thorough test coverage. Differential Revision: https://phab.mercurial-scm.org/D5018
-
Gregory Szorc authored
This allows main() and argument parsing to work. Differential Revision: https://phab.mercurial-scm.org/D5017
-
Gregory Szorc authored
Because Python 3's print() doesn't like bytes. Differential Revision: https://phab.mercurial-scm.org/D5015
-
Gregory Szorc authored
Differential Revision: https://phab.mercurial-scm.org/D5014
-
Gregory Szorc authored
These are used for simple compares. We don't need to normalize to bytes. As part of this, I expanded a set literal so entries are 1 per line. Differential Revision: https://phab.mercurial-scm.org/D5013
-