Skip to content
Snippets Groups Projects
  1. Feb 15, 2012
  2. Feb 16, 2012
  3. Feb 15, 2012
    • Katsunori FUJIWARA's avatar
      largefiles: check whether specified patterns are related to largefiles strictly · 41417443
      Katsunori FUJIWARA authored
      current 'lfiles_repo.status()' implementation examines whether
      specified patterns are related to largefiles in working directory (not
      to STANDIN) or not by NOT-EMPTY-NESS of below list:
      
          [f for f in match.files() if f in lfdirstate]
      
      but it can not be assumed that all in 'match.files()' are file itself
      exactly, because user may only specify part of path to match whole
      under subdirectories recursively.
      
      above examination will mis-recognize such pattern as 'not related to
      largefiles', and executes normal 'status()' procedure. so, 'hg status'
      shows '?'(unknown) status for largefiles in working directory unexpectedly.
      
      this patch examines relation of pattern to largefiles by applying
      'match()' on each entries in lfdirstate and checking wheter there is
      no matched entry.
      
      it may increase cost of examination, because it causes of full scan of
      entries in lfdirstate.
      
      so this patch uses normal for-loop instead of list comprehensions, to
      decrease cost when matching is found.
      41417443
  4. Feb 10, 2012
  5. Feb 07, 2012
    • Patrick Mézard's avatar
      mq: restore _branchtags() fast path (issue3223) · 20ad8f05
      Patrick Mézard authored
      Since a5917346c72e, mq saves the nodeid of the first applied patch to
      cache/branchheads, which breaks the optimized cache handling introduced in
      fbf8320f25c8. The problem is the revision being committed is appended to
      mqrepo.applied after the commit succeeds, which means mqrepo._branchtags()
      performs a regular update and write the first applied patch to the branch
      cache.
      
      One solution is to set a context variable _committingpatch on the mqrepo while
      it is committing a patch and to take it in account when deciding to fast-path
      mqrepo._branchtags(). Not really elegant but it works.
      
      The changes to test-mq-caches.t reverse changes introduced by a5917346c72e. The
      cache should not have been updated with mq records.
      
      The changes to test-keyword.t are indirectly caused by a5917346c72e.
      
      Reported and analyzed by Yuya Nishihara <yuya@tcha.org>
      
      Notes:
      - qpush still makes a slow path _branchtags() call when checking heads. Maybe
        this can be optimized.
      - be careful when merging this patch in default as secretcommit() was renamed
        newcommit() right after the end of the code freeze.
      20ad8f05
    • Patrick Mézard's avatar
      mq: ensure all mq commits are made with secretcommit() · 24df9338
      Patrick Mézard authored
      Having a common code path helps fixing things globally.
      24df9338
  6. Feb 08, 2012
    • Jim Hague's avatar
      tests: tighten checks for octal escapes in shell printf. · c6c9b83a
      Jim Hague authored
      printf on AIX default shell ksh (89) says \1 is an invalid escape. It insists
      on at least 2 digits. This causes failures in test-keyword.t and test-status.t.
      
      check-code.py already looks out for \NNN and recommends using Python
      for outputting octal values. Extend the check to \NN and \N and fix up
      resulting failures.
      c6c9b83a
  7. Feb 06, 2012
  8. Feb 04, 2012
  9. Feb 03, 2012
    • Jim Hague's avatar
      bdiff: fix malloc(0) issue in fixws() · 8134ec86
      Jim Hague authored
      If fixws() is called on a zero-length string, malloc(0) is called and
      expected to return a pointer. Which it does on e.g. Linux. AIX returns
      NULL, which it is also legal, but the malloc() is then assumed to have
      failed. So ensure a valid pointer is always returned.
      8134ec86
  10. Feb 06, 2012
    • Katsunori FUJIWARA's avatar
      forget: show warning messages for forgetting in subrepo correctly · f11eee00
      Katsunori FUJIWARA authored
      in 'cmdutil.forget()':
      
         for f in match.files():
             if match.exact(f) or not explicitonly:
                 ....
      
      is equal to:
      
         for f in match.files():
             if True:
                 ....
      
      because 'f' from 'match.files()' should 'match.exact(f)':
      
          - 'match.files()' returns 'self._files'
          - 'match.exact(f)' examines 'f in self._fmap',
          - 'self._fmap' of match is 'set(self._files)'
      
      then, 'explicitonly' wants to suppress warning messges, if it is true
      (= 'cmdutil.forget()' is invoked from 'subrepo.forget()').
      
      so, current code should be fixed as:
      
          if not explicitonly:
              for f in match.files():
                 ....
      f11eee00
  11. Feb 04, 2012
    • Jim Hague's avatar
      tests: fix command line overflow on ksh · f680ed10
      Jim Hague authored
      "<command> `hg manifest`" overflows the puny 1024 byte command line length
      limit on AIX default shell ksh. Replace with "hg manifest | xargs <command>".
      f680ed10
  12. Feb 05, 2012
  13. Feb 03, 2012
  14. Feb 01, 2012
  15. Jan 31, 2012
  16. Jan 30, 2012
Loading