- Jun 15, 2018
-
-
Yuya Nishihara authored
Before, uninitialized self->pydata would be passed to lazymanifest_dealloc() on OOM, and Py_DECREF(self->pydata) would crash if we were unlucky. It's still wrong to do malloc() thingy in tp_init because __init__() may be called more than once [1], but I don't want to go a step further in stable branch. [1]: https://docs.python.org/2/c-api/typeobj.html#c.PyTypeObject.tp_new "The tp_new function should ... do only as much further initialization as is absolutely necessary. Initialization that can safely be ignored or repeated should be placed in the tp_init handler."
-
Augie Fackler authored
Differential Revision: https://phab.mercurial-scm.org/D3749
-
- Jun 14, 2018
-
-
Jun Wu authored
`@@ -1,1 +-1,0 @@` is not a valid patch hunk header. Change it to `@@ -1,1 +0,0 @@`. Differential Revision: https://phab.mercurial-scm.org/D3737
-
- Jun 13, 2018
-
-
Jeff Sipek authored
self->lines can be NULL if we failed to allocate memory for it.
-
Jeff Sipek authored
There is no need to check for a NULL pointer before calling free since free(NULL) is defined by C standards as a no-op. Lots of software relies on this behavior so it is completely safe to call even on the most obscure of systems.
-
- May 21, 2018
-
-
Augie Fackler authored
This is a graft of 0b39edeff033 and f44306940c94 from default because I'm tired of seeing the FreeBSD build be red on stable. See those revisions for details on what's going on here.
-
- Jun 06, 2018
-
-
Jun Wu authored
Spot by Wez Furlong. `memcpy(x, NULL, 0)` is undefined according to [1]. [1]: https://stackoverflow.com/questions/5243012 Differential Revision: https://phab.mercurial-scm.org/D3698
-
durin42 authored
-
durin42 authored
-
- May 01, 2018
-
-
Augie Fackler authored
All the callers of this function can handle a NULL return, so that appears to be the "safe" way to report an error.
-
Augie Fackler authored
-
Augie Fackler authored
-
Augie Fackler authored
-
- May 03, 2018
-
-
Augie Fackler authored
Same reason as safeadd().
-
- May 01, 2018
-
-
Augie Fackler authored
We're about to make extensive use of this. This change duplicates some stdbool.h portability hacks from cext/util.h. We should probably clean that up in the future, but we'll skip that for now in order to make security backports easier.
-
- Apr 28, 2018
-
-
Augie Fackler authored
Caught by oss-fuzz fuzzer during development. This defect is OVE-20180430-0004. A CVE has not been obtained as of this writing.
-
Augie Fackler authored
Also caught by oss-fuzz fuzzer during development. This defect is OVE-20180430-0002. A CVE has not been obtained as of this writing.
-
Augie Fackler authored
It appears to have been possible to trivially walk off the end of an allocated region with a malformed patch. Oops. Caught when writing an mpatch fuzzer for oss-fuzz. This defect is OVE-20180430-0001. A CVE has not been obtained as of this writing.
-
- Jun 06, 2018
-
-
Gregory Szorc authored
This changeset contains the meaningful code changes from python-zstandard's 0.9.1 release. The main fix is to restore support for compiling with mingw.
-
Anton Shestakov authored
When "keep" argument is provided, the function returns (text, pruned), where pruned is a list of sections from the original plain text that were pruned from the rendered result. Let's not output it together with the rendered HTML.
-
Anton Shestakov authored
Notice at the bottom of the help text there's "windows". It's a section that is in the original help text, but was pruned (because hgweb didn't ask for it).
-
Matt Harbison authored
The key to reproducing this seems to be missing an obsolete node that is not an ancestor of the destination.
-
- Jun 02, 2018
-
-
Matt Harbison authored
This should also cover the transplant extension, and any other non clearable states.
-
Matt Harbison authored
-
- Jun 01, 2018
-
-
Matt Harbison authored
The line endings are explicitly converted because this was ending up with '\r (no-eol) (esc)' lines, in addition to the usual '\r (esc)' lines. I've seen the fakerc output on other recently installed systems though (10.13 and/or Fedora 26). Unfortunately, the output here uses '\\' on Windows, so glob away the whole path.
-
Matt Harbison authored
The output of `pylint` is voluminous enough that it fills the buffer on Windows, and waited for the parent to read it out. But the parent was waiting on the child to exit. I'm not sure what the intent of setting `ret = -1` in the exception handler just above this was...
-
- May 31, 2018
-
-
Matt Harbison authored
There are only a handful of methods that access repo attributes that are applied in reposetup(). The `diff` test covers all of the commands that call scmutil.prefetchfiles(). Along the way, I saw that adding files and upgrading the repo format were also problems (also tested here). I don't think running `hg serve` through the commandserver is sane, but I conditionalized both the capabilities and the wsgirequest handler because it's trivially correct. It doesn't look like there has ever been a caller of candownload(), so there's no test for that path. The upload case isn't testable, because uploadblobs() bails if there are no pointers. The requirement should be added any time pointers are introduced, and that would force the extension to be loaded specifically for the repo. This covers `debuglfsupload`, the pre-push hook (which isn't set until the repo is promoted to LFS), and uploadblobsfromrevs(), which can be called by other extensions. I think readfromstore() and writetostore() are only reachable as a flag processor for revlog.REVIDX_EXTSTORED, and a requirement is added as soon as that is seen, so I don't think those are a problem.
-
- May 24, 2018
-
-
Yuya Nishihara authored
Without the dots, it looked as if separate() would take a list of arguments.
-
- May 18, 2018
-
-
Yuya Nishihara authored
According to the issue 5889, mod_wsgi issues a warning on signal.signal() call, and we wouldn't want to see it in error log. The problem addressed by d77c3b023393 could potentially occur in web session, but that would be less likely than in user processes.
-
Yuya Nishihara authored
signal.signal() is blocked in some WSGI environments, and a horrible warning is sent to the server log. So we need a way to disable it, and I think abusing ui.config is the simplest workaround.
-
- May 23, 2018
-
-
Augie Fackler authored
-
- May 04, 2018
-
-
Wagner Bruna authored
-
Wagner Bruna authored
-
- May 01, 2018
-
-
Katsunori FUJIWARA authored
-
- May 21, 2018
-
-
Boris Feld authored
As we just saw in the previous changeset, having the variable defined into a branch creates bug. This is a cheap to move it at the function level.
-
- May 04, 2018
-
-
Boris Feld authored
The "dbg" local variable is only defined if the 'debugflag' is set to True. However, it was used indiscriminately later in the function. We hide its usage behind the 'debugflag' value to avoid raising a NameError.
-
- May 15, 2018
-
-
Yuya Nishihara authored
This code was added by 3f5e75c22585 "push: make locking of source optional (issue3684)", but EACCES isn't the only error that could be triggered by filesystem permission. I think catching LockUnavailable is more appropriate than testing errno value by caller.
-
- May 12, 2018
-
-
Julien Cristau authored
"l" in Py_BuildValue's format string means long, so passing int64_t instead results in fireworks on 32bit architectures. Differential Revision: https://phab.mercurial-scm.org/D3538
-
- May 11, 2018
-
-
Yuya Nishihara authored
Silly mistake in f83cb91b052e.
-
Yuya Nishihara authored
This is broken since f83cb91b052e "revset: pass in lookup function instead of repo (API)."
-