Skip to content
Snippets Groups Projects
  1. Mar 02, 2019
    • Ian Moody's avatar
      phabricator: convert conduit response JSON unicode to bytes inside callconduit · c340a8ac7ef3
      Ian Moody authored
      Previously the byte conversion was happening piecemeal in callers, and in the
      case of createdifferentialrevision not at all, leading to UnicodeEncodeErrors
      when trying to phabsend a commit with a description containing characters not
      representable in ascii. (issue6040)
      
      Remove all the scattered encoding.unitolocal calls and perform it once, inside
      callconduit, on the entire response dict recursively before returning it, in
      keeping with the strategy of converting at the earliest opportunity. Convert all
      keys used on returned object to bytes.
      
      Modify the phabsend tests to test this by adding a € to the commit message of
      alpha.
      
      Differential Revision: https://phab.mercurial-scm.org/D6044
      c340a8ac7ef3
  2. Feb 09, 2019
    • Pierre-Yves David's avatar
      transaction: include txnname in the hookargs dictionary · 94faa2e84094
      Pierre-Yves David authored
      There is no reason to not include the txnname alongside the txnid in all case.
      The python hooks already have them, so aligning the the shell hooks seems it
      could be useful in the future.
      
      (I don't have a strong opinion about this, we can also decide to never align the
      python and shell hooks and this and I'll drop this patch).
      94faa2e84094
  3. Mar 07, 2019
  4. Mar 09, 2019
  5. Mar 08, 2019
    • Matt Harbison's avatar
      tests: stabilize test-share.t on Windows · e82c932c01e3
      Matt Harbison authored
      PYTHON was not getting mangled for MSYS style paths, and remote was spitting out
      
          remote: 'C' is not recognized as an internal or external command,
          remote: operable program or batch file.
      
      (once -q was removed).  Additionally, this should fix a failure with py3 because
      of spaces in the path.
      e82c932c01e3
  6. Mar 03, 2019
  7. Mar 07, 2019
  8. Mar 06, 2019
  9. Feb 28, 2019
  10. Mar 05, 2019
  11. Feb 27, 2019
  12. Mar 06, 2019
  13. Mar 04, 2019
  14. Feb 11, 2019
  15. Mar 05, 2019
Loading