Skip to content
Snippets Groups Projects
  1. Dec 14, 2020
    • Pierre-Yves David's avatar
      copies: iterate over children directly (instead of parents) · d7b06fbab290
      Pierre-Yves David authored
      Before this change we would gather all parent → child edges and iterate on
      all parent, gathering copy information for children and aggregating them from
      there.
      
      They are not strict requirement for edges to be processed in that specific
      order. We could also simply iterate over all "children" revision and aggregate
      data from both parents at the same time. This patch does that.
      
      It make various things simpler:
      
       * since both parents are processed at the same time, we no longer need to
         cache data for merge (see next changeset for details),
      
       * we no longer need nested loop to process data,
      
       * we no longer need to store partial merge data for a rev from distinct loop
         interaction to another when processing merges,
      
       * we no longer need to build a full parent -> children mapping (we only rely on
         a simpler "parent -> number of children" map (for memory efficiency),
      
       * the data access pattern is now simpler (from lower revisions to higher
         revisions) and entirely predicable. That predictability open the way to
         prefetching and parallel processing.
      
      So that new iterations order requires simpler code and open the way to
      interesting optimisation.
      
      The effect on performance is quite good. In the worse case, we don't see any
      significant negative impact. And in the best case, the reduction of roundtrip
      to Python provide us with a significant speed. Some example below:
      
      Repo            Case                                  Source-Rev   Dest-Rev      # of revisions  old time    new time      Difference    Factor    time per rev
      ---------------------------------------------------------------------------------------------------------------------------------------------------------------
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c :  34414 revs,   0.962867 s,   0.502584 s,  -0.460283 s, × 0.5220,    14 µs/rev
      mozilla-try     x0000_revs_xx000_added_x_copies       156f6e2674f2 4d0f2c178e66 :   8598 revs,   0.110717 s,   0.076323 s,  -0.034394 s, × 0.6894,     8 µs/rev
      
      
      
      # full comparison between the previous changeset and this one
      
      Repo            Case                                  Source-Rev   Dest-Rev      # of revisions  old time    new time      Difference    Factor    time per rev
      ---------------------------------------------------------------------------------------------------------------------------------------------------------------
      mercurial       x_revs_x_added_0_copies               ad6b123de1c7 39cfcef4f463 :      1 revs,   0.000048 s,   0.000041 s,  -0.000007 s, × 0.8542,    41 µs/rev
      mercurial       x_revs_x_added_x_copies               2b1c78674230 0c1d10351869 :      6 revs,   0.000153 s,   0.000102 s,  -0.000051 s, × 0.6667,    17 µs/rev
      mercurial       x000_revs_x000_added_x_copies         81f8ff2a9bf2 dd3267698d84 :   1032 revs,   0.004209 s,   0.004254 s,  +0.000045 s, × 1.0107,     4 µs/rev
      pypy            x_revs_x_added_0_copies               aed021ee8ae8 099ed31b181b :      9 revs,   0.000203 s,   0.000282 s,  +0.000079 s, × 1.3892,    31 µs/rev
      pypy            x_revs_x000_added_0_copies            4aa4e1f8e19a 359343b9ac0e :      1 revs,   0.000059 s,   0.000048 s,  -0.000011 s, × 0.8136,    48 µs/rev
      pypy            x_revs_x_added_x_copies               ac52eb7bbbb0 72e022663155 :      7 revs,   0.000194 s,   0.000211 s,  +0.000017 s, × 1.0876,    30 µs/rev
      pypy            x_revs_x00_added_x_copies             c3b14617fbd7 ace7255d9a26 :      1 revs,   0.000380 s,   0.000375 s,  -0.000005 s, × 0.9868,   375 µs/rev
      pypy            x_revs_x000_added_x000_copies         df6f7a526b60 a83dc6a2d56f :      6 revs,   0.010588 s,   0.010574 s,  -0.000014 s, × 0.9987,  1762 µs/rev
      pypy            x000_revs_xx00_added_0_copies         89a76aede314 2f22446ff07e :   4785 revs,   0.048961 s,   0.049974 s,  +0.001013 s, × 1.0207,    10 µs/rev
      pypy            x000_revs_x000_added_x_copies         8a3b5bfd266e 2c68e87c3efe :   6780 revs,   0.083612 s,   0.084300 s,  +0.000688 s, × 1.0082,    12 µs/rev
      pypy            x000_revs_x000_added_x000_copies      89a76aede314 7b3dda341c84 :   5441 revs,   0.058579 s,   0.060128 s,  +0.001549 s, × 1.0264,    11 µs/rev
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :  43645 revs,   0.736783 s,   0.686542 s,  -0.050241 s, × 0.9318,    15 µs/rev
      pypy            x0000_revs_xx000_added_0_copies       bf2c629d0071 4ffed77c095c :      2 revs,   0.022050 s,   0.009277 s,  -0.012773 s, × 0.4207,  4638 µs/rev
      pypy            x0000_revs_xx000_added_x000_copies    08ea3258278e d9fa043f30c0 :  11316 revs,   0.120800 s,   0.114733 s,  -0.006067 s, × 0.9498,    10 µs/rev
      netbeans        x_revs_x_added_0_copies               fb0955ffcbcd a01e9239f9e7 :      2 revs,   0.000140 s,   0.000081 s,  -0.000059 s, × 0.5786,    40 µs/rev
      netbeans        x_revs_x000_added_0_copies            6f360122949f 20eb231cc7d0 :      2 revs,   0.000114 s,   0.000107 s,  -0.000007 s, × 0.9386,    53 µs/rev
      netbeans        x_revs_x_added_x_copies               1ada3faf6fb6 5a39d12eecf4 :      3 revs,   0.000224 s,   0.000173 s,  -0.000051 s, × 0.7723,    57 µs/rev
      netbeans        x_revs_x00_added_x_copies             35be93ba1e2c 9eec5e90c05f :      9 revs,   0.000723 s,   0.000698 s,  -0.000025 s, × 0.9654,    77 µs/rev
      netbeans        x000_revs_xx00_added_0_copies         eac3045b4fdd 51d4ae7f1290 :   1421 revs,   0.009665 s,   0.009248 s,  -0.000417 s, × 0.9569,     6 µs/rev
      netbeans        x000_revs_x000_added_x_copies         e2063d266acd 6081d72689dc :   1533 revs,   0.014820 s,   0.015446 s,  +0.000626 s, × 1.0422,    10 µs/rev
      netbeans        x000_revs_x000_added_x000_copies      ff453e9fee32 411350406ec2 :   5750 revs,   0.076049 s,   0.074373 s,  -0.001676 s, × 0.9780,    12 µs/rev
      netbeans        x0000_revs_xx000_added_x000_copies    588c2d1ced70 1aad62e59ddd :  66949 revs,   0.683603 s,   0.639870 s,  -0.043733 s, × 0.9360,     9 µs/rev
      mozilla-central x_revs_x_added_0_copies               3697f962bb7b 7015fcdd43a2 :      2 revs,   0.000161 s,   0.000088 s,  -0.000073 s, × 0.5466,    44 µs/rev
      mozilla-central x_revs_x000_added_0_copies            dd390860c6c9 40d0c5bed75d :      8 revs,   0.000234 s,   0.000199 s,  -0.000035 s, × 0.8504,    24 µs/rev
      mozilla-central x_revs_x_added_x_copies               8d198483ae3b 14207ffc2b2f :      9 revs,   0.000247 s,   0.000171 s,  -0.000076 s, × 0.6923,    19 µs/rev
      mozilla-central x_revs_x00_added_x_copies             98cbc58cc6bc 446a150332c3 :      7 revs,   0.000630 s,   0.000592 s,  -0.000038 s, × 0.9397,    84 µs/rev
      mozilla-central x_revs_x000_added_x000_copies         3c684b4b8f68 0a5e72d1b479 :      3 revs,   0.003286 s,   0.003151 s,  -0.000135 s, × 0.9589,  1050 µs/rev
      mozilla-central x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :      6 revs,   0.062441 s,   0.061612 s,  -0.000829 s, × 0.9867, 10268 µs/rev
      mozilla-central x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   1593 revs,   0.005423 s,   0.005381 s,  -0.000042 s, × 0.9923,     3 µs/rev
      mozilla-central x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :     41 revs,   0.005919 s,   0.003742 s,  -0.002177 s, × 0.6322,    91 µs/rev
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :   7839 revs,   0.062597 s,   0.061983 s,  -0.000614 s, × 0.9902,     7 µs/rev
      mozilla-central x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :    615 revs,   0.043551 s,   0.019861 s,  -0.023690 s, × 0.4560,    32 µs/rev
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :  30263 revs,   0.192475 s,   0.188101 s,  -0.004374 s, × 0.9773,     6 µs/rev
      mozilla-central x00000_revs_x0000_added_x0000_copies  6832ae71433c 4c222a1d9a00 : 153721 revs,   1.955575 s,   1.806696 s,  -0.148879 s, × 0.9239,    11 µs/rev
      mozilla-central x00000_revs_x00000_added_x000_copies  76caed42cf7c 1daa622bbe42 : 204976 revs,   2.886501 s,   2.682987 s,  -0.203514 s, × 0.9295,    13 µs/rev
      mozilla-try     x_revs_x_added_0_copies               aaf6dde0deb8 9790f499805a :      2 revs,   0.001181 s,   0.000852 s,  -0.000329 s, × 0.7214,   426 µs/rev
      mozilla-try     x_revs_x000_added_0_copies            d8d0222927b4 5bb8ce8c7450 :      2 revs,   0.001189 s,   0.000859 s,  -0.000330 s, × 0.7225,   429 µs/rev
      mozilla-try     x_revs_x_added_x_copies               092fcca11bdb 936255a0384a :      4 revs,   0.000563 s,   0.000150 s,  -0.000413 s, × 0.2664,    37 µs/rev
      mozilla-try     x_revs_x00_added_x_copies             b53d2fadbdb5 017afae788ec :      2 revs,   0.001548 s,   0.001158 s,  -0.000390 s, × 0.7481,   579 µs/rev
      mozilla-try     x_revs_x000_added_x000_copies         20408ad61ce5 6f0ee96e21ad :      1 revs,   0.027782 s,   0.027240 s,  -0.000542 s, × 0.9805, 27240 µs/rev
      mozilla-try     x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :      6 revs,   0.062781 s,   0.062824 s,  +0.000043 s, × 1.0007, 10470 µs/rev
      mozilla-try     x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   1593 revs,   0.005778 s,   0.005463 s,  -0.000315 s, × 0.9455,     3 µs/rev
      mozilla-try     x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :     41 revs,   0.006192 s,   0.004238 s,  -0.001954 s, × 0.6844,   103 µs/rev
      mozilla-try     x000_revs_x000_added_x000_copies      1346fd0130e4 4c65cbdabc1f :   6657 revs,   0.065391 s,   0.064113 s,  -0.001278 s, × 0.9805,     9 µs/rev
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 :  40314 revs,   0.317216 s,   0.294063 s,  -0.023153 s, × 0.9270,     7 µs/rev
      mozilla-try     x0000_revs_x_added_x_copies           9fe69ff0762d bcabf2a78927 :  38690 revs,   0.303119 s,   0.281493 s,  -0.021626 s, × 0.9287,     7 µs/rev
      mozilla-try     x0000_revs_xx000_added_x_copies       156f6e2674f2 4d0f2c178e66 :   8598 revs,   0.110717 s,   0.076323 s,  -0.034394 s, × 0.6894,     8 µs/rev
      mozilla-try     x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :    615 revs,   0.045739 s,   0.020390 s,  -0.025349 s, × 0.4458,    33 µs/rev
      mozilla-try     x0000_revs_xx000_added_x000_copies    89294cd501d9 7ccb2fc7ccb5 :  97052 revs,   3.098021 s,   3.023879 s,  -0.074142 s, × 0.9761,    31 µs/rev
      mozilla-try     x0000_revs_x0000_added_x0000_copies   e928c65095ed e951f4ad123a :  52031 revs,   0.771480 s,   0.735549 s,  -0.035931 s, × 0.9534,    14 µs/rev
      mozilla-try     x00000_revs_x_added_0_copies          6a320851d377 1ebb79acd503 : 363753 revs,  18.813422 s,  18.568900 s,  -0.244522 s, × 0.9870,    51 µs/rev
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c :  34414 revs,   0.962867 s,   0.502584 s,  -0.460283 s, × 0.5220,    14 µs/rev
      mozilla-try     x00000_revs_x_added_x_copies          5173c4b6f97c 95d83ee7242d : 362229 revs,  18.684923 s,  18.356645 s,  -0.328278 s, × 0.9824,    50 µs/rev
      mozilla-try     x00000_revs_x000_added_x_copies       9126823d0e9c ca82787bb23c : 359344 revs,  18.296305 s,  18.250393 s,  -0.045912 s, × 0.9975,    50 µs/rev
      mozilla-try     x00000_revs_x0000_added_x0000_copies  8d3fafa80d4b eb884023b810 : 192665 revs,   3.061887 s,   2.792459 s,  -0.269428 s, × 0.9120,    14 µs/rev
      mozilla-try     x00000_revs_x00000_added_x0000_copies 1b661134e2ca 1ae03d022d6d : 228985 revs, 103.869641 s, 107.697264 s,  +3.827623 s, × 1.0369,   470 µs/rev
      mozilla-try     x00000_revs_x00000_added_x000_copies  9b2a99adc05e 8e29777b48e6 : 382065 revs,  64.262957 s,  63.961040 s,  -0.301917 s, × 0.9953,   167 µs/rev
      
      Differential Revision: https://phab.mercurial-scm.org/D9422
      d7b06fbab290
    • Pierre-Yves David's avatar
      copies: document the current algorithm step · 8cfbe85496b0
      Pierre-Yves David authored
      We are about to reorganise everything and we document the "old" way to clarify
      the change that leads to the "new way".
      
      Differential Revision: https://phab.mercurial-scm.org/D9581
      8cfbe85496b0
  2. Dec 17, 2020
  3. Dec 15, 2020
  4. Dec 14, 2020
  5. Dec 17, 2020
  6. Apr 21, 2020
  7. Nov 21, 2020
    • Pierre-Yves David's avatar
      copies-rust: add smarter approach for merging small mapping with large mapping · c94d013e2299
      Pierre-Yves David authored
      The current approach (finding the smaller updated set) works great when the
      mapping have similar size, but do a lot of unnecessary work when one side is
      tinier than the other one. So we do better in theses cases. See inline
      documentation for details.
      
      It give a sizeable boost to many of out slower cases:
      
      Repo            Case                                  Source-Rev   Dest-Rev      # of revisions  old time    new time      Difference    Factor    time per rev
      ---------------------------------------------------------------------------------------------------------------------------------------------------------------
      mozilla-try     x00000_revs_x_added_0_copies          6a320851d377 1ebb79acd503 : 363753 revs,  18.123103 s,   5.693818 s, -12.429285 s, × 0.3142,    15 µs/rev
      mozilla-try     x00000_revs_x_added_x_copies          5173c4b6f97c 95d83ee7242d : 362229 revs,  17.907312 s,   5.677655 s, -12.229657 s, × 0.3171,    15 µs/rev
      mozilla-try     x00000_revs_x000_added_x_copies       9126823d0e9c ca82787bb23c : 359344 revs,  17.684797 s,   5.563370 s, -12.121427 s, × 0.3146,    15 µs/rev
      mozilla-try     x00000_revs_x0000_added_x0000_copies  8d3fafa80d4b eb884023b810 : 192665 revs,   2.881471 s,   2.864099 s,  -0.017372 s, × 0.9940,    14 µs/rev
      mozilla-try     x00000_revs_x00000_added_x000_copies  9b2a99adc05e 8e29777b48e6 : 382065 revs,  63.148971 s,  59.498652 s,  -3.650319 s, × 0.9422,   155 µs/rev
      mozilla-try     x00000_revs_x00000_added_x000_copies  9b2a99adc05e 8e29777b48e6 : 382065 revs,  63.148971 s,  59.498652 s,  -3.650319 s, × 0.9422,   155 µs/rev
      
      
      ideally, the im-rs object would have a `merge` method, but it does not (yet)
      
      Full timing comparison below (they are one pathological case than become even
      worse, for unclear reason).
      
      Repo            Case                                  Source-Rev   Dest-Rev      # of revisions  old time    new time      Difference    Factor    time per rev
      ---------------------------------------------------------------------------------------------------------------------------------------------------------------
      mercurial       x_revs_x_added_0_copies               ad6b123de1c7 39cfcef4f463 :      1 revs,   0.000043 s,   0.000042 s,  -0.000001 s, × 0.9767,    42 µs/rev
      mercurial       x_revs_x_added_x_copies               2b1c78674230 0c1d10351869 :      6 revs,   0.000105 s,   0.000104 s,  -0.000001 s, × 0.9905,    17 µs/rev
      mercurial       x000_revs_x000_added_x_copies         81f8ff2a9bf2 dd3267698d84 :   1032 revs,   0.004895 s,   0.004913 s,  +0.000018 s, × 1.0037,     4 µs/rev
      pypy            x_revs_x_added_0_copies               aed021ee8ae8 099ed31b181b :      9 revs,   0.000194 s,   0.000191 s,  -0.000003 s, × 0.9845,    21 µs/rev
      pypy            x_revs_x000_added_0_copies            4aa4e1f8e19a 359343b9ac0e :      1 revs,   0.000050 s,   0.000050 s,  +0.000000 s, × 1.0000,    50 µs/rev
      pypy            x_revs_x_added_x_copies               ac52eb7bbbb0 72e022663155 :      7 revs,   0.000115 s,   0.000112 s,  -0.000003 s, × 0.9739,    16 µs/rev
      pypy            x_revs_x00_added_x_copies             c3b14617fbd7 ace7255d9a26 :      1 revs,   0.000289 s,   0.000288 s,  -0.000001 s, × 0.9965,   288 µs/rev
      pypy            x_revs_x000_added_x000_copies         df6f7a526b60 a83dc6a2d56f :      6 revs,   0.010513 s,   0.010411 s,  -0.000102 s, × 0.9903,  1735 µs/rev
      pypy            x000_revs_xx00_added_0_copies         89a76aede314 2f22446ff07e :   4785 revs,   0.051474 s,   0.052852 s,  +0.001378 s, × 1.0268,    11 µs/rev
      pypy            x000_revs_x000_added_x_copies         8a3b5bfd266e 2c68e87c3efe :   6780 revs,   0.088086 s,   0.092828 s,  +0.004742 s, × 1.0538,    13 µs/rev
      pypy            x000_revs_x000_added_x000_copies      89a76aede314 7b3dda341c84 :   5441 revs,   0.062176 s,   0.063269 s,  +0.001093 s, × 1.0176,    11 µs/rev
      pypy            x0000_revs_x_added_0_copies           d1defd0dc478 c9cb1334cc78 :  43645 revs,   0.720950 s,   0.711975 s,  -0.008975 s, × 0.9876,    16 µs/rev
      pypy            x0000_revs_xx000_added_0_copies       bf2c629d0071 4ffed77c095c :      2 revs,   0.012897 s,   0.012771 s,  -0.000126 s, × 0.9902,  6385 µs/rev
      pypy            x0000_revs_xx000_added_x000_copies    08ea3258278e d9fa043f30c0 :  11316 revs,   0.121524 s,   0.124505 s,  +0.002981 s, × 1.0245,    11 µs/rev
      netbeans        x_revs_x_added_0_copies               fb0955ffcbcd a01e9239f9e7 :      2 revs,   0.000082 s,   0.000082 s,  +0.000000 s, × 1.0000,    41 µs/rev
      netbeans        x_revs_x000_added_0_copies            6f360122949f 20eb231cc7d0 :      2 revs,   0.000109 s,   0.000111 s,  +0.000002 s, × 1.0183,    55 µs/rev
      netbeans        x_revs_x_added_x_copies               1ada3faf6fb6 5a39d12eecf4 :      3 revs,   0.000175 s,   0.000171 s,  -0.000004 s, × 0.9771,    57 µs/rev
      netbeans        x_revs_x00_added_x_copies             35be93ba1e2c 9eec5e90c05f :      9 revs,   0.000719 s,   0.000708 s,  -0.000011 s, × 0.9847,    78 µs/rev
      netbeans        x000_revs_xx00_added_0_copies         eac3045b4fdd 51d4ae7f1290 :   1421 revs,   0.010426 s,   0.010608 s,  +0.000182 s, × 1.0175,     7 µs/rev
      netbeans        x000_revs_x000_added_x_copies         e2063d266acd 6081d72689dc :   1533 revs,   0.015712 s,   0.015635 s,  -0.000077 s, × 0.9951,    10 µs/rev
      netbeans        x000_revs_x000_added_x000_copies      ff453e9fee32 411350406ec2 :   5750 revs,   0.077353 s,   0.072072 s,  -0.005281 s, × 0.9317,    12 µs/rev
      netbeans        x0000_revs_xx000_added_x000_copies    588c2d1ced70 1aad62e59ddd :  66949 revs,   0.673930 s,   0.682732 s,  +0.008802 s, × 1.0131,    10 µs/rev
      mozilla-central x_revs_x_added_0_copies               3697f962bb7b 7015fcdd43a2 :      2 revs,   0.000089 s,   0.000090 s,  +0.000001 s, × 1.0112,    45 µs/rev
      mozilla-central x_revs_x000_added_0_copies            dd390860c6c9 40d0c5bed75d :      8 revs,   0.000212 s,   0.000210 s,  -0.000002 s, × 0.9906,    26 µs/rev
      mozilla-central x_revs_x_added_x_copies               8d198483ae3b 14207ffc2b2f :      9 revs,   0.000183 s,   0.000182 s,  -0.000001 s, × 0.9945,    20 µs/rev
      mozilla-central x_revs_x00_added_x_copies             98cbc58cc6bc 446a150332c3 :      7 revs,   0.000595 s,   0.000594 s,  -0.000001 s, × 0.9983,    84 µs/rev
      mozilla-central x_revs_x000_added_x000_copies         3c684b4b8f68 0a5e72d1b479 :      3 revs,   0.003117 s,   0.003102 s,  -0.000015 s, × 0.9952,  1034 µs/rev
      mozilla-central x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :      6 revs,   0.060197 s,   0.060234 s,  +0.000037 s, × 1.0006, 10039 µs/rev
      mozilla-central x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   1593 revs,   0.006379 s,   0.006300 s,  -0.000079 s, × 0.9876,     3 µs/rev
      mozilla-central x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :     41 revs,   0.005008 s,   0.004817 s,  -0.000191 s, × 0.9619,   117 µs/rev
      mozilla-central x000_revs_x000_added_x000_copies      7c97034feb78 4407bd0c6330 :   7839 revs,   0.065123 s,   0.065451 s,  +0.000328 s, × 1.0050,     8 µs/rev
      mozilla-central x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :    615 revs,   0.026404 s,   0.026282 s,  -0.000122 s, × 0.9954,    42 µs/rev
      mozilla-central x0000_revs_xx000_added_x000_copies    f78c615a656c 96a38b690156 :  30263 revs,   0.203456 s,   0.206873 s,  +0.003417 s, × 1.0168,     6 µs/rev
      mozilla-central x00000_revs_x0000_added_x0000_copies  6832ae71433c 4c222a1d9a00 : 153721 revs,   1.929809 s,   1.935918 s,  +0.006109 s, × 1.0032,    12 µs/rev
      mozilla-central x00000_revs_x00000_added_x000_copies  76caed42cf7c 1daa622bbe42 : 204976 revs,   2.825064 s,   2.827320 s,  +0.002256 s, × 1.0008,    13 µs/rev
      mozilla-try     x_revs_x_added_0_copies               aaf6dde0deb8 9790f499805a :      2 revs,   0.000857 s,   0.000842 s,  -0.000015 s, × 0.9825,   421 µs/rev
      mozilla-try     x_revs_x000_added_0_copies            d8d0222927b4 5bb8ce8c7450 :      2 revs,   0.000870 s,   0.000870 s,  +0.000000 s, × 1.0000,   435 µs/rev
      mozilla-try     x_revs_x_added_x_copies               092fcca11bdb 936255a0384a :      4 revs,   0.000161 s,   0.000165 s,  +0.000004 s, × 1.0248,    41 µs/rev
      mozilla-try     x_revs_x00_added_x_copies             b53d2fadbdb5 017afae788ec :      2 revs,   0.001147 s,   0.001145 s,  -0.000002 s, × 0.9983,   572 µs/rev
      mozilla-try     x_revs_x000_added_x000_copies         20408ad61ce5 6f0ee96e21ad :      1 revs,   0.026640 s,   0.026500 s,  -0.000140 s, × 0.9947, 26500 µs/rev
      mozilla-try     x_revs_x0000_added_x0000_copies       effb563bb7e5 c07a39dc4e80 :      6 revs,   0.059849 s,   0.059407 s,  -0.000442 s, × 0.9926,  9901 µs/rev
      mozilla-try     x000_revs_xx00_added_0_copies         6100d773079a 04a55431795e :   1593 revs,   0.006326 s,   0.006325 s,  -0.000001 s, × 0.9998,     3 µs/rev
      mozilla-try     x000_revs_x000_added_x_copies         9f17a6fc04f9 2d37b966abed :     41 revs,   0.005188 s,   0.005171 s,  -0.000017 s, × 0.9967,   126 µs/rev
      mozilla-try     x000_revs_x000_added_x000_copies      1346fd0130e4 4c65cbdabc1f :   6657 revs,   0.067633 s,   0.066837 s,  -0.000796 s, × 0.9882,    10 µs/rev
      mozilla-try     x0000_revs_x_added_0_copies           63519bfd42ee a36a2a865d92 :  40314 revs,   0.306969 s,   0.314252 s,  +0.007283 s, × 1.0237,     7 µs/rev
      mozilla-try     x0000_revs_x_added_x_copies           9fe69ff0762d bcabf2a78927 :  38690 revs,   0.293370 s,   0.304160 s,  +0.010790 s, × 1.0368,     7 µs/rev
      mozilla-try     x0000_revs_xx000_added_x_copies       156f6e2674f2 4d0f2c178e66 :   8598 revs,   0.087159 s,   0.089223 s,  +0.002064 s, × 1.0237,    10 µs/rev
      mozilla-try     x0000_revs_xx000_added_0_copies       9eec5917337d 67118cc6dcad :    615 revs,   0.027251 s,   0.026711 s,  -0.000540 s, × 0.9802,    43 µs/rev
      mozilla-try     x0000_revs_xx000_added_x000_copies    89294cd501d9 7ccb2fc7ccb5 :  97052 revs,   3.010011 s,   3.243010 s,  +0.232999 s, × 1.0774,    33 µs/rev
      mozilla-try     x0000_revs_x0000_added_x0000_copies   e928c65095ed e951f4ad123a :  52031 revs,   0.753434 s,   0.756500 s,  +0.003066 s, × 1.0041,    14 µs/rev
      mozilla-try     x00000_revs_x_added_0_copies          6a320851d377 1ebb79acd503 : 363753 revs,  18.123103 s,   5.693818 s, -12.429285 s, × 0.3142,    15 µs/rev
      mozilla-try     x00000_revs_x00000_added_0_copies     dc8a3ca7010e d16fde900c9c :  34414 revs,   0.583206 s,   0.590904 s,  +0.007698 s, × 1.0132,    17 µs/rev
      mozilla-try     x00000_revs_x_added_x_copies          5173c4b6f97c 95d83ee7242d : 362229 revs,  17.907312 s,   5.677655 s, -12.229657 s, × 0.3171,    15 µs/rev
      mozilla-try     x00000_revs_x000_added_x_copies       9126823d0e9c ca82787bb23c : 359344 revs,  17.684797 s,   5.563370 s, -12.121427 s, × 0.3146,    15 µs/rev
      mozilla-try     x00000_revs_x0000_added_x0000_copies  8d3fafa80d4b eb884023b810 : 192665 revs,   2.881471 s,   2.864099 s,  -0.017372 s, × 0.9940,    14 µs/rev
      mozilla-try     x00000_revs_x00000_added_x0000_copies 1b661134e2ca 1ae03d022d6d : 228985 revs, 101.062002 s, 113.297287 s, +12.235285 s, × 1.1211,   494 µs/rev
      mozilla-try     x00000_revs_x00000_added_x000_copies  9b2a99adc05e 8e29777b48e6 : 382065 revs,  63.148971 s,  59.498652 s,  -3.650319 s, × 0.9422,   155 µs/rev
      
      Differential Revision: https://phab.mercurial-scm.org/D9491
      c94d013e2299
    • Pierre-Yves David's avatar
      copies-rust: hide most of the comparison details inside a closure · c58c8f1d63b1
      Pierre-Yves David authored
      The function that compares values needs various supporting elements that are
      the same for each call. We are about to both make change to these element and
      change to call sites in our upcoming work. So abstracting most of the details
      will help to avoid conflict while these works happen in parallel.
      
      Differential Revision: https://phab.mercurial-scm.org/D9426
      c58c8f1d63b1
    • Pierre-Yves David's avatar
      copies-rust: move the mapping merging into a else clause · 94300498491e
      Pierre-Yves David authored
      We are going to add more cases, to it is time to stop using early returns and to
      move everything in a single if/elif/else block for clarity.
      
      Differential Revision: https://phab.mercurial-scm.org/D9425
      94300498491e
    • Pierre-Yves David's avatar
      copies-rust: extract conflicting value comparison in its own function · 61afe6215aef
      Pierre-Yves David authored
      First, that logic is complicated enough to be in it own function. Second, we
      want to start adding alternative path within the merge code so we need this logic
      easily accessible in multiple places.
      
      Differential Revision: https://phab.mercurial-scm.org/D9424
      61afe6215aef
  8. Dec 17, 2020
    • Matt Harbison's avatar
      mergetools: alphabetize the config settings · ceaf1646f420
      Matt Harbison authored
      This will make it easier to identify differences with the TortoiseHg config
      file.  It was simply piped through `sort`, and then the spacing and comments
      restored into the proper place.  The `UltraCompare` config was positioned such
      that the sort is case insensitive- it's the only camelcase config in here.
      
      Differential Revision: https://phab.mercurial-scm.org/D9620
      ceaf1646f420
  9. Dec 14, 2020
  10. Dec 12, 2020
    • Jörg Sonnenberger's avatar
      revlog: support none compression · 84130fd74a22
      Jörg Sonnenberger authored
      revlog files had uncompressed revlog entries support since forever, but
      it wasn't selectable or exposed explicitly. It is occassionally useful
      for performance testing as it avoids the latency of zlib or zstd. It
      also has the nice side effect of providing a non-default compression
      engine out-of-the-box.
      
      Differential Revision: https://phab.mercurial-scm.org/D9572
      84130fd74a22
  11. Nov 12, 2020
  12. Nov 24, 2020
  13. Nov 23, 2020
    • Martin von Zweigbergk's avatar
      errors: raise InputError on early parse error in dispatch · db5dddb38f5b
      Martin von Zweigbergk authored
      I didn't think this would have any effect on the tests, but it does
      because the catching in `scmutil.callcatch()` still happens. That's
      because `dispatch` passes in the function that includes the parsing as
      an argument to that function.
      
      I initially used `ConfigError` here but Matt Harbison convinced me to
      use `InputError`. I think that makes sense since error is not in a
      config file.
      
      Differential Revision: https://phab.mercurial-scm.org/D9387
      db5dddb38f5b
  14. Nov 19, 2020
  15. Dec 10, 2020
  16. Dec 01, 2020
  17. Dec 14, 2020
  18. Dec 03, 2020
  19. Dec 11, 2020
  20. Dec 09, 2020
    • Martin von Zweigbergk's avatar
      mergetools: add new conflict marker format with diffs in · bdc2bf68f19e
      Martin von Zweigbergk authored
      I use 3-way conflict markers. Often when I resolve them, I manually
      compare one the base with one side and apply the differences to the
      other side. That can be hard when the conflict marker is large. This
      patch introduces a new type of conflict marker, which I'm hoping will
      make it easier to resolve conflicts.
      
      The new format uses `<<<<<<<` and `>>>>>>>` to open and close the
      markers, just like our existing 2-way and 3-way conflict
      markers. Instead of having 2 or 3 snapshots (left+right or
      left+base+right), it has a sequence of diffs. A diff looks like this:
      
      ```
      ------- base
      +++++++ left
       a
      -b
      +c
       d
      ```
      
      A diff that adds one side ("diff from nothing") has a `=======` header
      instead and does not have have `+` prefixed on its lines. A regular
      3-way merge can be viewed as adding one side plus a diff between the
      base and the other side. It thus has two ways of being represented,
      depending on which side is being diffed:
      
      ```
      <<<<<<<
      ======= left
      contents
      on
      left
      ------- base
      +++++++ right
       contents
       on
      -left
      +right
      >>>>>>>
      ```
      or
      ```
      <<<<<<<
      ------- base
      +++++++ left
       contents
       on
      -right
      +left
      ======= right
      contents
      on
      right
      >>>>>>>
      ```
      
      I've made it so the new merge tool tries to pick a version that has
      the most common lines (no difference in the example above).
      
      
      I've called the new tool "mergediff" to stick to the convention of
      starting with "merge" if the tool tries a regular 3-way merge.
      
      The idea came from my pet VCS (placeholder name `jj`), which has
      support for octopus merges and other ways of ending up with merges of
      more than 3 versions. I wanted to be able to represent such conflicts
      in the working copy and therefore thought of this format (although I
      have not yet implemented it in my VCS). I then attended a meeting with
      Larry McVoy, who said BitKeeper has an option (`bk smerge -g`) for
      showing a similar format, which reminded me to actually attempt this
      in Mercurial.
      
      Differential Revision: https://phab.mercurial-scm.org/D9551
      bdc2bf68f19e
  21. Dec 10, 2020
Loading