Skip to content
Snippets Groups Projects
  1. Dec 11, 2023
    • Pierre-Yves David's avatar
      changelog: never inline changelog · dcaa2df1f688
      Pierre-Yves David authored
      The test suite mostly use small repositories, that implies that most changelog in the
      tests are inlined. As a result, non-inlined changelog are quite poorly tested.
      Since non-inline changelog are most common case for serious repositories, this
      lack of testing is a significant problem that results in high profile issue like
      the one recently fixed by 66417f55ea33 and 849745d7da89.
      
      Inlining the changelog does not bring much to the table, the number of total
      file saved is negligible, and the changelog will be read by most operation
      anyway.
      
      So this changeset is make it so we never inline the changelog, and de-inline the
      one that are still inlined whenever we touch them.
      
      By doing that, we remove the "dual code path" situation for writing new entry to
      the changelog and move to a "single code path" situation. Having a single
      code path simplify the code and make sure it is covered by test (if test cover
      that situation obviously)
      
      
      This impact all tests that care about the number of file and the exchange size,
      but there is nothing too complicated in them just a lot of churn.
      
      The churn is made "worse" by the fact rust will use the persistent nodemap on
      any changelog now. Which is overall a win as it means testing the persistent
      nodemap more and having less special cases.
      
      In short, having inline changelog is mostly useless and an endless source of
      pain. We get rid of it.
      dcaa2df1f688
    • Pierre-Yves David's avatar
      test-transaction-safety: glog out irrelevant flag · 2e0b2a387502
      Pierre-Yves David authored
      The test is focussing on the inline flag, so we glob out the other to highlight
      that fact and prevent noise in the future.
      2e0b2a387502
    • Pierre-Yves David's avatar
      test-transaction-safety: perform the test on a filelog · cf23a8432f51
      Pierre-Yves David authored
      This test previously checked the transaction safety of splitting the changelog.
      The changelog is a special case, with delayed/diverted writes and we will stop
      inlining it soon. So we keep testing that transaction is safe around inline on
      another revlog type : a filelog.
      
      Minor comestic adjustement will be done in the next changesets.
      cf23a8432f51
  2. Dec 07, 2023
  3. Dec 12, 2023
  4. Dec 07, 2023
  5. Dec 12, 2023
  6. Dec 07, 2023
  7. Dec 02, 2023
    • Anton Shestakov's avatar
      procutil: move stdin assignment outside of try-finally block · a9e00554b3e4
      Anton Shestakov authored
      There is an stdin variable in the global scope of this module. And in the
      `finally` block of this try-finally statement we're checking `if stdin is not
      None`.  Let's make sure we don't confuse code check tools into thinking we want
      to use global stdin by moving this line of code outside of `try`.
      
      This was caught by pytype 2023.11.21 on Python 3.11.2.
      a9e00554b3e4
    • Anton Shestakov's avatar
      zeroconf: give inet_aton() str instead of bytes · b79f13d6ef25
      Anton Shestakov authored
      All other uses of this function in this extension are already fixed (i.e. use
      strings instead of bytes).
      
      This was caught by pytype 2023.11.21 on Python 3.11.2.
      b79f13d6ef25
  8. Dec 06, 2023
    • Pierre-Yves David's avatar
      revlog: avoid wrongly updating the data file location on "divert" · 849745d7da89
      Pierre-Yves David authored
      If we are in the inline case, we need to align the location of the "data" file
      with the temporary location of the file (i.e. "00changelog.i.a"). However we
      should not do that for non-inline case… and before this changeset we had been
      doing it. In addition `index_file` is already a property taking care of updating
      the "segment file" filename when needed. So we can simply remove all that code.
      
      As a result, code trying to read the diverted data before they were committed
      ended deeply confused as the "00changelog.i.a" file is nothing like the
      "00changelog.d" file.
      
      However nothing corrupted data as all writing where properly handled outside of
      the "segment file".
      
      In "best" cases this small in-memory corruption of the filename when unnoticed
      until the transaction was committed or rolled back and in the worse case, some
      data reading was failing during the transaction and resulted in the transaction
      to be rolled back. However wrong data never reached the disk, so this bug should
      be have corrupted any repository.
      
      This is not catch by tests because most test use a small repository and
      therefor an inline revlog. In addition the bug only triggers when a
      changelog read is done in the following "rare" situation:
      - after some delayed write
      - after that data have been written in a "divert" file (i.e. `00.changelog.i.a`)
      - before transaction commit
      - outside of a "writing" context
      
      The issue was introduced in d83d788590a8
      849745d7da89
    • Pierre-Yves David's avatar
      revlog: avoid exposing delayed index entry too widely in non-inline revlog · 66417f55ea33
      Pierre-Yves David authored
      Before this change, the index entry would be seen as "appended" to the data
      file. It did not hurt too much as there are never accessed for reading, but this
      was odd. So lets stop doing so.
      66417f55ea33
    • Pierre-Yves David's avatar
      revlog: add one more assert about state of thing when splitting · 962974a5d068
      Pierre-Yves David authored
      This assert is currently happy, but it does not hurt to adds it to clarify
      expected state and catch potential error in the future.
      962974a5d068
  9. Nov 29, 2023
  10. Apr 11, 2023
  11. Dec 01, 2023
  12. Dec 02, 2023
  13. Nov 15, 2023
  14. Oct 16, 2023
  15. Dec 03, 2023
  16. Dec 04, 2023
  17. Dec 02, 2023
    • Matt Harbison's avatar
      tests: fill in the Windows pattern for `$EADDRNOTAVAIL$` matching · e2632d9d1b6e
      Matt Harbison authored
      This fixes test-https.t on Windows.
      
      It looks like the real error translation is "Cannot assign requested address.",
      and the message here is the start of a longer description, so I'm not sure why
      this part is emitted.  But it's not worth digging into, as it's evidently the
      same failure.
      e2632d9d1b6e
    • Matt Harbison's avatar
      tests: avoid a cascading failure on Windows · 1dd01023649d
      Matt Harbison authored
      The `identify --debug` command here on Windows emits
      
          skip updating dirstate: identity mismatch
      
      because of the debug switch, which got captured and added to `.hgtags`, and then
      hijinx ensued.  The point of `--debug` seemed to be to get the long hash, so
      just do that with templating.  I have not idea if the message is indicating a
      problem- there seems to be many more of them in other tests that are not present
      on Linux.
      1dd01023649d
    • Matt Harbison's avatar
      phabricator: stringify the argument to `getattr()` · 4ed9efb25bc7
      Matt Harbison authored
      This fixes a "TypeError: getattr(): attribute name must be string" crash and
      subsequent test spew.  This likely broke in 18c8c18993f0 and was missed in CI
      because `pytest-vcr` is missing.
      4ed9efb25bc7
  18. Nov 13, 2023
  19. Nov 27, 2023
  20. Nov 14, 2023
  21. Nov 15, 2023
  22. Sep 07, 2023
Loading