Skip to content
Snippets Groups Projects
  1. May 28, 2018
    • Matt Harbison's avatar
      outgoing: pay attention to `default:pushurl` for bookmarks and subrepos · dfb888aae17a
      Matt Harbison authored
      The problem here was that `default:pushurl` and `default` get translated to a
      single entry in `ui.paths` named 'default', with an attribute for 'pushloc',
      'loc', and 'rawloc'.  ui.expandpath() then always takes the `rawloc` attribute.
      Maybe the ui.expandpath() API is busted and should be removed?  Or maybe
      getpath() should return a copy that adds an attribute reflecting the URL of the
      path chosen?
      
      I thought that I could remove the code in hg._outgoing() and pass the location
      resolved in commands.py as `dest`, but unfortunately that code is needed there
      to resolve #branch type URLs.  Maybe that should be pulled up to commands.py,
      because I can't see any reasonable behavior for a subrepo path that's
      constructed out of that type of URL.
      
      The push command already resolves this early, so that works properly.  But it
      looks like bundle, histedit, largefiles, patchbomb, and summary use a similar
      pattern, so they are likely similarly affected.
      dfb888aae17a
  2. Apr 21, 2018
  3. Mar 07, 2018
  4. Mar 26, 2018
  5. May 26, 2018
  6. May 03, 2018
  7. Apr 27, 2018
  8. May 23, 2018
    • Matt Harbison's avatar
      terse: pconvert() entries added to the temporary terse dict for Windows · c974320d20b9
      Matt Harbison authored
      Recent additional testing revealed this problem on Windows:
      
        --- tests/test-status.t.err
        +++ tests/test-status.t.err
        @@ -109,7 +109,7 @@
      
         tweaking defaults works
           $ hg status --cwd a --config ui.tweakdefaults=yes
        -  ? .
        +  ? ../a/
           ? ../b/
           ? ../in_root
           $ HGPLAIN=1 hg status --cwd a --config ui.tweakdefaults=yes
        @@ -120,7 +120,7 @@
           ? b/in_b (glob)
           ? in_root
           $ HGPLAINEXCEPT=tweakdefaults hg status --cwd a --config ui.tweakdefaults=yes
        -  ? .
        +  ? ..\a\
           ? ../b/
           ? ../in_root (glob)
      
      AFAICT, the status list (input and output here) is always in '/' format.  The
      '\' printed output on Windows is because each file is run through repo.pathto()
      -> dirstate.pathto() -> util.pathto().  (And that function states that the
      argument uses '/' separators.)
      
      I fixed a similar issue in 362096cfdb1f, and given the apparent need for these
      strings to be in '/' format, I wonder if cmdutil.dirnode() should be rewritten
      to avoid os.path.join().  But it looks like all entries added to the temporary
      terse dict should use '/' now, and cmdutil.tersedir() looks like the only user.
      c974320d20b9
  9. May 24, 2018
  10. May 22, 2018
  11. May 21, 2018
    • Boris Feld's avatar
      repoview: use 'phasecache.getrevset' when computing 'unserved' filter · 5b592ac502ef
      Boris Feld authored
      This reuses a precomputed set, being much faster than manual iteration.
      
      Computing the "unserved" filter speed up by 55%.
      
      before: wall 0.014671 comb 0.020000 user 0.020000 sys 0.000000 (best of 180)
      after:  wall 0.006623 comb 0.010000 user 0.010000 sys 0.000000 (best of 401)
      
      The "unserved" filter is used to restrict the revisions client can pull from a
      server. (eg: secret changesets)
      5b592ac502ef
  12. May 25, 2018
  13. Feb 27, 2018
  14. May 24, 2018
  15. Apr 04, 2018
  16. May 22, 2018
  17. May 15, 2018
Loading