Skip to content
Snippets Groups Projects
  1. Apr 17, 2013
    • Pierre-Yves David's avatar
      obsolete: extract obsolescence marker pushing into a dedicated function · f74f2a4e3327
      Pierre-Yves David authored
      Having a dedicated function will allows us to experiment with other exchange
      strategies in an extension. As we have no solid clues about how to do it right,
      being able to experiment is vital.
      
      I intended a more ambitious extraction of push logic, but we are far too
      advanced in the release cycle for it.
      f74f2a4e3327
  2. Apr 18, 2013
  3. Feb 21, 2013
    • Kevin Bullock's avatar
      subrepo: fix test breakage introduced in 2b34d004e644 · 2e5476980a57
      Kevin Bullock authored
      The test didn't break when I originally committed it (git version
      1.7.12.4 (Apple Git-37)), and still doesn't on that machine, but the
      output changes elsewhere with "Warning: you are leaving N commits
      behind..."
      
      This change sets a ref on the commit we're updating the subrepo _away_
      from to quash the warning.
      2e5476980a57
  4. Apr 18, 2013
  5. Feb 01, 2013
  6. Apr 18, 2013
  7. Apr 15, 2013
  8. Apr 17, 2013
  9. Apr 16, 2013
  10. Apr 17, 2013
  11. Apr 16, 2013
    • Pierre-Yves David's avatar
      histedit: move outgoing processing to its own function · 26b41a902195
      Pierre-Yves David authored
      Every piece of code extracted from the main command is a win. We simplify
      changeset determination in the process. Parent ceases being a list before
      becoming a node. We how have a root variable containing a node all the time.
      26b41a902195
    • Pierre-Yves David's avatar
      histedit: move all arguments checks to the beginning of the command · 12c06686d371
      Pierre-Yves David authored
      This changeset move all checks and raises related to arguments
      validation to the top of the file. This gathers all the logic in one
      place and clarifies the code doing actual work. This paves the way for
      splitting this gigantic function in separated functions.
      
      A `goal` variable is introduced in the process. It holds the action to
      be done by this invocation (new, continue or abort).
      
      An invalid invocation is found in the process (the new code is a bit stricter).
      12c06686d371
  12. Apr 17, 2013
  13. Apr 16, 2013
    • Pierre-Yves David's avatar
      histedit: allow "-" as a command file · 730614b9b352
      Pierre-Yves David authored
      When "-" is specified as a command file, we read rules from stdin. Alter a
      single test to demo the behavior, but most of them could benefit from this.
      
      There is minor change in test output resulting from the fact we no
      longer change log messages.
      730614b9b352
    • Pierre-Yves David's avatar
      histedit: properly handle --continue on empty fold · c5c8613f265e
      Pierre-Yves David authored
      When all changes from the fold have been dropped, the --continue code was
      confused. This changeset handles this case.
      
      The test for this case existed but was broken.
      c5c8613f265e
    • Pierre-Yves David's avatar
      histedit-test: replace obscure python script by a plain file · 27ec54f2946e
      Pierre-Yves David authored
      One of the tests uses a python script to edit the histedit commands on
      the fly. It was hard to read and likely to break. This is replaced by
      a plain command file.
      
      Doing so made me discover that the python script is incorrect. The
      "+6" regexp never matched because the revision number is wrong.
      
      This error is kept in the replacement for now. Fixing the histedit command
      triggers a traceback in histedit.
      
      A later changeset will fix the error and restore the intended test.
      27ec54f2946e
    • Pierre-Yves David's avatar
      test: improve documentation of some histedit tests · 07db88f053fe
      Pierre-Yves David authored
      Each test section is clearly separated from the others and gains some
      helpful documentation.
      07db88f053fe
    • Pierre-Yves David's avatar
      test: use a lighter log style in histedit test · 7b50120e8f6e
      Pierre-Yves David authored
      The default log displays a log of information that is useless for
      histedit tests. Having a cleaner log help readability of those tests a
      lot.
      
      This does not change anything to the test semantic.
      7b50120e8f6e
Loading