Skip to content
Snippets Groups Projects
  1. Oct 13, 2018
  2. Oct 12, 2018
  3. Oct 08, 2018
    • Katsunori FUJIWARA's avatar
      tests: drop files from exclusion list in test-check-module-imports.t · f9e3044d
      Katsunori FUJIWARA authored
      Now, these files has no style issue at checking with import-checker.py.
      
      BTW, tests/test-imports-checker.t is still excluded, because almost
      all code fragments in it has intentional importing style violation.
      
      Using NO_CHECK_EOF instead of EOF as heredoc limit mark can make
      import-checker.py ignore such fragments. But keeping these fragments
      checkable seems still useful: for example, test-imports-checker.t can
      be used to test whether import-checker.py can detect erroneous code
      fragment in test script as expected.
      f9e3044d
    • Katsunori FUJIWARA's avatar
      tests: use NO_CHECK_EOF for fragments used to test importing via extension · 37295cee
      Katsunori FUJIWARA authored
      test-extension.t is excluded in test-check-module-imports.t, because
      import-checker.py reports that some python code fragments in it does
      not import modules in recommended style.
      
      These code fragments are used to test importing modules relatively and
      absolutely via extension (e.g. issue4029, issue5208, and so on). Test
      specific package hierarchy becomes complicated for this purpose, and
      it seems reasonable to avoid checking these code fragments with
      import-checker.py.
      
      But on the other hand, other code fragments in test-extension.t should
      be checked by import-checker.py.
      
      Therefore, this patch uses NO_CHECK_EOF limit mark only for python
      code fragments, which are used to test importing via extension in
      test-extension.t. NO_CHECK_EOF limit mark tells import-checker.py that
      this code fragment should be ignored, via testparseutil.py.
      37295cee
    • Katsunori FUJIWARA's avatar
      tests: use NO_CHECK_EOF for fragments having intentional error · 89ba51c3
      Katsunori FUJIWARA authored
      Some test scripts are excluded in test-check-module-imports.t, because
      import-checker.py reports that code fragments embedded in these test
      scripts have syntax error. But these syntax error is intentional.
      
      This patch uses NO_CHECK_EOF instead of EOF as heredoc limit mark for
      such fragments, in order to make import-checker.py ignore
      them. NO_CHECK_EOF limit mark tells import-checker.py that this code
      fragment should be ignored, via testparseutil.py.
      89ba51c3
    • Katsunori FUJIWARA's avatar
      tests: fix style issue of importing order in test-lock.py · 5d50c9ff
      Katsunori FUJIWARA authored
      test-lock.py is excluded in test-check-module-imports.t, because
      import-checker.py reports that some stdlibs are imported after local
      silenttestrunner module.
      
      I can not found out any reason why tests/silenttestrunner.py should be
      imported before some stdlibs from the point of functionality view.
      5d50c9ff
    • Katsunori FUJIWARA's avatar
      tests: fix style issue of importing hgweb in embedded code fragments · f80f7a67
      Katsunori FUJIWARA authored
      Some test scripts are excluded in test-check-module-imports.t, because
      import-checker.py reports that hgweb and/or hgwebdir of
      mercurial.hgweb are not imported in recommended style.
      
      To fix this issues, this patch make python code fragments embedded in
      these files import hgweb from mercurial package at first, and refer
      hgweb and hgwebdir via imported hgweb.
      f80f7a67
  4. Oct 12, 2018
Loading