You need to sign in or sign up before continuing.
Commits on Source (13)
-
Raphaël Gomès authored
This is... really dumb and costs a ton of performance in a hot loop. It was 75% of a profile for a tip to null p1 node traversal in pure Rust. I'm at fault, done in 652149ed64f0. I thought clippy had a lint for this, but apparently not?
155e1e8dc055 -
Raphaël Gomès authored
Same as the previous patch, this is just dumb performance loss.
3fae90405966 -
Mitchell Kember authored
This means that lints configured in rust/Cargo.toml will apply to all crates within the workspace. Currently there are none but I plan to add some.
1ef08a0381a0 -
Mitchell Kember authored
I confirmed that this would have prevented the issue in !1280. For details see: https://rust-lang.github.io/rust-clippy/master/index.html#/or_fun_call
c4392e8bfb9f -
Pierre-Yves David authored
This is a follow up to e6069f84abbb. It turns about that there are multiple test condition that needs cleanup. This handle the usage of the first one.
8c85d139ff64 -
Pierre-Yves David authored
Same rational as the parent changeset.
4d2b496cb7b8 -
Pierre-Yves David authored
Same rational as the parent changeset.
86764cd60c4a -
Pierre-Yves David authored
Same rational the parent changesets.
d3425a2c146c -
Pierre-Yves David authored
Now that all user has been removed, we can safely drop them.
d655382584c5 -
Matt Harbison authored
With `py -3.9 contrib/packaging/packaging.py wix --pyoxidizer-target x86_64-pc-windows-msvc`, there is an immediate failure after building the venv (3.9.13 has `setuptools` 58.1.0): ModuleNotFoundError: No module named 'setuptools.command.build' With that fixed, the same command then fails immediately with this error: Couldn't import setuptools_scm (direct call of setup.py?) Unfortunately, referencing `setuptools` in the requirements file needs `--allow-unsafe` to avoid a warning about not pinning `setuptools`. However, the same warning happens if `setuptools` is pinned to a specific revision, so I have no idea what it is complaining about. It's a separate venv that is only used for packaging, so we can fix it if it becomes a problem in the future. Interestingly, the Inno installer build doesn't fail immediately, and I can see it installing `setuptools` and `setuptools_scm` in the wall of text it emits. Eventually it does fail with the same errors without this change.
0e2be2abd963 -
Matt Harbison authored
The file is now generated by `setuptools_scm`, which stores values as strings with strong quotes. This avoids the following failure at the end of the Inno installer build: <snip> creating installer Traceback (most recent call last): File "c:\Users\Matt\projects\mercurial\mercurial-devel\contrib\packaging\packaging.py", line 70, in <module> run() File "c:\Users\Matt\projects\mercurial\mercurial-devel\contrib\packaging\packaging.py", line 62, in run cli.main() File "c:\Users\Matt\projects\mercurial\mercurial-devel\contrib\packaging\hgpackaging\cli.py", line 154, in main args.func(**kwargs) File "c:\Users\Matt\projects\mercurial\mercurial-devel\contrib\packaging\hgpackaging\cli.py", line 35, in build_inno inno.build_with_pyoxidizer( File "c:\Users\Matt\projects\mercurial\mercurial-devel\contrib\packaging\hgpackaging\inno.py", line 55, in build_with_pyoxidizer build_installer( File "c:\Users\Matt\projects\mercurial\mercurial-devel\contrib\packaging\hgpackaging\inno.py", line 146, in build_installer version = read_version_py(source_dir) File "c:\Users\Matt\projects\mercurial\mercurial-devel\contrib\packaging\hgpackaging\util.py", line 188, in read_version_py raise Exception('could not parse %s' % p) Exception: could not parse c:\Users\Matt\projects\mercurial\mercurial-devel\mercurial\__version__.py Note that non-tagged builds end up with complex version strings, and include characters that WiX rejects. That's probably fine- we don't do nightly or other non-tagged builds for installers. Also note that while the Inno installer is capable of using this version string as part of the installer, the WiX installer is not for some reason. That installer needs to be built with `--version VERSION` to inject the version into the installer metadata and the filename.
d333e14477f1 -
Matt Harbison authored
I noticed this when trying the Inno installer.
80ec613fea43 -
Matt Harbison authored
The comment heavily implies, and experimenting confirms, that there's no `sys.real_prefix` in a venv on Python3. I have no idea how the problems described would manifest, but nobody has complained for the several years of py3 releases build from a venv. The experimenting was done with 6.9.2 and the TortoiseHg build script.
e2c239dae5a2
Showing
- contrib/packaging/hgpackaging/util.py 1 addition, 1 deletioncontrib/packaging/hgpackaging/util.py
- contrib/packaging/requirements.txt 61 additions, 3 deletionscontrib/packaging/requirements.txt
- contrib/packaging/requirements.txt.in 5 additions, 0 deletionscontrib/packaging/requirements.txt.in
- contrib/win32/ReadMe.html 1 addition, 1 deletioncontrib/win32/ReadMe.html
- rust/Cargo.toml 3 additions, 0 deletionsrust/Cargo.toml
- rust/hg-core/Cargo.toml 3 additions, 0 deletionsrust/hg-core/Cargo.toml
- rust/hg-core/src/revlog/index.rs 9 additions, 9 deletionsrust/hg-core/src/revlog/index.rs
- rust/hg-core/src/revlog/mod.rs 3 additions, 1 deletionrust/hg-core/src/revlog/mod.rs
- rust/hg-cpython/Cargo.toml 3 additions, 0 deletionsrust/hg-cpython/Cargo.toml
- rust/hg-pyo3/Cargo.toml 3 additions, 0 deletionsrust/hg-pyo3/Cargo.toml
- rust/pyo3-sharedref/Cargo.toml 3 additions, 0 deletionsrust/pyo3-sharedref/Cargo.toml
- rust/rhg/Cargo.toml 3 additions, 0 deletionsrust/rhg/Cargo.toml
- setup.py 0 additions, 84 deletionssetup.py
- tests/hghave.py 0 additions, 59 deletionstests/hghave.py
- tests/test-audit-path.t 0 additions, 1 deletiontests/test-audit-path.t
- tests/test-bundle.t 9 additions, 47 deletionstests/test-bundle.t
- tests/test-censor.t 0 additions, 1 deletiontests/test-censor.t
- tests/test-clone-stream-format.t 1 addition, 1 deletiontests/test-clone-stream-format.t
- tests/test-clone-stream.t 1 addition, 1 deletiontests/test-clone-stream.t
- tests/test-clone.t 0 additions, 2 deletionstests/test-clone.t