Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mercurial-devel mercurial-devel
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • mercurial
  • mercurial-develmercurial-devel
  • Merge requests
  • !107

Merged
Created May 17, 2022 by Raphaël Gomès@raphael.gomesMaintainer

ci: do not trigger phabricator for merge-request

  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

The fast the phabricator steps has a rules entry makes it selected for the special merge_requests pipelines. The other ones behave as default and are not selected tot the mrege_request pipelines.

This result in a second pipeline to be created, with only the phabricator pipeline in it. Which usually succeed fast (since there is nothing to do).

This is harmful as this create a false sense of "the series is passing" and Gitlab will use this simplistic pipeline for validation.

By explicitly preventing the pipeline to be created in the merge-request case, we prevent this situation to happens

Note that the job will be dropped (alonside phabricator) in the next two weeks anyway.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: topic/stable/ci-fix